From 085be5f5b13139f8a76af32ec3bbba4a9c1ca949 Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Sun, 22 Mar 2026 14:00:49 +0100 Subject: [PATCH] fix: update DQN bounds test for Fast phase (default) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Default phase is now Fast — architecture dims (v_range, hidden_dim, num_atoms, dueling_hidden, branch_hidden) are fixed to [phase_fast] TOML values. Test assertions updated to expect single-point bounds. Co-Authored-By: Claude Opus 4.6 (1M context) --- crates/ml/src/hyperopt/adapters/dqn.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/crates/ml/src/hyperopt/adapters/dqn.rs b/crates/ml/src/hyperopt/adapters/dqn.rs index dee36b0ac..854cba65f 100644 --- a/crates/ml/src/hyperopt/adapters/dqn.rs +++ b/crates/ml/src/hyperopt/adapters/dqn.rs @@ -3775,11 +3775,12 @@ mod tests { assert_eq!(bounds[7], (0.5, 2.0)); // transaction_cost_multiplier assert_eq!(bounds[8], (0.4, 0.8)); // per_alpha assert_eq!(bounds[9], (0.2, 0.6)); // per_beta_start - assert_eq!(bounds[10], (10.0, 50.0)); // v_range (symmetric support, covers gamma 0.88-0.99) - assert_eq!(bounds[11], (1.0, 1.0)); // use_branching (FIXED: always true — GPU pipeline requires branching) - assert_eq!(bounds[13], (128.0, 512.0)); // dueling_hidden_dim - assert_eq!(bounds[14], (3.0, 5.0)); // n_steps (raised min: Rainbow standard) - assert_eq!(bounds[15], (11.0, 51.0)); // num_atoms (11=RTX3050, 51=H100 default) + // Default phase is Fast — architecture dims are fixed to [phase_fast] TOML values. + assert_eq!(bounds[10], (20.0, 20.0)); // v_range (FIXED in Fast phase) + assert_eq!(bounds[11], (1.0, 1.0)); // use_branching (FIXED: always true) + assert_eq!(bounds[13], (128.0, 128.0)); // dueling_hidden_dim (FIXED in Fast phase) + assert_eq!(bounds[14], (3.0, 5.0)); // n_steps (searchable in all phases) + assert_eq!(bounds[15], (11.0, 11.0)); // num_atoms (FIXED in Fast phase) // Kelly risk parameters assert_eq!(bounds[17], (0.25, 0.75)); // kelly_fractional @@ -3787,11 +3788,11 @@ mod tests { assert_eq!(bounds[19], (10.0, 30.0)); // volatility_window // C2: curiosity_weight fixed to 0.0, noisy_epsilon_floor fixed to 0.10, not in search space - assert_eq!(bounds[21], (128.0, 256.0)); // hidden_dim_base (capped at production default for hyperopt speed) + assert_eq!(bounds[21], (128.0, 128.0)); // hidden_dim_base (FIXED in Fast phase) assert_eq!(bounds[22], (0.0, 1.0)); // cql_alpha (full offline-RL range) // C5: branch_hidden_dim - assert_eq!(bounds[28], (64.0, 256.0)); // branch_hidden_dim (step=64) + assert_eq!(bounds[28], (64.0, 64.0)); // branch_hidden_dim (FIXED in Fast phase) // C6: gradient_accumulation_steps (fixed at 1 for default GPUs) assert_eq!(bounds[29], (1.0, 1.0)); // gradient_accumulation_steps }