From 0c5186cdaa5eac9e4b76ec1d55ee7a3f5905281b Mon Sep 17 00:00:00 2001
From: jgrusewski <jgrusewski@localhost>
Date: Mon, 20 Apr 2026 22:16:23 +0200
Subject: [PATCH] =?UTF-8?q?cleanup(fflag):=20delete=20dead=20enable=5Fnetw?=
 =?UTF-8?q?ork=5Fdiagnostics=20flag=20=E2=80=94=20[FFLAG-015]?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

LoggingConfig.enable_network_diagnostics was declared and defaulted but
never read anywhere (only test round-trip assertions existed). Deleted
field + Default init + two test assertions that validated the round-trip.
Zero production callers per rg.
---
 crates/ml-dqn/src/logging.rs | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/crates/ml-dqn/src/logging.rs b/crates/ml-dqn/src/logging.rs
index 81107f5a8..8465f2c03 100644
--- a/crates/ml-dqn/src/logging.rs
+++ b/crates/ml-dqn/src/logging.rs
@@ -31,8 +31,6 @@ pub struct LoggingConfig {
     pub gradient_log_interval: usize,
     /// Minimum duration between metric logs to prevent spam (default: 1s)
     pub min_log_interval: Duration,
-    /// Enable network diagnostics logging (default: false)
-    pub enable_network_diagnostics: bool,
 }
 
 impl Default for LoggingConfig {
@@ -43,7 +41,6 @@ impl Default for LoggingConfig {
             trace_forward_pass: false,
             gradient_log_interval: 500,
             min_log_interval: Duration::from_secs(1),
-            enable_network_diagnostics: false,
         }
     }
 }
@@ -332,7 +329,6 @@ mod tests {
         assert!(!config.trace_forward_pass);
         assert_eq!(config.gradient_log_interval, 500);
         assert_eq!(config.min_log_interval, Duration::from_secs(1));
-        assert!(!config.enable_network_diagnostics);
     }
 
     #[test]
@@ -343,14 +339,12 @@ mod tests {
             trace_forward_pass: true,
             gradient_log_interval: 100,
             min_log_interval: Duration::from_millis(500),
-            enable_network_diagnostics: true,
         };
         assert_eq!(config.batch_log_interval, 50);
         assert!(!config.log_epoch_summaries);
         assert!(config.trace_forward_pass);
         assert_eq!(config.gradient_log_interval, 100);
         assert_eq!(config.min_log_interval, Duration::from_millis(500));
-        assert!(config.enable_network_diagnostics);
     }
 
     // ========================================================================