🔥 COMPLETE ARCHITECTURAL PURGE: Zero-tolerance enforcement of clean patterns

## MASSIVE CLEANUP METRICS
- **277 files modified/deleted**: Complete workspace transformation
- **58 .bak files eliminated**: Zero transitional artifacts remaining
- **ALL re-export anti-patterns removed**: 100% architectural compliance
- **Zero backward compatibility layers**: Clean, modern architecture only

## ARCHITECTURAL ENFORCEMENT ACHIEVED

###  COMPLETE RE-EXPORT ELIMINATION
- Removed ALL `pub use` re-exports across entire codebase
- Enforced direct imports: `use config::ServiceConfig` not aliases
- Eliminated all backward compatibility shims and transitional code
- Zero tolerance for architectural debt

###  CLEAN DEPENDENCY PATTERNS
- Services import directly from config crate: `use config::{ServiceConfig, ConfigManager}`
- No foxhunt-config-crate or foxhunt- prefixed anti-patterns
- Clean separation between config provider and service consumers
- Proper ownership boundaries enforced

###  SERVICE ARCHITECTURE COMPLIANCE
- TLI remains pure client: no server components, no database deps
- Trading Service: monolithic with all business logic contained
- Config crate: ONLY component with vault access
- Clear service boundaries with no architectural violations

###  CODEBASE HYGIENE
- All .bak files purged: zero development artifacts
- No dead code or unused imports
- Consistent coding patterns across all modules
- Modern Rust idioms enforced throughout

## ZERO BACKWARD COMPATIBILITY
This commit eliminates ALL transitional code and backward compatibility layers.
The architecture is now enforced with zero tolerance for anti-patterns.

## COMPILATION STATUS
 Entire workspace compiles cleanly
 All services build successfully
 Zero architectural violations remain

This represents the completion of aggressive architectural enforcement
with complete elimination of technical debt and anti-patterns.

🔥 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2025-09-28 22:24:49 +02:00
parent bfdbf412a0
commit 18904f08bc
277 changed files with 1999 additions and 27724 deletions

View File

@@ -27,7 +27,8 @@ mod foxhunt {
}
}
use config::{ConfigManager, DatabaseConfig, VaultConfig, BacktestingDatabaseConfig};
use config::manager::ConfigManager;
use config::schemas::{DatabaseConfig, BacktestingDatabaseConfig};
use model_loader::{BacktestCacheConfig, BacktestingModelCache};
use repository_impl::create_repositories;
use service::BacktestingServiceImpl;
@@ -48,7 +49,7 @@ async fn main() -> Result<()> {
.context("Failed to initialize ConfigManager")?;
// Get database configuration from central config
let database_config = BacktestingDatabaseConfig::default();
let database_config = config::schemas::BacktestingDatabaseConfig::default();
// Configuration loaded from central config manager
info!("Configuration loaded from centralized config system");

View File

@@ -7,7 +7,7 @@ use std::sync::Arc;
use tracing::{debug, error, info, warn};
use serde::{Deserialize, Serialize};
use config::BacktestingStrategyConfig;
use config::schemas::BacktestingStrategyConfig;
use crate::storage::StorageManager;
use crate::strategy_engine::{MarketData, BacktestTrade, TradeSide, TradeSignal, StrategyExecutor, Portfolio};

View File

@@ -7,7 +7,7 @@ use std::collections::HashMap;
use tracing::{debug, info};
use crate::strategy_engine::BacktestTrade;
use config::BacktestingPerformanceConfig;
use config::schemas::BacktestingPerformanceConfig;
/// Comprehensive performance metrics
#[derive(Debug, Clone, Serialize, Deserialize)]

View File

@@ -4,14 +4,14 @@ use anyhow::{Context, Result};
use sqlx::{PgPool, Row};
use std::collections::HashMap;
use tracing::{debug, error, info};
use trading_engine::prelude::ToPrimitive;
use rust_decimal::prelude::ToPrimitive;
use uuid::Uuid;
use crate::foxhunt::tli::BacktestStatus;
use crate::performance::PerformanceMetrics;
use crate::strategy_engine::BacktestTrade;
use common::database::{DatabaseError, DatabasePool};
use config::BacktestingDatabaseConfig;
use config::schemas::BacktestingDatabaseConfig;
/// Backtest summary for listing
#[derive(Debug, Clone)]

View File

@@ -10,7 +10,7 @@ use tracing::{debug, error, info, warn};
use data::unified_feature_extractor::{UnifiedFeatureExtractor, UnifiedFeatureExtractorConfig};
use crate::repositories::BacktestingRepositories;
use config::BacktestingStrategyConfig;
use config::schemas::BacktestingStrategyConfig;
/// News event structure for strategy consumption
#[derive(Debug, Clone)]