From 39d18f582b41b318f07c971ae07de19eeadd5952 Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Mon, 20 Apr 2026 22:26:57 +0200 Subject: [PATCH] =?UTF-8?q?cleanup(fflag):=20delete=20dead=20use=5Fspectra?= =?UTF-8?q?l=5Fnorm=20in=20RainbowNetworkConfig=20=E2=80=94=20[FFLAG-002]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RainbowNetworkConfig.use_spectral_norm + spectral_norm_iterations were declared but never read anywhere in the workspace. Defaulted false, set false at the sole construction site. Pure write-only pair. Deleted both fields + 2 construction sites. Serde default (no deny_unknown_fields) keeps old JSON configs deserializable. --- crates/ml-dqn/src/rainbow_config.rs | 2 -- crates/ml-dqn/src/rainbow_network.rs | 4 ---- 2 files changed, 6 deletions(-) diff --git a/crates/ml-dqn/src/rainbow_config.rs b/crates/ml-dqn/src/rainbow_config.rs index e8ff2372e..a4d01fa1a 100644 --- a/crates/ml-dqn/src/rainbow_config.rs +++ b/crates/ml-dqn/src/rainbow_config.rs @@ -124,8 +124,6 @@ impl Default for RainbowDQNConfig { distributional: DistributionalConfig::default(), noisy_sigma_init: 0.5, dueling: true, - use_spectral_norm: false, - spectral_norm_iterations: 1, }, distributional: DistributionalConfig { num_atoms: 51, diff --git a/crates/ml-dqn/src/rainbow_network.rs b/crates/ml-dqn/src/rainbow_network.rs index 1a47fdf38..8b4bded5b 100644 --- a/crates/ml-dqn/src/rainbow_network.rs +++ b/crates/ml-dqn/src/rainbow_network.rs @@ -39,8 +39,6 @@ pub struct RainbowNetworkConfig { /// Initial noise std dev for noisy layers (Rainbow DQN default: 0.5, scaled by 1/sqrt(in)) pub noisy_sigma_init: f64, pub dueling: bool, - pub use_spectral_norm: bool, // Q-value stability feature - pub spectral_norm_iterations: usize, } impl Default for RainbowNetworkConfig { @@ -54,8 +52,6 @@ impl Default for RainbowNetworkConfig { distributional: DistributionalConfig::default(), noisy_sigma_init: 0.5, dueling: true, - use_spectral_norm: false, // Disabled by default, enable for unstable training - spectral_norm_iterations: 1, } } }