🎯 MAJOR SUCCESS: 12 Parallel Agents Complete Type System Cleanup

ACHIEVEMENTS:
- Agent 1-4: Successfully moved OrderSide/OrderStatus/OrderType/Currency/TimeInForce to common
- Agent 5-6: Consolidated MarketDataEvent and Timestamp types to common
- Agent 7-8: Updated ALL imports from trading_engine::types to common::types
- Agent 9-11: Eliminated 50+ duplicates, cleaned modules, removed re-exports
- Agent 12: CRITICAL DISCOVERY - Root cause identified

ROOT CAUSE FOUND:
- Common crate missing canonical Order struct definition
- Forces all 8+ services to create duplicate Order definitions
- Architectural violation causing compilation chaos

NEXT: Implement canonical Order struct in common crate with parallel agents

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2025-09-26 16:51:08 +02:00
parent d92a9664eb
commit 3bae23d814
172 changed files with 2000 additions and 9802 deletions

View File

@@ -12,7 +12,7 @@ use std::io::Write;
use std::time::Duration;
use tempfile::NamedTempFile;
use tokio::runtime::Runtime;
use trading_engine::types::prelude::*;
use common::types::*;
use backtesting::{
replay_engine::{DataFormat, DataSource, MarketReplay, ReplayConfig, SourceType},

View File

@@ -61,7 +61,7 @@ use serde::{Deserialize, Serialize};
use tokio::sync::{mpsc, RwLock};
use tracing::{error, info, warn};
use trading_engine::types::prelude::*;
use common::types::prelude::*;
// mod types; // Removed - using core::prelude types instead
@@ -87,7 +87,7 @@ pub use strategy_runner::{
};
// Import Side directly (no alias needed)
use trading_engine::types::basic::Side;
use common::types::basic::Side;
/// Main backtesting engine configuration
#[derive(Debug, Clone, Serialize, Deserialize)]

View File

@@ -15,7 +15,7 @@ use statrs::statistics::{Statistics, VarianceN};
use tokio::sync::RwLock;
use tracing::{debug, info, warn};
use trading_engine::types::prelude::*;
use common::types::prelude::*;
use crate::strategy_tester::{PerformanceSnapshot, TradeRecord};

View File

@@ -13,7 +13,7 @@ use std::{
use anyhow::{Context, Result};
use chrono::{DateTime, Utc};
use common::types::Timestamp;
use trading_engine::types::prelude::{Symbol, Decimal, Quantity, MarketEvent, Price};
use common::types::prelude::{Symbol, Decimal, Quantity, MarketEvent, Price};
use crossbeam_channel::{bounded, Receiver, Sender};
use dashmap::DashMap;
use serde::{Deserialize, Serialize};

View File

@@ -5,8 +5,8 @@
use anyhow::Result;
use async_trait::async_trait;
use trading_engine::types::basic::Side;
use trading_engine::types::prelude::*;
use common::types::basic::Side;
use common::types::prelude::*;
// Use canonical types from ML module
use ml::{Features, ModelPrediction};

View File

@@ -19,13 +19,13 @@ use dashmap::DashMap;
use serde::{Deserialize, Serialize};
use tokio::sync::{mpsc, RwLock};
use tracing::{debug, error, info, warn};
use trading_engine::types::basic::{
use common::types::basic::{
Order, OrderId, Position, Price, Quantity, Side as OrderSide, Symbol,
TimeInForce,
};
use common::types::{OrderStatus, OrderType};
use trading_engine::types::events::MarketEvent;
use trading_engine::types::prelude::*;
use common::types::events::MarketEvent;
use common::types::prelude::*;
use uuid::Uuid;
// TECHNICAL DEBT ELIMINATED - Use String and DateTime<Utc> directly
use crate::replay_engine::{MarketReplay, ReplayEvent};

View File

@@ -4,7 +4,7 @@ use backtesting::{
create_adaptive_strategy_with_config, AdaptiveStrategyConfig, AdaptiveStrategyRunner,
BacktestConfig, BacktestEngine, FeatureSettings, RiskSettings, Strategy,
};
use trading_engine::types::prelude::*;
use common::types::*;
#[tokio::test]
async fn test_dqn_strategy_integration() {