From 52100ae7a1b5fad701def3b06261ff6472ab1976 Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Sat, 9 May 2026 00:43:02 +0200 Subject: [PATCH] =?UTF-8?q?docs(sp18=20v2):=20PP.5=20H100=20collection-tim?= =?UTF-8?q?e=20profiling=20=E2=80=94=20deferred-to-Phase-4=20marker?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PP.5 is the B-DD6 headroom-check: profile current gpu_experience_collector::collect_experience end-to-end ms/cycle on H100 to confirm budget for the new target-net forward pass (B-leg Phase 4 estimated ~30% slowdown). Plan explicitly marks this as reviewer-only ("subagent CANNOT run this step (reviewer-only). Hands off to reviewer at PP.5."). Pre-Phase subagent dispatch context lacks H100/Argo deploy access, so the actual nsys profile is deferred to Phase 4 reviewer pickup. NO production code modified — this is observability infrastructure for the Phase 4 atomic refactor's regression check. Pre-Phase exit criteria still satisfied (22 ISV slots locked, registry entries with dispatch arms, retirement markers, audit doc current); only the H100 measurement is deferred per the plan's reviewer-only gating. Phase 4 pickup instructions documented in audit doc (4-step procedure: push → argo-train profile → read nsys → fallback rules + human-review gate). Plan: docs/superpowers/plans/2026-05-08-sp18-reward-shape-hold-attractor.md Co-Authored-By: Claude Opus 4.7 (1M context) --- docs/dqn-wire-up-audit.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/docs/dqn-wire-up-audit.md b/docs/dqn-wire-up-audit.md index 3dd0a1f5a..043829d1f 100644 --- a/docs/dqn-wire-up-audit.md +++ b/docs/dqn-wire-up-audit.md @@ -2,6 +2,29 @@ **Status:** Populated during Plan 1 Task 6 (A.5 orphan audit). Updated on every commit per Invariant 7. +## 2026-05-08 — SP18 v2 Pre-Phase Task PP.5: H100 collection-time profiling baseline (DEFERRED-TO-PHASE-4 MARKER) + +PP.5 is the B-DD6 headroom-check task: profile current `gpu_experience_collector::collect_experience` end-to-end ms/cycle on H100 to confirm the new target-net forward pass (B-leg Phase 4) has the budget for an estimated ~30% slowdown. The plan explicitly marks this as **reviewer-only** ("Reviewer-run profiling … `./scripts/argo-train.sh --model dqn --epochs 1 --label sp18-pp5-profile --profile nsys`"). It does NOT modify production code — it just produces a baseline measurement for Phase 4 to validate against. + +**Status: deferred-to-Phase-4 marker.** The Pre-Phase subagent dispatch context does not have H100/Argo deploy access, and the plan's design note at PP.5 explicitly states `subagent CANNOT run this step (reviewer-only). Hands off to reviewer at PP.5.` No production code is modified; this section just records the deferral so Phase 4 has clear pickup instructions. + +**What Phase 4 needs to do before merging the new target-net forward pass:** + +1. From `feat/sp18-combined`, `git push -u origin feat/sp18-combined` (per `feedback_push_before_deploy`). +2. Dispatch the profiling run: `./scripts/argo-train.sh --model dqn --epochs 1 --label sp18-pp5-profile --profile nsys`. +3. Read the nsys profile for `gpu_experience_collector::collect_experience` end-to-end ms/cycle. +4. Compare against the per-step training budget: + - If headroom ≥ 30%: proceed with B-leg Phase 4 atomic refactor as specified. + - If headroom < 30% but ≥ 0%: fall back to B-DD8.a scalar-only target-Q (already the recommendation — distributional flavour deferred). + - If headroom < 0%: HALT and convene human review before any Phase 4 commit. +5. Append the actual measurement (ms/cycle pre-Phase-4 + budget headroom) to this section so the regression check at Phase 4 close-out has a concrete anchor. + +**Why the profile is gating** (per spec § B-DD6): Adding a target-net forward pass on `next_states` at experience-collection time is a known cost. The plan accepts the slowdown if the baseline shows headroom, and falls back to scalar-only if not. Without the baseline, the post-fix performance regression check has nothing to compare against. + +**Atomicity envelope**: No production code modified — this is observability infrastructure for Phase 4. The Pre-Phase final state still satisfies the SP18 v2 Pre-Phase exit criteria (22 ISV slots locked, registry entries with dispatch arms, retirement markers in place, audit doc current) — only the H100 measurement is deferred. + +**Plan**: `docs/superpowers/plans/2026-05-08-sp18-reward-shape-hold-attractor.md` § Pre-Phase Task PP.5. + ## 2026-05-08 — SP18 v2 Pre-Phase Task PP.4: SP16 P2/T3 retirement marker Pre-Phase scaffolding marking the SP16 P2/T3 HOLD_COST_SCALE chain as RETIRED per DD7=c. The SP18 D-leg structural Hold opportunity-cost reward (compute_sp18_hold_opportunity_cost in trade_physics.cuh + ISV[483..493) cap producer chain) replaces the SP13 P0a + SP16 P2 + SP16 T3 reactive per-bar Hold-cost chain. The retirement is **slot-level only** at this stage — Phase 1 of SP18 deletes the producer kernel + 3 consumer sites + host controller atomically per `feedback_no_partial_refactor`.