From 8919eccbb9d269faa77b6b7a593d545b6d0a8d8d Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Fri, 10 Apr 2026 20:05:58 +0200 Subject: [PATCH] cleanup: remove --bf16 flag from precompute scripts and Argo template Binary no longer accepts --bf16 (single f32 format). Removed from: - scripts/argo-precompute.sh - infra/k8s/argo/precompute-features-template.yaml PVC fxcache cleaned: deleted 2.4GB old bf16 cache from feature-cache-pvc. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../k8s/argo/precompute-features-template.yaml | 18 +++--------------- scripts/argo-precompute.sh | 6 ------ 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/infra/k8s/argo/precompute-features-template.yaml b/infra/k8s/argo/precompute-features-template.yaml index d7c61a53e..b225d32bb 100644 --- a/infra/k8s/argo/precompute-features-template.yaml +++ b/infra/k8s/argo/precompute-features-template.yaml @@ -1,4 +1,4 @@ -# Pre-compute DQN training features to .fxcache format. +# Pre-compute DQN training features to .fxcache format (f32). # # Runs after data downloads complete. Reads DBN files from training-data PVC, # extracts all features (OHLCV 42-dim + targets 4-dim + OFI 8-dim), writes @@ -6,7 +6,7 @@ # # Usage: # argo submit -n foxhunt --from=wftmpl/precompute-features -# ./scripts/argo-precompute.sh ES.FUT --bf16 +# ./scripts/argo-precompute.sh ES.FUT --- apiVersion: argoproj.io/v1alpha1 kind: WorkflowTemplate @@ -43,8 +43,6 @@ spec: value: /feature-cache - name: node-pool value: ci-compile-cpu - - name: bf16 - value: "false" volumes: - name: training-data @@ -64,7 +62,6 @@ spec: - name: trades-dir - name: output-dir - name: node-pool - - name: bf16 nodeSelector: k8s.scaleway.com/pool-name: "{{inputs.parameters.node-pool}}" container: @@ -97,25 +94,17 @@ spec: fi SYMBOL="{{inputs.parameters.symbol}}" - # --symbol flag filters to the correct subdirectory (collect_dbn_files_filtered) DATA_DIR="{{inputs.parameters.data-dir}}" MBP10_DIR="{{inputs.parameters.mbp10-dir}}" TRADES_DIR="{{inputs.parameters.trades-dir}}" OUTPUT_DIR="{{inputs.parameters.output-dir}}" - BF16="{{inputs.parameters.bf16}}" - BF16_FLAG="" - if [ "$BF16" = "true" ]; then - BF16_FLAG="--bf16" - fi - - echo "=== Feature Pre-Compute ===" + echo "=== Feature Pre-Compute (f32) ===" echo "Symbol: $SYMBOL" echo "OHLCV: $DATA_DIR" echo "MBP-10: $MBP10_DIR" echo "Trades: $TRADES_DIR" echo "Output: $OUTPUT_DIR" - echo "BF16: $BF16" echo "Node: $(hostname), CPUs: $(nproc), RAM: $(free -g | awk '/Mem:/{print $2}')G" echo "" @@ -125,7 +114,6 @@ spec: --trades-data-dir "$TRADES_DIR" \ --output-dir "$OUTPUT_DIR" \ --symbol "$SYMBOL" \ - $BF16_FLAG \ --yes echo "" diff --git a/scripts/argo-precompute.sh b/scripts/argo-precompute.sh index 82bf4dcf0..852a1276a 100755 --- a/scripts/argo-precompute.sh +++ b/scripts/argo-precompute.sh @@ -3,7 +3,6 @@ # # Usage: # ./scripts/argo-precompute.sh ES.FUT -# ./scripts/argo-precompute.sh ES.FUT --bf16 # ./scripts/argo-precompute.sh ES.FUT --pool platform --watch # # Requires: argo CLI @@ -11,7 +10,6 @@ set -euo pipefail TEMPLATE="precompute-features" POOL="" -BF16="" DATA_DIR="" MBP10_DIR="" TRADES_DIR="" @@ -23,7 +21,6 @@ usage() { Usage: $(basename "$0") [OPTIONS] Options: - --bf16 Write bf16 format (version 2) --pool Node pool (default: ci-compile-cpu) --data-dir OHLCV data dir (default: /data/futures-baseline) --mbp10-dir MBP-10 data dir (default: /data/futures-baseline-mbp10) @@ -42,7 +39,6 @@ SYMBOL="$1"; shift while [[ $# -gt 0 ]]; do case $1 in - --bf16) BF16="true"; shift ;; --pool) POOL="$2"; shift 2 ;; --data-dir) DATA_DIR="$2"; shift 2 ;; --mbp10-dir) MBP10_DIR="$2"; shift 2 ;; @@ -57,7 +53,6 @@ done CMD="argo submit -n foxhunt --from=wftmpl/$TEMPLATE" CMD="$CMD -p symbol=$SYMBOL" -[[ -n "$BF16" ]] && CMD="$CMD -p bf16=$BF16" [[ -n "$POOL" ]] && CMD="$CMD -p node-pool=$POOL" [[ -n "$DATA_DIR" ]] && CMD="$CMD -p data-dir=$DATA_DIR" [[ -n "$MBP10_DIR" ]] && CMD="$CMD -p mbp10-dir=$MBP10_DIR" @@ -70,7 +65,6 @@ fi echo "Submitting feature pre-compute workflow..." echo " symbol: $SYMBOL" -[[ -n "$BF16" ]] && echo " bf16: $BF16" [[ -n "$POOL" ]] && echo " pool: $POOL" echo "" eval "$CMD"