From 98c3ffa4dfa4c6feec0a72157e08fd46f49bbe3f Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Sun, 22 Feb 2026 21:36:54 +0100 Subject: [PATCH] refactor(common): remove confusing aliased re-exports Remove unused aliased re-exports from common/src/lib.rs: - BarEventFromMarketData, MarketDataEventFromMarketData, OrderBookEventFromMarketData, QuoteEventFromMarketData, TradeEventFromMarketData (all unused, conflicted with types:: exports) - ResilienceCircuitBreaker (unused alias for resilience::CircuitBreaker struct, conflicted with traits::CircuitBreaker trait) - Also removes BarInterval and NewsEvent root re-exports (unused from root, accessible via common::market_data::*) Users should import market_data types via common::market_data::* and the resilience CircuitBreaker struct via common::resilience::CircuitBreaker. Co-Authored-By: Claude Opus 4.6 --- common/src/lib.rs | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/common/src/lib.rs b/common/src/lib.rs index 8e75b291b..357defbec 100644 --- a/common/src/lib.rs +++ b/common/src/lib.rs @@ -66,15 +66,8 @@ pub use traits::{ Metrics, RateLimitStatus, RateLimited, Reloadable, Service, }; -pub use market_data::{ - BarEvent as BarEventFromMarketData, BarInterval, - MarketDataEvent as MarketDataEventFromMarketData, NewsEvent, - OrderBookEvent as OrderBookEventFromMarketData, QuoteEvent as QuoteEventFromMarketData, - TradeEvent as TradeEventFromMarketData, -}; - -// Import market data types for canonical use -// Use common::market_data::{MarketDataEvent, TradeEvent, QuoteEvent, BarEvent} etc. +// Market data types: use common::market_data::{MarketDataEvent, TradeEvent, QuoteEvent, BarEvent, etc.} +// (Not re-exported at crate root to avoid name collisions with types:: re-exports) pub mod trading; // Re-export shared ML strategy types @@ -98,7 +91,6 @@ pub use features::{ pub use resilience::{ BoundedExecutor, BoundedExecutorError, - CircuitBreaker as ResilienceCircuitBreaker, CircuitBreakerConfig, CircuitBreakerState, retry_with_backoff,