From a4e9a80d6d91982211468b2125c122fb91e0eb3d Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Wed, 11 Mar 2026 16:12:14 +0100 Subject: [PATCH] fix(test): update mamba2 argmin tests for 14-param space (signal thresholds) Continuous vectors and expected counts updated from 12 to 14 params after adding signal_high_bps and signal_low_bps to Mamba2Params. Co-Authored-By: Claude Opus 4.6 --- crates/ml/src/hyperopt/tests_argmin.rs | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/crates/ml/src/hyperopt/tests_argmin.rs b/crates/ml/src/hyperopt/tests_argmin.rs index 6a20e6847..aa32ed613 100644 --- a/crates/ml/src/hyperopt/tests_argmin.rs +++ b/crates/ml/src/hyperopt/tests_argmin.rs @@ -312,7 +312,7 @@ mod tests { use crate::hyperopt::adapters::mamba2::Mamba2Params; let bounds = Mamba2Params::continuous_bounds(); - assert_eq!(bounds.len(), 12); // 12 parameters (total_decay_steps removed) + assert_eq!(bounds.len(), 14); // 12 base + signal_high_bps + signal_low_bps // Learning rate (log scale) assert!(bounds[0].0 < bounds[0].1); @@ -344,7 +344,7 @@ mod tests { assert!(result .unwrap_err() .to_string() - .contains("Expected 12 parameters")); + .contains("Expected 14 parameters")); } #[test] @@ -352,7 +352,7 @@ mod tests { use crate::hyperopt::adapters::mamba2::Mamba2Params; let names = Mamba2Params::param_names(); - assert_eq!(names.len(), 12); // 12 parameters (total_decay_steps removed) + assert_eq!(names.len(), 14); // 12 base + signal_high_bps + signal_low_bps assert_eq!(names[0], "learning_rate"); assert_eq!(names[1], "batch_size"); assert_eq!(names[2], "dropout"); @@ -365,6 +365,8 @@ mod tests { assert_eq!(names[9], "lookback_window"); assert_eq!(names[10], "sequence_stride"); assert_eq!(names[11], "norm_eps"); + assert_eq!(names[12], "signal_high_bps"); + assert_eq!(names[13], "signal_low_bps"); } #[test] @@ -385,6 +387,8 @@ mod tests { 60.0, // lookback_window 1.0, // sequence_stride -11.5, // norm_eps (log scale) + 10.0, // signal_high_bps + 5.0, // signal_low_bps ]; let params = Mamba2Params::from_continuous(&continuous).unwrap(); @@ -409,6 +413,8 @@ mod tests { 60.0, // lookback_window 1.0, // sequence_stride -11.5, // norm_eps (log scale) + 10.0, // signal_high_bps + 5.0, // signal_low_bps ]; let params = Mamba2Params::from_continuous(&continuous).unwrap(); @@ -427,6 +433,8 @@ mod tests { 60.0, // lookback_window 1.0, // sequence_stride -11.5, // norm_eps (log scale) + 10.0, // signal_high_bps + 5.0, // signal_low_bps ]; let params2 = Mamba2Params::from_continuous(&continuous2).unwrap();