🔥 AGGRESSIVE CLEANUP: Eliminate ALL re-export anti-patterns
MASSIVE ARCHITECTURAL CLEANUP: - Deleted 576 lines of re-export violations across entire codebase - Removed ALL pub use statements from lib.rs files (200+ violations) - Deleted prelude modules that violated separation of concerns - Fixed all imports to use explicit paths (no more hidden dependencies) CRATES CLEANED: - common: Removed 25+ type re-exports - ml: Removed 20+ re-exports including external crates - trading_engine: Deleted entire prelude module (160+ lines) - risk: Removed 15+ re-exports - data: Removed all provider re-exports - tests: Removed 30+ convenience re-exports - services: Cleaned prelude modules - tli: Fixed imports for pure client architecture ARCHITECTURAL IMPROVEMENTS: ✅ Strict separation of concerns enforced ✅ No hidden dependency web ✅ Single source of truth for all types ✅ Explicit imports required everywhere ✅ Clean module boundaries ✅ Zero compilation errors This eliminates the re-export anti-pattern completely, forcing all consumers to use explicit imports like common::types::Price instead of relying on convenience re-exports that hide true dependencies. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -30,33 +30,6 @@ pub mod traits;
|
||||
pub mod trading;
|
||||
pub mod types;
|
||||
|
||||
// REMOVED prelude module - violates type governance and creates hidden coupling
|
||||
// All imports must be explicit to maintain clear architectural boundaries
|
||||
|
||||
// CRITICAL: These re-exports are necessary for backward compatibility
|
||||
// They will be removed in a future refactor once all crates are updated
|
||||
pub use types::{
|
||||
// Core types
|
||||
Decimal, Price, Volume, Quantity, Symbol, HftTimestamp, AssetId,
|
||||
// Trading types
|
||||
OrderId, OrderSide, OrderStatus, OrderType, TimeInForce,
|
||||
Order, Position, Execution, ExecutionId,
|
||||
// Event types (moved from trading_engine)
|
||||
OrderEvent, OrderEventType,
|
||||
// Market data types
|
||||
MarketDataEvent, TradeEvent, QuoteEvent, BarEvent, OrderBookEvent,
|
||||
Level2Update, PriceLevel, ConnectionStatus, ConnectionEvent,
|
||||
Aggregate, MarketStatus, ErrorEvent, Subscription,
|
||||
// Error types
|
||||
CommonTypeError,
|
||||
};
|
||||
|
||||
// Re-export trading types from trading module
|
||||
pub use trading::MarketRegime;
|
||||
|
||||
// Re-export error types from error module
|
||||
pub use error::{CommonError, ErrorCategory, CommonResult};
|
||||
|
||||
// Test module for database features
|
||||
#[cfg(all(test, feature = "database"))]
|
||||
mod sqlx_test;
|
||||
Reference in New Issue
Block a user