From bf9a7399085bbed2f03e1a8f56d5e70bac65d644 Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Thu, 12 Mar 2026 08:46:17 +0100 Subject: [PATCH] fix(ml): suppress unsafe-code warning on startup env::set_var calls CUBLAS_WORKSPACE_CONFIG and NVIDIA_TF32_OVERRIDE are set once at startup before any threads or CUDA work begins. The unsafe block is correct but triggers -W unsafe-code. Adding #[allow(unsafe_code)] at the call site silences the warning while keeping the safety comment. Co-Authored-By: Claude Opus 4.6 --- crates/ml/examples/hyperopt_baseline_rl.rs | 1 + crates/ml/examples/train_baseline_rl.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/crates/ml/examples/hyperopt_baseline_rl.rs b/crates/ml/examples/hyperopt_baseline_rl.rs index 39056b7c8..a73ba6091 100644 --- a/crates/ml/examples/hyperopt_baseline_rl.rs +++ b/crates/ml/examples/hyperopt_baseline_rl.rs @@ -413,6 +413,7 @@ fn main() -> Result<()> { // Pre-allocate CUBLAS workspace for deterministic + faster tensor core ops. // Enable TF32 for all FP32 matmuls — ~8x throughput on H100 tensor cores. // SAFETY: called once at startup before any multi-threading or CUDA work begins. + #[allow(unsafe_code)] unsafe { std::env::set_var("CUBLAS_WORKSPACE_CONFIG", ":4096:8"); std::env::set_var("NVIDIA_TF32_OVERRIDE", "1"); diff --git a/crates/ml/examples/train_baseline_rl.rs b/crates/ml/examples/train_baseline_rl.rs index c5b22bd38..d1275bfaf 100644 --- a/crates/ml/examples/train_baseline_rl.rs +++ b/crates/ml/examples/train_baseline_rl.rs @@ -1042,6 +1042,7 @@ fn main() -> Result<()> { // Pre-allocate CUBLAS workspace for deterministic + faster tensor core ops. // Enable TF32 for all FP32 matmuls — ~8x throughput on H100 tensor cores. // SAFETY: called once at startup before any multi-threading or CUDA work begins. + #[allow(unsafe_code)] unsafe { std::env::set_var("CUBLAS_WORKSPACE_CONFIG", ":4096:8"); std::env::set_var("NVIDIA_TF32_OVERRIDE", "1");