From c9191e7c58e34aa255f3cccc4f955a22cf87dffd Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Sun, 5 Apr 2026 13:40:12 +0200 Subject: [PATCH] chore: remove unused NaN diagnostic accessor methods MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes cql_grad_scratch_ptr, iqn_trunk_m_ptr, save_h_s1_ptr, stream_cu — added during NaN investigation, no longer called. Retains run_nan_tracing (lightweight GPU-side checks on first 20 steps) and all isfinite guards as production safety nets. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../ml/src/cuda_pipeline/gpu_dqn_trainer.rs | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/crates/ml/src/cuda_pipeline/gpu_dqn_trainer.rs b/crates/ml/src/cuda_pipeline/gpu_dqn_trainer.rs index add9b25b1..7af63269f 100644 --- a/crates/ml/src/cuda_pipeline/gpu_dqn_trainer.rs +++ b/crates/ml/src/cuda_pipeline/gpu_dqn_trainer.rs @@ -1026,26 +1026,6 @@ impl GpuDqnTrainer { self.params_buf.raw_ptr() } - /// Raw pointer to CQL gradient scratch buffer (for NaN diagnostics). - pub fn cql_grad_scratch_ptr(&self) -> u64 { - self.cql_grad_scratch.raw_ptr() - } - - /// Raw pointer to IQN trunk gradient scratch (for NaN diagnostics). - pub fn iqn_trunk_m_ptr(&self) -> u64 { - self.ptrs.iqn_trunk_m - } - - /// Raw pointer to saved h_s1 activations (for NaN diagnostics). - pub fn save_h_s1_ptr(&self) -> u64 { - self.save_h_s1.raw_ptr() - } - - /// Raw CUDA stream handle (for synchronous diagnostics). - pub fn stream_cu(&self) -> cudarc::driver::sys::CUstream { - self.stream.cu_stream() - } - /// Total number of trainable parameters. pub fn total_params(&self) -> usize { self.total_params