From e6e31305a29b667d9ccbf79d71d1cc651204c280 Mon Sep 17 00:00:00 2001 From: jgrusewski Date: Tue, 10 Mar 2026 10:33:18 +0100 Subject: [PATCH] fix(ml-dqn): suppress unused grad_norm_tensor warning without cuda Prefix with underscore since it's only consumed in #[cfg(feature = "cuda")] block. Co-Authored-By: Claude Opus 4.6 --- crates/ml-dqn/src/dqn.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/ml-dqn/src/dqn.rs b/crates/ml-dqn/src/dqn.rs index ac2be9068..1d30f9bda 100644 --- a/crates/ml-dqn/src/dqn.rs +++ b/crates/ml-dqn/src/dqn.rs @@ -3348,7 +3348,7 @@ impl DQN { let result = self.compute_loss_internal(batch)?; // Backward + clip WITHOUT optimizer step — zero GPU→CPU sync - let (grads, grad_norm_tensor) = if let Some(ref optimizer) = self.optimizer { + let (grads, _grad_norm_tensor) = if let Some(ref optimizer) = self.optimizer { optimizer.backward_and_clip(&result.loss_tensor, self.gradient_clip_norm)? } else { return Err(MLError::TrainingError( @@ -3358,10 +3358,10 @@ impl DQN { // Squeeze grad_norm from [1] → rank-0 scalar tensor (GPU path only) #[cfg(feature = "cuda")] - let grad_norm_scalar_tensor = if grad_norm_tensor.dims().len() > 0 { - grad_norm_tensor.squeeze(0)? + let grad_norm_scalar_tensor = if _grad_norm_tensor.dims().len() > 0 { + _grad_norm_tensor.squeeze(0)? } else { - grad_norm_tensor + _grad_norm_tensor }; Ok(GradientResult {