jgrusewski
d06c99b0e1
fix(clippy): achieve zero warnings across entire workspace
...
- Fix format_push_string: write!() instead of push_str(&format!()) (25 sites)
- Fix str_to_string: .to_owned() instead of .to_string() on &str (6 sites)
- Fix unseparated_literal_suffix: add _ separator (6 sites)
- Fix multiple_inherent_impl: merge split impl blocks in TGGN, TFT, OFI (3)
- Fix else_if_without_else: add exhaustive else clauses (3 sites)
- Fix if_then_some_else_none: use .then().transpose() (1 site)
- Fix unwrap_in_result: replace expect() with match + ? (2 sites)
- Fix wildcard_enum_match_arm: enumerate Storage variants explicitly (2)
- Fix decimal_literal_representation: use hex for power-of-2 constants (5)
- Fix rc_buffer: Arc<Vec<T>> → Arc<[T]> for OFI features
- Fix needless_range_loop: convert to iterator patterns (17 sites)
- Fix used_underscore_binding: remove prefix on used vars (6 sites)
- Fix doc list item indentation (7 sites)
- Allow too_many_arguments on ML training functions (4)
- Allow multiple_unsafe_ops_per_block on CUDA FFI functions (3)
- Allow upper_case_acronyms on SLSTM/MLSTM model names (2)
- Add ML-crate pedantic allows: shadow, similar_names, type_complexity,
indexing_slicing, partial_pub_fields, non_ascii_literal, same_name_method
(following existing ml-labeling/ml-universe pattern)
Result: cargo clippy --workspace -- -D warnings passes with zero warnings.
All 2758+ lib tests pass (2 pre-existing backtesting failures unchanged).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 13:18:57 +01:00
jgrusewski
ccf9e22a55
fix(clippy): resolve misc warnings across ML crates
...
- Implement Display trait instead of inherent to_string() (versioning.rs)
- Replace iter().nth() with .get(), .get(0) with .first()
- Collapse else-if chains, derive Default for enums
- Fix deref warnings, redundant let bindings, push_str('\n')
- Convert match-to-if-let, use saturating_sub, RangeInclusive::contains
- Replace vec![push;push] with vec![...] literal (feature_extraction.rs)
- Remove redundant redefinitions, unnecessary parentheses, casts
- Fix &Vec<_> to &[_] in function parameters
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 12:12:14 +01:00
jgrusewski
fca2495a73
fix(clippy): add doc backticks and const fn across ML crates
...
- Add backticks to type names in doc comments (doc_markdown)
- Mark eligible functions as const fn (missing_const_for_fn)
No behavior changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 11:51:31 +01:00
jgrusewski
278fd3673f
fix(clippy): allow module_name_repetitions and integer_division in ML crates
...
module_name_repetitions: PpoConfig in ppo module is conventional ML naming.
Renaming breaks every import across the workspace.
integer_division: Basis point calculations, batch size math, combinatorial
formulas — truncation is intentional. Float conversion would introduce bugs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 11:27:01 +01:00
jgrusewski
7ef92983f9
fix(clippy): apply cargo clippy --fix across workspace
...
Mechanical auto-fixes: redundant borrows, clone on Copy, or_insert_with,
single-char push_str, get(0) → first(), needless borrow, let_and_return.
150 files, no behavior changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-10 11:17:51 +01:00
jgrusewski
4676fe79e2
refactor(ml): extract observability, stress-testing, security into sub-crates
...
- ml-observability (1.2K lines): alerts, dashboards, metrics modules.
Depends on ml-core + common (ModelType). 4 tests passing.
- ml-stress-testing (1.3K lines): load_generator, market_simulator,
performance_analyzer modules. Depends on ml-core + common + config.
5 tests passing.
- ml-security (1.4K lines): anomaly_detector, prediction_validator
modules. Depends on ml-core + ml-ensemble (EnsembleDecision,
ModelVote, TradingAction). 17 tests passing.
Total: 18 sub-crates extracted from ml monolith.
Workspace: 0 errors, ml tests 876 + 26 in new sub-crates.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-08 15:17:22 +01:00
