- ml/tests/dqn_training_pipeline_test.rs: the inline TODO speculated
about a future `load_checkpoint` hook; loader round-trip coverage
already lives in dqn_checkpoint_tests. Reword to point there.
- ml/tests/ppo_lstm_training_loop_tests.rs: the assertion on
`hidden_state_manager.is_some()` is the public-surface proxy for
"LSTM path active"; deeper introspection isn't exposed. Say so.
- ml/tests/ppo_recurrent_integration_tests.rs: the test is already
`#[ignore]`d; rewrite the inline TODO as a description of the
missing `from_varbuilder` constructors on LSTMPolicyNetwork /
LSTMValueNetwork.
- risk/risk_engine.rs: VarEngine receives a default asset-class
config because the schema-to-config conversion is not wired.
Reword the TODO to describe that plainly.
- trading_engine/types/errors.rs: `common::ConversionError` does
not exist; keep ConversionError local and drop the aspirational
re-export comment.
- trading_engine/tests/audit_persistence_tests.rs: describe why
the query assertion only checks the Ok shape (row-to-event
mapping not wired) rather than pointing at a nonexistent line
number.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Remove entire trading_engine/src/compliance/ directory (9 files, 16,068 LOC)
and 18 associated test files (18,069 LOC). Comprehensive audit confirmed
zero external callers for all types (ISO 27001, SOX, MiFID II, best
execution, automated reporting). Remove unused cron dependency.
Independent compliance modules in risk/ and risk-data/ are preserved.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace all `.to_string().parse::<f32/f64>()` patterns with
`num_traits::ToPrimitive` methods (`.to_f32()`, `.to_f64()`).
Each string roundtrip heap-allocated per conversion — fatal in
DQN hot loop (300K+ bars × epochs). Decimal stays as canonical
financial type; conversions happen at GPU/float boundaries only.
Also fixes blocking_read() in async context (risk_integration.rs).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move 17 library crates into crates/, CLI binary into bin/fxt,
consolidate 10 test crates into testing/, split config crate
from deployment config files.
Root directory reduced from 38+ to ~17 directories.
All Cargo.toml paths and build.rs proto refs updated.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
