foxhunt

gitadmin/foxhunt

Fork 0

Commit Graph

Author	SHA1	Message	Date
jgrusewski	a6b6f27cdd	refactor(ml): Remove default hyperparameters and add canonical configs - Remove Default trait implementations from DQN and PPO trainers - Add conservative() methods for testing/examples - Create canonical hyperparameter config files in ml/hyperparams/ - Update all examples and tests to use conservative() This prevents production failures from incorrect defaults (e.g., Pod 0hczpx9nj1ub88 failure where default LR was 1000x too high for PPO). Changes: - ml/src/trainers/dqn.rs: Remove Default, add conservative() + monitoring - ml/src/trainers/ppo.rs: Remove Default, add conservative() + dual LRs - ml/hyperparams/ppo_best.toml: Best params from hyperopt Trial #1 - ml/hyperparams/dqn_best.toml: Conservative DQN defaults - ml/hyperparams/README.md: Usage documentation - Updated 5 examples to use conservative() - Updated 7 test files (69 occurrences) Test Results: 24/24 trainer tests passing (15 DQN + 9 PPO) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-11-02 11:12:14 +01:00
jgrusewski	845e77a8b0	fix(ci): Fix GitLab CI YAML syntax and PPOConfig compilation errors Two critical fixes for successful pipeline execution: 1. GitLab CI YAML Syntax Fix (.gitlab-ci.yml:84-86) - Wrapped echo commands containing colons in single quotes - Root cause: YAML parser interprets `"text: value"` as key-value pairs - Solution: Single quotes force literal string interpretation - Impact: Enables Docker build pipeline execution 2. Trading Service Compilation Fix (trading_service/src/services/enhanced_ml.rs:1328-1348) - Added missing early stopping fields to PPOConfig initialization - Fields: early_stopping_enabled, early_stopping_patience, early_stopping_min_delta, early_stopping_min_epochs - Values: Disabled by default for paper trading (early_stopping_enabled: false) - Impact: Resolves pre-push hook compilation error Technical Details: - YAML Issue: Colons followed by spaces trigger mapping syntax parsing - Single quotes preserve shell variable expansion while forcing literal YAML strings - Early stopping config matches PPOConfig struct updates from Wave D - Default values: patience=5, min_delta=0.001, min_epochs=10 Validated: - ✅ YAML syntax validated with PyYAML - ✅ trading_service compilation successful (cargo check) - ✅ Ready for GitLab CI/CD pipeline execution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-10-31 00:20:00 +01:00

Author

SHA1

Message

Date

jgrusewski

a6b6f27cdd

refactor(ml): Remove default hyperparameters and add canonical configs

- Remove Default trait implementations from DQN and PPO trainers
- Add conservative() methods for testing/examples
- Create canonical hyperparameter config files in ml/hyperparams/
- Update all examples and tests to use conservative()

This prevents production failures from incorrect defaults (e.g., Pod
0hczpx9nj1ub88 failure where default LR was 1000x too high for PPO).

Changes:
- ml/src/trainers/dqn.rs: Remove Default, add conservative() + monitoring
- ml/src/trainers/ppo.rs: Remove Default, add conservative() + dual LRs
- ml/hyperparams/ppo_best.toml: Best params from hyperopt Trial #1
- ml/hyperparams/dqn_best.toml: Conservative DQN defaults
- ml/hyperparams/README.md: Usage documentation
- Updated 5 examples to use conservative()
- Updated 7 test files (69 occurrences)

Test Results: 24/24 trainer tests passing (15 DQN + 9 PPO)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-11-02 11:12:14 +01:00

jgrusewski

845e77a8b0

fix(ci): Fix GitLab CI YAML syntax and PPOConfig compilation errors

Two critical fixes for successful pipeline execution:

1. GitLab CI YAML Syntax Fix (.gitlab-ci.yml:84-86)
   - Wrapped echo commands containing colons in single quotes
   - Root cause: YAML parser interprets `"text: value"` as key-value pairs
   - Solution: Single quotes force literal string interpretation
   - Impact: Enables Docker build pipeline execution

2. Trading Service Compilation Fix (trading_service/src/services/enhanced_ml.rs:1328-1348)
   - Added missing early stopping fields to PPOConfig initialization
   - Fields: early_stopping_enabled, early_stopping_patience, early_stopping_min_delta, early_stopping_min_epochs
   - Values: Disabled by default for paper trading (early_stopping_enabled: false)
   - Impact: Resolves pre-push hook compilation error

Technical Details:
- YAML Issue: Colons followed by spaces trigger mapping syntax parsing
- Single quotes preserve shell variable expansion while forcing literal YAML strings
- Early stopping config matches PPOConfig struct updates from Wave D
- Default values: patience=5, min_delta=0.001, min_epochs=10

Validated:
- ✅ YAML syntax validated with PyYAML
- ✅ trading_service compilation successful (cargo check)
- ✅ Ready for GitLab CI/CD pipeline execution

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-10-31 00:20:00 +01:00

2 Commits