#![allow(
    clippy::assertions_on_constants,
    clippy::assertions_on_result_states,
    clippy::clone_on_copy,
    clippy::decimal_literal_representation,
    clippy::doc_markdown,
    clippy::empty_line_after_doc_comments,
    clippy::field_reassign_with_default,
    clippy::get_unwrap,
    clippy::identity_op,
    clippy::inconsistent_digit_grouping,
    clippy::indexing_slicing,
    clippy::integer_division,
    clippy::len_zero,
    clippy::let_underscore_must_use,
    clippy::manual_div_ceil,
    clippy::manual_let_else,
    clippy::manual_range_contains,
    clippy::modulo_arithmetic,
    clippy::needless_range_loop,
    clippy::non_ascii_literal,
    clippy::redundant_clone,
    clippy::shadow_reuse,
    clippy::shadow_same,
    clippy::shadow_unrelated,
    clippy::single_match_else,
    clippy::str_to_string,
    clippy::string_slice,
    clippy::tests_outside_test_module,
    clippy::too_many_lines,
    clippy::unnecessary_wraps,
    clippy::unseparated_literal_suffix,
    clippy::use_debug,
    clippy::useless_vec,
    clippy::wildcard_enum_match_arm,
    clippy::else_if_without_else,
    clippy::expect_used,
    clippy::missing_const_for_fn,
    clippy::similar_names,
    clippy::type_complexity,
    clippy::collapsible_else_if,
    clippy::doc_lazy_continuation,
    clippy::items_after_test_module,
    clippy::map_clone,
    clippy::multiple_unsafe_ops_per_block,
    clippy::unwrap_or_default,
    clippy::assign_op_pattern,
    clippy::needless_borrow,
    clippy::println_empty_string,
    clippy::unnecessary_cast,
    clippy::used_underscore_binding,
    clippy::create_dir,
    clippy::implicit_saturating_sub,
    clippy::exit,
    clippy::expect_fun_call,
    clippy::too_many_arguments,
    clippy::unnecessary_map_or,
    clippy::unwrap_used,
    dead_code,
    unused_imports,
    unused_variables,
    clippy::cloned_ref_to_slice_refs,
    clippy::neg_multiply,
    clippy::while_let_loop,
    clippy::bool_assert_comparison,
    clippy::excessive_precision,
    clippy::trivially_copy_pass_by_ref,
    clippy::op_ref,
    clippy::redundant_closure,
    clippy::unnecessary_lazy_evaluations,
    clippy::if_then_some_else_none,
    clippy::unnecessary_to_owned,
    clippy::single_component_path_imports,
)]
use ml::hyperopt::adapters::ppo::PPOParams;
use ml::hyperopt::traits::ParameterSpace;

#[test]
fn test_continuous_bounds_returns_6_parameters() {
    let bounds = PPOParams::continuous_bounds();
    assert_eq!(bounds.len(), 6, "Should have 6 parameter bounds");
}

#[test]
fn test_minibatch_size_bounds_correct() {
    let bounds = PPOParams::continuous_bounds();
    let minibatch_bounds = bounds[5]; // 6th parameter

    assert_eq!(minibatch_bounds.0, 64.0);
    assert_eq!(minibatch_bounds.1, 230.0);
}

#[test]
fn test_all_bounds_valid() {
    let bounds = PPOParams::continuous_bounds();
    for (i, (min, max)) in bounds.iter().enumerate() {
        assert!(min < max, "Parameter {} has invalid bounds", i);
    }
}

#[test]
fn test_lr_bounds_match_dqn_insights() {
    let bounds = PPOParams::continuous_bounds();

    // Policy LR upper bound should be 5e-5 (ln = -9.903)
    assert!((bounds[0].1 - 5e-5_f64.ln()).abs() < 1e-6);

    // Value LR upper bound should be 5e-3 (ln = -5.298)
    assert!((bounds[1].1 - 5e-3_f64.ln()).abs() < 1e-6);
}