Files
foxhunt/trading_engine
jgrusewski 86f7f1fa76 fix: comprehensive audit — real brokers, deployment fixes, production safety
Codebase audit identified 23 findings across 4 dimensions (production safety,
code health, deployment readiness, test quality). This commit fixes all of them.

Broker execution layer (was entirely stubbed):
- Real IBKR TWS client via ibapi crate (950+ lines, feature-gated)
- ICMarkets ctrader-openapi now always-on (removed feature flag)
- Real broker routing with health monitoring and exponential backoff reconnect
- Validated against live IB Gateway Docker (6/6 connectivity tests pass)

Deployment blockers:
- Fixed 6 broken Dockerfiles (removed COPY foxhunt-deploy)
- Created foxhunt K8s namespace, secret templates, migration job
- Added liveness probes to all 7 K8s services
- IB Gateway manifest (ghcr.io/gnzsnz/ib-gateway:stable)
- IBKR credentials in Scaleway Secret Manager via Terragrunt
- Fixed port collisions and mismatches across services

Production safety (9 critical + 6 high/medium fixes):
- Asset-class-specific VaR volatility (not flat 2%)
- Real parametric VaR with z-score 95th percentile
- Kyle's lambda regression (100-bar rolling window)
- Per-feature running statistics from historical data
- VWAP-based slippage reference, regime duration tracking
- Real Databento JSON parsing for OHLCV/Trade/Quote

Code health:
- Removed #![allow(dead_code)] from ml, data, config
- Fixed log:: → tracing:: in 4 production files
- Removed dead workspace deps (ratatui, crossterm)

Verified: cargo check --workspace (0 errors), trading_engine 330 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-25 00:32:10 +01:00
..

Trading Engine Crate

Overview

The trading_engine crate provides the high-performance core infrastructure essential for High-Frequency Trading (HFT) operations. It focuses on ultra-low latency execution, precise timing, and efficient order management to handle demanding market conditions.

Features

  • Extreme Performance Optimization: Utilizes RDTSC for precise timing, CPU affinity for dedicated core execution, and SIMD instructions for vectorized data processing.
  • Robust Order Management: Manages the lifecycle of orders, from placement to execution and cancellation, ensuring accuracy and low-latency updates.
  • Flexible Execution Engine: Implements a highly optimized engine capable of processing trading strategies and executing orders across various venues.
  • Multi-Broker Connectivity: Seamlessly integrates with multiple brokers, including Interactive Brokers and ICMarkets, via specialized adapters.
  • Event-Sourced Architecture: Employs event sourcing for deterministic state reconstruction, coupled with comprehensive metrics and persistent storage.
  • Concurrent Lock-Free Data Structures: Leverages advanced lock-free data structures to minimize contention and maximize throughput in multi-threaded environments.

Architecture

The trading_engine is structured around several key components:

  • Execution Core: The central logic for strategy evaluation and trade decision-making.
  • Order Manager: Handles all order-related operations, maintaining order state and communicating with broker adapters.
  • Broker Adapters: Abstract interfaces and concrete implementations for connecting to specific trading venues (e.g., IbAdapter, IcMarketsAdapter).
  • Performance Utilities: Modules for RDTSC access, CPU core pinning, and SIMD instruction sets.
  • Event Store: A mechanism for recording all significant events, enabling replay and auditability.
  • Metrics System: Collects and reports performance and operational statistics.
  • Persistence Layer: Stores critical state and event data for recovery and analysis.
  • Concurrency Primitives: Custom lock-free queues, rings, and other data structures.

Usage

To initialize the trading engine and place a simple order:

use trading_engine::{
    engine::TradingEngine,
    order::{Order, OrderSide, OrderType},
    broker::BrokerType,
};

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let mut engine = TradingEngine::new();
    engine.connect_broker(BrokerType::InteractiveBrokers).await?;

    let order = Order {
        symbol: "ESZ23".to_string(),
        side: OrderSide::Buy,
        order_type: OrderType::Limit,
        quantity: 1,
        price: Some(4500.0),
        // ... other order details
    };

    let order_id = engine.place_order(order).await?;
    println!("Placed order with ID: {}", order_id);

    Ok(())
}

Testing

To run the tests for the trading_engine crate:

cargo test --package trading_engine

Documentation

Comprehensive API documentation is available at docs.rs/trading_engine.