Three compile errors in crates/ml/tests/smoke_test_real_data.rs at lines 568,
644, and 715 — all three were calls to `collect_experiences_gpu(&market_buf,
&target_buf, ...)` where `market_buf` and `target_buf` were `CudaSlice<f32>`
allocated via `stream.alloc_zeros + memcpy_htod`.
The production API changed in cba9f25ed (Bug-1 close-out): both parameters now
require `&MappedF32Buffer` (mapped pinned DEVICEMAP, no HtoD copy). The test
helper `real_market_data` was never updated.
Migration applied to smoke_test_real_data.rs:
- Added `use ml::cuda_pipeline::mapped_pinned::MappedF32Buffer` import
- Removed now-unused `type CudaSlice<T>` alias
- Changed `real_market_data` return type from `(CudaSlice<f32>, CudaSlice<f32>, usize)`
to `(MappedF32Buffer, MappedF32Buffer, usize)`
- Replaced `stream.alloc_zeros + memcpy_htod` with
`unsafe { MappedF32Buffer::new(len) } + write_from_slice` at lines 511-517
- Parameter renamed `stream` → `_stream` since it is no longer used by the buffer
construction (stream is still used by callers via `GpuExperienceCollector::new`)
Pattern mirrors production caller in
crates/ml/src/trainers/dqn/trainer/training_loop.rs:1322-1337.
The two `unsafe` block warnings in the test are expected (same `warn(unsafe_code)`
lint applied project-wide; production code carries the same warnings).
mamba2_hyperopt_p0_p1_fixes.rs was also reported as failed but its failure was
purely a cascading linker OOM kill from the smoke_test_real_data compile error,
not an independent type error — confirmed by `cargo build --test
mamba2_hyperopt_p0_p1_fixes` succeeding independently.
NOTE: The SP7 T7 magnitude_distribution smoke does NOT pass — see report in
commit message body. Root cause: four sp7_lb_* entries were registered in
state_reset_registry.rs (commit aa2854017) but their dispatch arms in
DQNTrainer::reset_named_state (training_loop.rs) were never wired. Error at
runtime: "unknown name 'sp7_lb_diff_var_cql'". This is a T7 wire-up regression
separate from the test-compile fixes in this commit.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
148aa1f464