Files
foxhunt/archive/reports/dead_code_analysis.txt
jgrusewski 2df1ea92e1 feat(ml): WAVE 29 DQN Codebase Cleanup & Refactoring Campaign
BREAKING CHANGES:
- Removed orphaned dqn.rs monolithic trainer (4,975 lines)
- Removed orphaned dqn_ensemble.rs module (816 lines)
- Removed orphaned tft.rs and tft_complete_int8_integration_test.rs
- TFT trainer split into modular directory structure

DQN Module Refactoring:
- Split trainers/dqn.rs into modular structure (config.rs, statistics.rs, trainer.rs)
- Fixed hyperopt 39D search space (continuous params only)
- Boolean flags (use_dueling, use_double_dqn, use_per, use_noisy_nets) are now FIXED architectural decisions
- use_distributional defaults to false (Candle BUG #36 - scatter_add gradient issues)

Clean Module Structure:
- ml/src/trainers/dqn/ directory with proper mod.rs exports
- ml/src/trainers/tft/ directory with config.rs, types.rs, model.rs, trainer.rs, tests.rs
- All P0 features validated: TD-error clamping, batch diversity, LR scheduler, priority staleness

Documentation:
- Added comprehensive docs in docs/codebase-cleanup/
- ADR-001 for DQN refactoring decisions
- Rainbow DQN component matrix and quick reference guides

Build Status: Compiles with zero errors

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-27 23:46:13 +01:00

31 lines
906 B
Plaintext

=== DEAD CODE ANALYSIS - Sat Oct 4 08:45:42 PM CEST 2025 ===
## trading_service
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: methods `execute_volume_weighted_slices` and `detect_sniping_opportunity` are never used
--> services/trading_service/src/core/execution_engine.rs:616:14
|
176 | impl ExecutionEngine {
| -------------------- methods in this implementation
...
616 | async fn execute_volume_weighted_slices(&self, _instruction: &ExecutionInstruction, _routing: &RoutingDecision, _profile: &VolumeProf...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
617 | async fn detect_sniping_opportunity(&self, _book_update: &BookUpdate, _instruction: &ExecutionInstruction) -> Result<SnipingOpportuni...
---
## trading_engine
No dead code warnings or compilation failed
---
## ml
No dead code warnings or compilation failed
---
## risk