foxhunt/docs/DEAD_CODE_SUMMARY.md

Dead Code Analysis - Quick Summary

🎯 Key Findings

Overall Health: EXCELLENT ✅

The Foxhunt codebase is well-maintained with minimal dead code (0.15-0.26% of total LOC).

---

📊 Quick Stats

Metric	Value
Total Rust LOC	1,212,823
Total Files	2,699
Workspace Crates	33
Removable LOC	1,800-3,200 (0.15-0.26%)
Unused Dependencies	22-27 declarations
Empty Modules	4-6 placeholder files

---

🚀 Quick Wins (2-4 hours, LOW risk)

1. Remove Unused Test Dependencies

# These 7 crates declare but don't use test dependencies:
# risk, backtesting, database, trading-data, market-data, ml, storage

# Remove from Cargo.toml [dev-dependencies]:
# - tokio_test (unused in 7 crates)
# - rstest (unused in 3 crates)
# - test_case (unused in 2 crates)
# - futures_test, serial_test, tempfile (1 each)

2. Remove Placeholder Modules

# Remove these 4 empty placeholder files:
rm ml/src/regime/performance_tracker.rs
rm ml/src/regime/position_sizer.rs
rm ml/src/regime/ensemble.rs
rm ml/src/regime/dynamic_stops.rs

3. Clean Backtesting Dependencies

# Remove from backtesting/Cargo.toml:
# - thiserror (not used)
# - crossbeam + crossbeam_channel (not used)
# - ndarray (not used)
# - bincode (not used)
# - prometheus (not used)
# - fastrand (not used)

4. Clean Storage Dependencies

# Remove from storage/Cargo.toml:
# - tokio_util (not used)
# - rustc_hash (not used)
# - indexmap (not used)
# - fs2 (not used)
# - dashmap (not used)
# - backon (not used)

Impact: ~50 LOC + 20 dependency declarations removed

---

⚠️ Verify Before Removing (4-8 hours, MEDIUM risk)

1. Feature-Gated Code Audit

Postgres Feature (NOT enabled by default)

• 9 files with #[cfg(feature = "postgres")]
• Crates: adaptive-strategy, config, risk
• Action: Enable or remove postgres feature code

Redis-Cache Feature (NOT enabled by default)

• 3 locations in data crate
• Action: Check if redis caching is implemented

Databento Feature (DEFAULT enabled)

• Files: data crate tests
• Action: ✅ KEEP - Feature is enabled by default

S3 Storage (DEFAULT enabled)

• Files: storage, ml/checkpoint
• Action: ✅ KEEP - Default feature, actively used

2. Suspicious Dependencies

Crate	Dependency	Risk	Action
foxhunt	flate2	MEDIUM	Check if used in benchmarks
market-data	tokio, anyhow, tracing	MEDIUM	Verify with cargo tree
data	webpki_roots, xml_rs, hex, md5	MEDIUM	Check transitive usage
ml	arrayfire, argmin_math	HIGH	✅ SAFE TO REMOVE

---

📋 Recommended Removal Order

Phase 1: Immediate (LOW risk)

1. ✅ Test dependencies (7 crates) - 0 risk
2. ✅ Placeholder modules (4 files) - 24 LOC
3. ✅ backtesting deps (6 deps) - 0 risk
4. ✅ storage deps (6 deps) - 0 risk

Total: 24 LOC + 20 dep declarations

Phase 2: Verify First (MEDIUM risk)

1. ⚠️ Postgres feature code - 500 LOC
2. ⚠️ Redis-cache feature code - 100 LOC
3. ⚠️ market-data deps (4 deps)
4. ⚠️ data crate deps (5 deps)

Total: 600 LOC + 9 dep declarations

Phase 3: Low Priority

1. Consolidate minimal modules
2. Remove commented feature gates
3. Deep analysis of public APIs

Total: 1,000-2,000 LOC

---

🛠️ Validation Commands

Install cargo-udeps (definitive unused dep checker)

cargo install cargo-udeps
cargo +nightly udeps --workspace --all-targets

Check specific crates

cargo +nightly udeps -p backtesting
cargo +nightly udeps -p storage
cargo +nightly udeps -p ml

Verify feature builds

# Test if postgres feature works
cargo build --features postgres

# Test if redis-cache feature works
cargo build --features redis-cache

Find dead code with clippy

cargo clippy --workspace -- -W dead_code

---

💡 Special Notes

False Positives in Test Analysis

• compliance_breach_detection_tests.rs - Actually contains 20+ tests
• Script only detected #[test], not #[tokio::test]
• Most "test modules without tests" are FALSE POSITIVES

Keep These (NOT dead code)

• ✅ Comment blocks in operations.rs (API documentation)
• ✅ CUDA feature code (production ML training)
• ✅ S3 feature code (model persistence)
• ✅ Test module scaffolding (integration test infrastructure)

Feature Status

Feature	Status	Action
cuda	✅ DEFAULT	KEEP - ML training
s3	✅ DEFAULT	KEEP - Storage
databento	✅ DEFAULT	KEEP - Market data
postgres	❌ NOT DEFAULT	VERIFY or REMOVE
redis-cache	❌ NOT DEFAULT	VERIFY or REMOVE

---

📈 Expected Benefits

Build Time

• 2-5% faster compilation (fewer dependencies)
• Faster CI/CD (dependency resolution)

Maintenance

• 22-27 fewer dependencies to update
• Smaller security attack surface
• Clearer codebase structure

Code Quality

• 1,800-3,200 lines removed
• No more placeholder modules
• Feature flags properly documented

---

🎯 Next Steps

1. Run Phase 1 cleanup (2-4 hours, LOW risk)

   • Remove test dependencies
   • Remove placeholder modules
   • Clean backtesting/storage deps

2. Audit feature usage (2 hours)

   • Check postgres in production
   • Check redis-cache implementation
   • Document feature status

3. Run cargo-udeps (30 minutes)

   • Validate Phase 1 removals
   • Confirm Phase 2 candidates

4. Execute Phase 2 (4-8 hours, MEDIUM risk)

   • Remove unused feature code
   • Remove verified unused deps
   • Update documentation

---

📄 Full Report

See DEAD_CODE_ANALYSIS_REPORT.md for complete details including:

• Per-crate dependency analysis
• Safety assessments
• File-by-file breakdown
• Validation procedures
• Risk matrices

---

Generated: 2025-11-27 Analyst: Dead Code Analysis Script v1.0 Confidence: HIGH (85-90%)