foxhunt/JOB_QUEUE_QUICK_FIX.md

Job Queue Quick Fix Reference

Status: 🔴 BLOCKED by 17 compilation errors
Resolution Time: 40-55 minutes
Priority: CRITICAL

---

Immediate Actions (In Order)

1. Check MLError API (5 min)

rg "pub enum MLError" ml/src/ -A 20

Look for new variant structure (likely):

pub enum MLError {
    Database { source: Box<dyn Error> },
    Validation { message: String },
    // ... others
}

---

2. Fix checkpoint_manager.rs (15 min)

File: services/ml_training_service/src/checkpoint_manager.rs

Find & Replace (6 occurrences):

// OLD (4 occurrences):
MLError::DatabaseError(format!("..."))

// NEW:
MLError::Database { source: e.into() }

// OLD (2 occurrences):
MLError::ValidationError(format!("..."))

// NEW:
MLError::Validation { message: format!("...") }

Lines affected: 134, 176, 286, 335, 353, 356

---

3. Fix validation_pipeline.rs (5 min)

File: services/ml_training_service/src/validation_pipeline.rs

Line 300:

// OLD:
.upgrade_policy(VersionUpgradePolicy::Upgrade)

// NEW:
.set_upgrade_policy(VersionUpgradePolicy::Upgrade)

Check if Upgrade variant still exists:

rg "pub enum VersionUpgradePolicy" -A 10

---

4. Add Debug Trait (2 min)

File: services/ml_training_service/src/gpu_resource_manager.rs

Line 116:

// OLD:
pub struct GPUResourceManager {

// NEW:
#[derive(Debug)]
pub struct GPUResourceManager {

---

5. Fix Lifetime Issue (3 min)

File: services/ml_training_service/src/monitoring.rs

Line 339:

// OLD:
color: alert.severity_color(),

// NEW:
color: alert.severity_color().to_string(),

---

6. Compile & Verify (5-10 min)

cargo build -p ml_training_service
cargo test -p ml_training_service --lib

Expected: 0 errors, 15 warnings (acceptable)

---

Test Fixes (10 min)

Fix #1: test_job_queue_empty_dequeue

File: services/ml_training_service/tests/job_queue_tests.rs:177-188

#[tokio::test]
async fn test_job_queue_empty_dequeue() {
    let queue = JobQueue::new(10, 1).await.expect("Failed to create queue");
    let result = queue.dequeue().await.expect("Dequeue should not fail");
    assert!(result.is_none(), "Empty queue dequeue should return None");
}

---

Fix #2: test_job_queue_capacity_full

File: services/ml_training_service/tests/job_queue_tests.rs:191-227

Replace timeout logic with immediate error check:

// After filling queue to capacity (2 jobs)...

let job3_id = Uuid::new_v4();
let result = queue.enqueue(
    job3_id,
    "MAMBA_2".to_string(),
    create_test_config(),
    "Job 3".to_string(),
    HashMap::new(),
).await;

assert!(result.is_err(), "Enqueue on full queue should fail immediately");
assert!(result.unwrap_err().to_string().contains("capacity"));

---

Validation (5 min)

# Run all 16 job queue tests
cargo test -p ml_training_service --test job_queue_tests

# Expected output:
# test result: ok. 16 passed; 0 failed

---

Checklist

• Check MLError API structure
• Fix 6 MLError calls in checkpoint_manager.rs
• Fix DbnDecoder method call in validation_pipeline.rs
• Add Debug trait to GPUResourceManager
• Fix lifetime issue in monitoring.rs
• Compile successfully (0 errors)
• Fix test_job_queue_empty_dequeue
• Fix test_job_queue_capacity_full
• Run full test suite (16 tests pass)

---

Success Criteria

✅ cargo build -p ml_training_service → 0 errors
✅ cargo test -p ml_training_service --test job_queue_tests → 16 passed

Total Time: 40-55 minutes