jgrusewski
4468812478
fix(dqn): Plan A Task 2 — code-review fixes
Code-quality review on c2210e8b9 surfaced 2 medium + 4 minor issues
(per feedback_no_quickfixes.md, all fixed):
- M1: module-level #![allow(unsafe_code)] (matches signal_adapter.rs)
- M2: cubin loaded once via OnceLock (was reloaded per launch);
pattern matches gpu_her.rs/signal_adapter.rs
- M3: i32→u8 cast replaced with u8::try_from + descriptive expect;
lets a buggy kernel writing OOB fail loudly
- m4: host[0] direct indexing → host.first().copied().expect(...)
- m5: aspirational "Tests follow" comment → declarative
- m6: #[allow(dead_code)] at module top with descriptive comment
(helpers populated by Tasks 3-8)
Audit doc gets a code-review amendment block on the existing Task 2
entry to satisfy Invariant 7 (component change → audit-doc update).
No spec changes. Plan A Task 2 spec compliance preserved.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 08:25:40 +02:00
..
2026-02-23 11:19:58 +01:00
2026-03-11 22:00:13 +01:00
2026-04-27 08:10:42 +02:00
2026-04-24 18:28:19 +02:00
2026-04-24 20:36:46 +02:00
2026-04-27 08:25:40 +02:00
2026-04-25 12:29:47 +02:00
2026-04-25 11:02:23 +02:00
2026-04-26 10:36:03 +02:00