foxhunt/ml/tests/dqn_use_double_dqn_test.rs

//! Test use_double_dqn CLI argument properly flows through the system
//!
//! This test verifies that the use_double_dqn field:
//! 1. Exists in DQNHyperparameters struct
//! 2. Has the correct default value (true)
//! 3. Can be set to both true and false

use ml::trainers::dqn::DQNHyperparameters;

#[test]
fn test_dqn_hyperparameters_has_use_double_dqn_field() {
    // Create hyperparameters using conservative() method
    let hyperparams = DQNHyperparameters::conservative();

    // Field should exist and have the default value of true
    assert_eq!(
        hyperparams.use_double_dqn, true,
        "use_double_dqn should default to true (Double DQN enabled by default)"
    );
}

#[test]
fn test_use_double_dqn_can_be_disabled() {
    // Test that we can set use_double_dqn to false
    let mut hyperparams = DQNHyperparameters::conservative();
    hyperparams.use_double_dqn = false;

    assert_eq!(
        hyperparams.use_double_dqn, false,
        "use_double_dqn should be settable to false"
    );
}

#[test]
fn test_use_double_dqn_both_values() {
    // Test both true and false values
    let hyperparams_ddqn_enabled = DQNHyperparameters::conservative();
    assert!(
        hyperparams_ddqn_enabled.use_double_dqn,
        "Default should be Double DQN enabled"
    );

    let mut hyperparams_ddqn_disabled = DQNHyperparameters::conservative();
    hyperparams_ddqn_disabled.use_double_dqn = false;
    assert!(
        !hyperparams_ddqn_disabled.use_double_dqn,
        "Should support disabling Double DQN"
    );
}