BREAKING CHANGES: - Removed orphaned dqn.rs monolithic trainer (4,975 lines) - Removed orphaned dqn_ensemble.rs module (816 lines) - Removed orphaned tft.rs and tft_complete_int8_integration_test.rs - TFT trainer split into modular directory structure DQN Module Refactoring: - Split trainers/dqn.rs into modular structure (config.rs, statistics.rs, trainer.rs) - Fixed hyperopt 39D search space (continuous params only) - Boolean flags (use_dueling, use_double_dqn, use_per, use_noisy_nets) are now FIXED architectural decisions - use_distributional defaults to false (Candle BUG #36 - scatter_add gradient issues) Clean Module Structure: - ml/src/trainers/dqn/ directory with proper mod.rs exports - ml/src/trainers/tft/ directory with config.rs, types.rs, model.rs, trainer.rs, tests.rs - All P0 features validated: TD-error clamping, batch diversity, LR scheduler, priority staleness Documentation: - Added comprehensive docs in docs/codebase-cleanup/ - ADR-001 for DQN refactoring decisions - Rainbow DQN component matrix and quick reference guides Build Status: Compiles with zero errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Common Crate
Overview
The common crate provides a foundational set of shared types and utilities essential for building high-frequency trading applications within the Foxhunt ecosystem. It encapsulates core data structures, error handling patterns, and common helpers used across various components.
Features
- Market Data & Order Types: Defines standardized structs for market data (e.g.,
Tick,OrderBook) and various order types (e.g.,LimitOrder,MarketOrder). - High-Precision Time Utilities: Offers utilities for working with nanosecond-resolution timestamps and duration calculations critical for HFT.
- Robust Error Handling: Implements a custom
FoxhuntErrorenum andResulttype for consistent and traceable error management across the system. - Data Validation Helpers: Provides functions for validating common HFT parameters such as prices, quantities, and instrument IDs.
- Serialization/Deserialization: Includes helpers and derive macros for efficient data serialization (e.g., using
serde) for inter-process communication or persistence. - Instrument & Asset Definitions: Standardized types for defining trading instruments, assets, and exchanges.
Usage
use common::types::{Order, OrderSide, Price, Quantity, InstrumentId};
use common::errors::FoxhuntError;
fn create_limit_order(instrument: InstrumentId, price: Price, quantity: Quantity) -> Result<Order, FoxhuntError> {
if price.value() <= 0.0 || quantity.value() <= 0.0 {
return Err(FoxhuntError::ValidationError("Price and quantity must be positive".to_string()));
}
Ok(Order::new_limit(instrument, OrderSide::Buy, price, quantity))
}
let instrument = InstrumentId::new("BTCUSD".to_string());
let order = create_limit_order(instrument, Price::new(60000.0), Quantity::new(0.5));
println!("{:?}", order);
Testing
cargo test --package common
Documentation
Comprehensive API documentation is available at docs.rs/common.