foxhunt/docs/WAVE82_AGENT7_TRADING_SERVICE_TEST_FIX.md

Wave 82 Agent 7: Trading Service Test Compilation Fixes

Agent: Agent 7 - Trading Service Test Repair Date: 2025-10-03 Mission: Fix 107 compilation errors in trading_service tests (Wave 81 test files) Status: 🚧 IN PROGRESS

---

Executive Summary

Discovered During: Wave 82 Agent 6 workspace-wide compilation check Root Cause: Wave 81 test files created without verification of compilation Impact: Cannot run test suite - 107 errors blocking execution

Error Breakdown (trading_service only)

• auth_security_tests.rs: 31 errors
• execution_error_tests.rs: 46 errors
• integration_tests.rs: 30 errors

Total: 107 errors in trading_service alone (out of 118 workspace-wide)

---

Error Analysis

Category 1: RateLimiter Private Access (10 errors)

Error: error[E0603]: struct RateLimiter is private

Files Affected:

• services/trading_service/tests/auth_security_tests.rs (lines 556, 579, 606, 637, 662, 691, 714, 740, 769, 807)

Root Cause: Tests import trading_service::auth_interceptor::RateLimiter but struct is not public

Fix Strategy:

1. Check if RateLimiter should be imported from trading_service::rate_limiter instead
2. Alternatively, make RateLimiter public in auth_interceptor
3. Or refactor tests to not directly access RateLimiter struct

Category 2: Missing core Module (4 errors)

Error: error[E0433]: could not find 'core' in 'trading_service'

Files Affected:

• services/trading_service/tests/execution_error_tests.rs (lines 20, 24, 25, 26)

Example:

use trading_service::core::execution_engine::{...}; // WRONG
use trading_service::core::order_manager::{...};    // WRONG

Root Cause: core directory exists but not exported in lib.rs

Fix Strategy:

1. Add pub mod core; to services/trading_service/src/lib.rs
2. Add mod.rs to services/trading_service/src/core/ declaring submodules
3. Update imports to use actual module paths

Category 3: Type Mismatches & Missing Fields (Multiple errors)

Errors: E0308, E0560, E0063, E0609, E0689

Examples:

• struct SubmitOrderRequest has no field named 'time_in_force'
• struct TradeExecution missing fields 'aggressive_flag', 'trade_id'
• struct MarketEvent has no field named 'severity'
• can't call method abs on ambiguous numeric type {float}

Root Cause: Proto schema changes from tonic 0.14 upgrade (similar to Wave 82 Agent 5 ml_training_service fixes)

Fix Strategy: Update all struct initializations to match current proto schema

---

Action Plan

Phase 1: Structural Fixes

1. Add core module to lib.rs: Enable core module exports
2. Create core/mod.rs: Declare execution_engine, order_manager, position_manager, risk_manager
3. Fix RateLimiter imports: Change to use public rate_limiter module

Phase 2: Proto Schema Updates

1. execution_error_tests.rs: Update ExecutionEngine API calls and struct fields
2. auth_security_tests.rs: Update SubmitOrderRequest and authentication structs
3. integration_tests.rs: Update end-to-end test proto usage

Phase 3: Type Annotations

1. Fix float type ambiguity: Add explicit _f64 suffixes where needed

---

Progress Tracking

Status: Agent 7 deployment initiated Next: Deploy zen debug tool to systematically fix all errors Timeline: Estimated 45-60 minutes for 107 errors

---

Report generated: 2025-10-03 Agent 7 Status: Analyzing errors and creating fix strategy