foxhunt/G22_QUICK_FIX_GUIDE.md

G22 Quick Fix Guide - Integration Test Repairs

Target: Fix 3 blocking issues to achieve 95% production readiness
Total Effort: 4-6 hours
Current Status: 92% → Target: 95%

---

Fix #1: Trading Service Authentication (2-3 hours)

File: services/trading_service/tests/regime_grpc_integration_test.rs

Problem: 8/9 tests fail with Unauthenticated error

Solution Steps:

1. Create test helper (add to top of file):

use tonic::metadata::MetadataValue;

async fn create_authenticated_client() -> Result<TradingServiceClient<Channel>, Box<dyn std::error::Error>> {
    // Generate test JWT token
    let token = "test_token_placeholder"; // TODO: Use JwtGenerator from tli
    
    let channel = Channel::from_static("http://localhost:50052")
        .connect()
        .await?;
    
    let client = TradingServiceClient::with_interceptor(
        channel,
        move |mut req: Request<()>| {
            let token_value = MetadataValue::from_str(&format!("Bearer {}", token))?;
            req.metadata_mut().insert("authorization", token_value);
            Ok(req)
        }
    );
    
    Ok(client)
}

2. Update all test functions (replace create_client() calls):

// OLD:
let mut client = create_client().await.expect("...");

// NEW:
let mut client = create_authenticated_client().await.expect("...");

3. Verify:

cargo test -p trading_service --test regime_grpc_integration_test -- --ignored

Expected: All 9 tests pass

---

Fix #2: ML Pipeline E2E Test (1-2 hours)

File: ml/tests/wave_c_e2e_integration_test.rs

Problem: Compilation fails due to API drift

Solution Steps:

1. Add trait import (line ~17):

use common::MLModelAdapter;

2. Update extract_features() calls (lines 194-196, 251-253):

// OLD (6 args):
let features = extractor.extract_features(
    bar.open, bar.high, bar.low, bar.close, bar.volume, bar.timestamp
)?;

// NEW (3 args):
let features = extractor.extract_features(
    bar.open, bar.high, bar.timestamp
);

3. Remove ? operators (features returns Vec, not Result):

// OLD:
let features = extractor.extract_features(...)?;

// NEW:
let features = extractor.extract_features(...);

4. Verify:

cargo test -p ml --test wave_c_e2e_integration_test

Expected: Test compiles and runs

---

Fix #3: Backtesting Config Helper (30-60 min)

File: services/backtesting_service/tests/wave_d_regime_backtest_test.rs

Problem: BacktestingDatabaseConfig doesn't have Default trait

Solution Option A (Add Default to config struct):

File: config/src/database.rs

#[derive(Debug, Clone, Default)]
pub struct BacktestingDatabaseConfig {
    // ... fields
}

Solution Option B (Create test helper - recommended):

File: services/backtesting_service/tests/wave_d_regime_backtest_test.rs

fn test_db_config() -> BacktestingDatabaseConfig {
    BacktestingDatabaseConfig {
        connection_string: "postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt".to_string(),
        max_connections: 10,
        min_connections: 2,
        // ... other fields
    }
}

Then replace all instances:

// OLD:
BacktestingDatabaseConfig::default()

// NEW:
test_db_config()

Also fix BacktestStatus import (line 19):

// Remove direct import, use via proto
use backtesting_service::proto::backtesting_service::BacktestStatus;

Verify:

cargo test -p backtesting_service --test wave_d_regime_backtest_test

Expected: All 5 tests compile

---

Verification Commands

Run all tests after fixes:

# Trading Service (should pass 9/9)
cargo test -p trading_service --test regime_grpc_integration_test -- --ignored

# ML Pipeline (should compile and run)
cargo test -p ml --test wave_c_e2e_integration_test

# Backtesting (should compile and run)
cargo test -p backtesting_service --test wave_d_regime_backtest_test

# Full workspace sanity check
cargo test --workspace

---

Success Metrics

Before:

• Trading Service: 1/9 tests pass (11%)
• ML Pipeline: Won't compile
• Backtesting: Won't compile
• Production Readiness: 92%

After (Target):

• Trading Service: 9/9 tests pass (100%)
• ML Pipeline: Compiles and runs
• Backtesting: 5/5 tests pass (100%)
• Production Readiness: 95%

---

Estimated Timeline

Task	Effort	Blocking
Fix #1: Trading Auth	2-3 hours	Yes
Fix #2: ML E2E API	1-2 hours	Yes
Fix #3: Backtesting Config	30-60 min	No
Verification & Testing	30 min	-
TOTAL	4-6 hours	-

---

Next Agent

After completing these fixes, proceed to:

• Agent G23: Validate all integration tests pass
• Agent G24: Final production readiness check
• Agent G25: Deployment preparation

---

Generated by: Agent G22
Date: 2025-10-18
Full Report: AGENT_G22_INTEGRATION_TEST_REPORT.md