Files
foxhunt/docs
jgrusewski d646c1eb3c spec(ml-backtesting): apply 9 critical-review fixes to parallelism spec
Critical review surfaced 9 issues; all fixed inline:

1. §1 — Reframed "140× amortization" as "amortization on forward; sim
   runs parallel". True win is on the ~2ms forward shared across 140
   cells, not on sim work which scales linearly with n_backtests.
2. §2 — Made the 1h target vs firm bound explicit (≤1h target, ≤2h
   firm). Acknowledges Graph capture realistic speedup is 1.2-1.5×,
   not 2×.
3. §5 — Dropped atomicAdd. Plain `+=` under the single-writer-per-block
   convention (existing pattern across sim kernels). No race.
4. §4 — Documented max-over-horizons threshold rationale (vs per-
   horizon or aggregate-conviction). Flagged per-horizon as a follow-up
   tweak if dilution pathway matters in the verdict.
5. §7 P5 + §10 risk — Captured-vs-uncaptured tolerance is 1e-5 relative,
   NOT strict bit-identity. CUDA Graph capture can reorder reductions
   harmlessly by 1 ULP; strict bit-identity would be a false-positive.
6. §8 — Made explicit that parallel_sim_equivalence + independence
   tests are BOTH required. Equivalence alone is necessary but not
   sufficient (a shadow-backtest[0] bug still passes equivalence).
7. §3.3 — Specified output schema: `cell_W{n}/sim_<variant_name>/`
   with summary.json carrying a resolved `sim_config` block (verdict
   emitter reads that, not the directory name).
8. §7 P4 — Enumerated apply_fill_to_pos call sites + added grep-verify
   step before commit, so no fill path silently loses cost.
9. §9 — Tightened rate-validation gates with hard targets (P2 ≤90s,
   P5 ≤60s) instead of generous minute envelopes. Added §9.1 stride=8
   fallback as explicit Plan-B if Graph capture under-delivers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-19 16:27:38 +02:00
..