Files
foxhunt/crates/ml/tests/checkpoint_test.rs
jgrusewski db6462ba7a fix(clippy): resolve all clippy warnings across entire workspace (--all-targets)
Systematic fix of 360+ clippy errors across 37+ crates covering lib,
test, bench, and example targets. Key changes:

- Add targeted #[allow(...)] on #[cfg(test)] modules for test-only lints
  (assertions_on_result_states, float_cmp, str_to_string, indexing, etc.)
- Feature-gate broken integration tests behind __<crate>_integration flags
  where public APIs changed (trading-service, backtesting-service, etc.)
- Remove dead [[test]] entries from Cargo.toml files pointing to deleted files
- Fix production code: field_reassign_with_default, manual_range_contains,
  assert!(false) → panic!(), format!("{}") simplification, len() > 0 → !is_empty()
- Delete truly unused code (Order struct, unused methods/fields/variants)
- Convert sqlx::query!() to sqlx::query() for SQLX_OFFLINE compatibility

Result: cargo clippy --workspace --all-targets -- -D warnings = 0 errors, 0 warnings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 10:18:35 +01:00

619 lines
20 KiB
Rust

#![allow(
clippy::assertions_on_constants,
clippy::assertions_on_result_states,
clippy::clone_on_copy,
clippy::decimal_literal_representation,
clippy::doc_markdown,
clippy::empty_line_after_doc_comments,
clippy::field_reassign_with_default,
clippy::get_unwrap,
clippy::identity_op,
clippy::inconsistent_digit_grouping,
clippy::indexing_slicing,
clippy::integer_division,
clippy::len_zero,
clippy::let_underscore_must_use,
clippy::manual_div_ceil,
clippy::manual_let_else,
clippy::manual_range_contains,
clippy::modulo_arithmetic,
clippy::needless_range_loop,
clippy::non_ascii_literal,
clippy::redundant_clone,
clippy::shadow_reuse,
clippy::shadow_same,
clippy::shadow_unrelated,
clippy::single_match_else,
clippy::str_to_string,
clippy::string_slice,
clippy::tests_outside_test_module,
clippy::too_many_lines,
clippy::unnecessary_wraps,
clippy::unseparated_literal_suffix,
clippy::use_debug,
clippy::useless_vec,
clippy::wildcard_enum_match_arm,
clippy::else_if_without_else,
clippy::expect_used,
clippy::missing_const_for_fn,
clippy::similar_names,
clippy::type_complexity,
clippy::collapsible_else_if,
clippy::doc_lazy_continuation,
clippy::items_after_test_module,
clippy::map_clone,
clippy::multiple_unsafe_ops_per_block,
clippy::unwrap_or_default,
clippy::assign_op_pattern,
clippy::needless_borrow,
clippy::println_empty_string,
clippy::unnecessary_cast,
clippy::used_underscore_binding,
clippy::create_dir,
clippy::implicit_saturating_sub,
clippy::exit,
clippy::expect_fun_call,
clippy::too_many_arguments,
clippy::unnecessary_map_or,
clippy::unwrap_used,
dead_code,
unused_imports,
unused_variables,
clippy::cloned_ref_to_slice_refs,
clippy::neg_multiply,
clippy::while_let_loop,
clippy::bool_assert_comparison,
clippy::excessive_precision,
clippy::trivially_copy_pass_by_ref,
clippy::op_ref,
clippy::redundant_closure,
clippy::unnecessary_lazy_evaluations,
clippy::if_then_some_else_none,
clippy::unnecessary_to_owned,
clippy::single_component_path_imports,
)]
//! Checkpoint and Model Persistence Tests
//!
//! Comprehensive testing for model checkpointing covering:
//! - Checkpoint format validation
//! - Compression type selection
//! - Metadata creation and validation
//! - Storage backend operations
//! - Versioning and compatibility
#![allow(unused_crate_dependencies)]
use ml::checkpoint::{CheckpointFormat, CheckpointMetadata, CompressionType, ModelType};
/// Test: Checkpoint format variants
#[test]
fn test_checkpoint_format_variants() {
// Test all format types exist
let binary = CheckpointFormat::Binary;
let json = CheckpointFormat::JSON;
let msgpack = CheckpointFormat::MessagePack;
let custom = CheckpointFormat::Custom;
// Verify equality
assert_eq!(binary, CheckpointFormat::Binary);
assert_eq!(json, CheckpointFormat::JSON);
assert_eq!(msgpack, CheckpointFormat::MessagePack);
assert_eq!(custom, CheckpointFormat::Custom);
}
/// Test: Checkpoint format - Binary is fastest
#[test]
fn test_checkpoint_format_binary_performance() {
let format = CheckpointFormat::Binary;
// Binary format should be the default for performance
assert_eq!(format, CheckpointFormat::Binary);
}
/// Test: Checkpoint format - JSON is human-readable
#[test]
fn test_checkpoint_format_json_readable() {
let format = CheckpointFormat::JSON;
// JSON is for debugging and inspection
assert_eq!(format, CheckpointFormat::JSON);
}
/// Test: Checkpoint format - serialization
#[test]
fn test_checkpoint_format_serialization() {
let format = CheckpointFormat::Binary;
// Serialize to JSON
let json = serde_json::to_string(&format).expect("Should serialize");
// Deserialize back
let deserialized: CheckpointFormat = serde_json::from_str(&json).expect("Should deserialize");
assert_eq!(format, deserialized);
}
/// Test: Compression type variants
#[test]
fn test_compression_type_variants() {
// Test all compression types
let none = CompressionType::None;
let lz4 = CompressionType::LZ4;
let zstd = CompressionType::Zstd;
let gzip = CompressionType::Gzip;
// Verify equality
assert_eq!(none, CompressionType::None);
assert_eq!(lz4, CompressionType::LZ4);
assert_eq!(zstd, CompressionType::Zstd);
assert_eq!(gzip, CompressionType::Gzip);
}
/// Test: Compression type - None for no overhead
#[test]
fn test_compression_none() {
let compression = CompressionType::None;
// No compression for fastest I/O
assert_eq!(compression, CompressionType::None);
}
/// Test: Compression type - LZ4 for speed
#[test]
fn test_compression_lz4_speed() {
let compression = CompressionType::LZ4;
// LZ4 is fastest compression
assert_eq!(compression, CompressionType::LZ4);
}
/// Test: Compression type - Zstd for balance
#[test]
fn test_compression_zstd_balance() {
let compression = CompressionType::Zstd;
// Zstd balances speed and compression ratio
assert_eq!(compression, CompressionType::Zstd);
}
/// Test: Compression type - Gzip for maximum compression
#[test]
fn test_compression_gzip_ratio() {
let compression = CompressionType::Gzip;
// Gzip for highest compression ratio
assert_eq!(compression, CompressionType::Gzip);
}
/// Test: Compression type - serialization
#[test]
fn test_compression_type_serialization() {
let compression = CompressionType::Zstd;
// Serialize to JSON
let json = serde_json::to_string(&compression).expect("Should serialize");
// Deserialize back
let deserialized: CompressionType = serde_json::from_str(&json).expect("Should deserialize");
assert_eq!(compression, deserialized);
}
/// Test: Checkpoint metadata creation
#[test]
fn test_checkpoint_metadata_creation() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_001".to_string(),
model_type: ModelType::DQN,
model_name: "dqn_model".to_string(),
version: "1.0.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(1000),
epoch: Some(10),
loss: Some(0.5),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::None,
format: CheckpointFormat::Binary,
file_size: 1024000,
compressed_size: None,
checksum: "abc123".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Verify basic fields
assert_eq!(metadata.checkpoint_id, "ckpt_001");
assert_eq!(metadata.model_type, ModelType::DQN);
assert_eq!(metadata.version, "1.0.0");
assert_eq!(metadata.step, Some(1000));
assert_eq!(metadata.epoch, Some(10));
}
/// Test: Checkpoint metadata - training step validation
#[test]
fn test_checkpoint_metadata_training_step() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_002".to_string(),
model_type: ModelType::MAMBA,
model_name: "mamba_model".to_string(),
version: "2.0.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(5000),
epoch: Some(50),
loss: Some(0.3),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::LZ4,
format: CheckpointFormat::Binary,
file_size: 2048000,
compressed_size: None,
checksum: "def456".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Training step should be positive
assert!(metadata.step.unwrap() > 0);
assert!(metadata.epoch.unwrap() > 0);
}
/// Test: Checkpoint metadata - learning rate bounds
#[test]
fn test_checkpoint_metadata_learning_rate() {
let mut hyperparameters = std::collections::HashMap::new();
hyperparameters.insert("learning_rate".to_string(), serde_json::json!(0.0005));
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_003".to_string(),
model_type: ModelType::TFT,
model_name: "tft_model".to_string(),
version: "1.5.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(10000),
epoch: Some(100),
loss: Some(0.2),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters,
architecture: std::collections::HashMap::new(),
compression: CompressionType::Zstd,
format: CheckpointFormat::JSON,
file_size: 3072000,
compressed_size: None,
checksum: "ghi789".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Learning rate should be positive and reasonable
let learning_rate = metadata
.hyperparameters
.get("learning_rate")
.unwrap()
.as_f64()
.unwrap();
assert!(learning_rate > 0.0);
assert!(learning_rate <= 0.01);
}
/// Test: Checkpoint metadata - loss validation
#[test]
fn test_checkpoint_metadata_loss() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_004".to_string(),
model_type: ModelType::TGGN,
model_name: "tggn_model".to_string(),
version: "1.2.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(2000),
epoch: Some(20),
loss: Some(0.15),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::None,
format: CheckpointFormat::Binary,
file_size: 1536000,
compressed_size: None,
checksum: "jkl012".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Loss should be non-negative
assert!(metadata.loss.unwrap() >= 0.0);
// Loss should be reasonable (not NaN or infinity)
assert!(metadata.loss.unwrap().is_finite());
}
/// Test: Checkpoint metadata - file size validation
#[test]
fn test_checkpoint_metadata_file_size() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_005".to_string(),
model_type: ModelType::LNN,
model_name: "lnn_model".to_string(),
version: "3.0.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(15000),
epoch: Some(150),
loss: Some(0.1),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::Gzip,
format: CheckpointFormat::MessagePack,
file_size: 4096000,
compressed_size: None,
checksum: "mno345".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// File size should be positive
assert!(metadata.file_size > 0);
// File size should be reasonable (not too large)
assert!(metadata.file_size <= 10_000_000_000); // 10GB max
}
/// Test: Checkpoint metadata - checksum validation
#[test]
fn test_checkpoint_metadata_checksum() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_006".to_string(),
model_type: ModelType::DQN,
model_name: "dqn_model".to_string(),
version: "1.1.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(3000),
epoch: Some(30),
loss: Some(0.25),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::LZ4,
format: CheckpointFormat::Binary,
file_size: 2048000,
compressed_size: None,
checksum: "pqr678".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Checksum should not be empty
assert!(!metadata.checksum.is_empty());
// Checksum should be alphanumeric
assert!(metadata.checksum.chars().all(|c| c.is_alphanumeric()));
}
/// Test: Checkpoint metadata - serialization roundtrip
#[test]
fn test_checkpoint_metadata_serialization() {
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_007".to_string(),
model_type: ModelType::MAMBA,
model_name: "mamba_model".to_string(),
version: "2.1.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(7000),
epoch: Some(70),
loss: Some(0.18),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::Zstd,
format: CheckpointFormat::JSON,
file_size: 3584000,
compressed_size: None,
checksum: "stu901".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Serialize to JSON
let json = serde_json::to_string(&metadata).expect("Should serialize");
// Deserialize back
let deserialized: CheckpointMetadata = serde_json::from_str(&json).expect("Should deserialize");
// Verify key fields match
assert_eq!(metadata.checkpoint_id, deserialized.checkpoint_id);
assert_eq!(metadata.model_type, deserialized.model_type);
assert_eq!(metadata.version, deserialized.version);
assert_eq!(metadata.step, deserialized.step);
assert_eq!(metadata.epoch, deserialized.epoch);
}
/// Test: Model type variants
#[test]
fn test_model_type_variants() {
// Test all model types
let dqn = ModelType::DQN;
let mamba = ModelType::MAMBA;
let tft = ModelType::TFT;
let tggn = ModelType::TGGN;
let lnn = ModelType::LNN;
// Verify equality
assert_eq!(dqn, ModelType::DQN);
assert_eq!(mamba, ModelType::MAMBA);
assert_eq!(tft, ModelType::TFT);
assert_eq!(tggn, ModelType::TGGN);
assert_eq!(lnn, ModelType::LNN);
}
/// Test: Checkpoint metadata - metrics storage
#[test]
fn test_checkpoint_metadata_metrics() {
let mut metrics = std::collections::HashMap::new();
metrics.insert("accuracy".to_string(), 0.95);
metrics.insert("precision".to_string(), 0.92);
metrics.insert("recall".to_string(), 0.90);
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_008".to_string(),
model_type: ModelType::TFT,
model_name: "tft_model".to_string(),
version: "1.6.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(12000),
epoch: Some(120),
loss: Some(0.12),
accuracy: Some(0.95),
metrics,
hyperparameters: std::collections::HashMap::new(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::None,
format: CheckpointFormat::Binary,
file_size: 4608000,
compressed_size: None,
checksum: "vwx234".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Verify metrics are stored
assert_eq!(metadata.metrics.len(), 3);
assert_eq!(metadata.metrics.get("accuracy"), Some(&0.95));
assert_eq!(metadata.metrics.get("precision"), Some(&0.92));
assert_eq!(metadata.metrics.get("recall"), Some(&0.90));
}
/// Test: Checkpoint metadata - hyperparameters storage
#[test]
fn test_checkpoint_metadata_hyperparameters() {
let mut hyperparameters = std::collections::HashMap::new();
hyperparameters.insert("batch_size".to_string(), serde_json::json!(32));
hyperparameters.insert("dropout".to_string(), serde_json::json!(0.1));
hyperparameters.insert("num_layers".to_string(), serde_json::json!(4));
let metadata = CheckpointMetadata {
checkpoint_id: "ckpt_009".to_string(),
model_type: ModelType::TGGN,
model_name: "tggn_model".to_string(),
version: "1.3.0".to_string(),
created_at: chrono::Utc::now(),
step: Some(8000),
epoch: Some(80),
loss: Some(0.14),
accuracy: None,
metrics: std::collections::HashMap::new(),
hyperparameters: hyperparameters.clone(),
architecture: std::collections::HashMap::new(),
compression: CompressionType::LZ4,
format: CheckpointFormat::JSON,
file_size: 2560000,
compressed_size: None,
checksum: "yzA567".to_string(),
tags: vec![],
custom_metadata: std::collections::HashMap::new(),
signature: None,
signature_algorithm: "HMAC-SHA256".to_string(),
signing_key_id: "test-key-001".to_string(),
signed_at: None,
};
// Verify hyperparameters are stored
assert_eq!(metadata.hyperparameters.len(), 3);
assert_eq!(
metadata.hyperparameters.get("batch_size").unwrap().as_i64(),
Some(32)
);
assert_eq!(
metadata.hyperparameters.get("dropout").unwrap().as_f64(),
Some(0.1)
);
assert_eq!(
metadata.hyperparameters.get("num_layers").unwrap().as_i64(),
Some(4)
);
}
/// Test: Checkpoint format - all formats compatible
#[test]
fn test_checkpoint_formats_compatibility() {
let formats = vec![
CheckpointFormat::Binary,
CheckpointFormat::JSON,
CheckpointFormat::MessagePack,
CheckpointFormat::Custom,
];
// All formats should be distinct
for (i, format1) in formats.iter().enumerate() {
for (j, format2) in formats.iter().enumerate() {
if i == j {
assert_eq!(format1, format2);
} else {
assert_ne!(format1, format2);
}
}
}
}
/// Test: Compression types - all types compatible
#[test]
fn test_compression_types_compatibility() {
let compressions = vec![
CompressionType::None,
CompressionType::LZ4,
CompressionType::Zstd,
CompressionType::Gzip,
];
// All compression types should be distinct
for (i, comp1) in compressions.iter().enumerate() {
for (j, comp2) in compressions.iter().enumerate() {
if i == j {
assert_eq!(comp1, comp2);
} else {
assert_ne!(comp1, comp2);
}
}
}
}