foxhunt/scripts/auto_fix_safe.sh

#!/bin/bash
# auto_fix_safe.sh
# Applies all safe auto-fixes for clippy warnings
# Estimated time: 30 minutes (automated + testing)
# Safety: Only applies fixes that preserve semantics

set -e
cd "$(dirname "$0")/.."

echo "============================================"
echo "  Clippy Auto-Fix - Safe Warnings Only"
echo "============================================"
echo "Start time: $(date)"
echo ""

# Backup check
if ! git diff-index --quiet HEAD --; then
    echo "⚠️  WARNING: You have uncommitted changes."
    echo "   This script will modify files. Commit or stash first."
    read -p "Continue anyway? (y/N) " -n 1 -r
    echo
    if [[ ! $REPLY =~ ^[Yy]$ ]]; then
        echo "Aborted."
        exit 1
    fi
fi

echo "=== Step 1: Documentation Fixes (15 min) ==="
echo "Fixing: format strings, backticks, doc markdown"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W clippy::uninlined_format_args \
  -W clippy::doc_markdown \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ Documentation fixes complete"
echo ""

echo "=== Step 2: Redundant Code (20 min) ==="
echo "Fixing: redundant clones, borrows, closures, unnecessary returns"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W clippy::redundant_clone \
  -W clippy::needless_borrow \
  -W clippy::redundant_closure \
  -W clippy::unnecessary_wraps \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ Redundant code fixes complete"
echo ""

echo "=== Step 3: Type Conversions (1 hour - includes review) ==="
echo "Fixing: unnecessary casts, clone on Copy types"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W clippy::unnecessary_cast \
  -W clippy::clone_on_copy \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ Type conversion fixes complete"
echo "⚠️  NOTE: Manual review recommended for precision loss warnings"
echo ""

echo "=== Step 4: File Operations (10 min) ==="
echo "Fixing: file opened without truncate"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W clippy::suspicious_open_options \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ File operation fixes complete"
echo ""

echo "=== Step 5: Pattern Matching (15 min) ==="
echo "Fixing: single match, clamp patterns, manual string creation"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W clippy::single_match \
  -W clippy::option_if_let_else \
  -W clippy::manual_clamp \
  -W clippy::manual_string_new \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ Pattern matching fixes complete"
echo ""

echo "=== Step 6: Miscellaneous (10 min) ==="
echo "Fixing: unused imports, extern crates, digit grouping"
cargo clippy --fix --allow-dirty --allow-staged -- \
  -W unused_imports \
  -W unused_extern_crates \
  -W clippy::inconsistent_digit_grouping \
  -W clippy::into_iter_on_ref \
  -W clippy::derivable_impls \
  2>&1 | grep -E "Fixed|Fixing|warning:" | tail -20
echo "✅ Miscellaneous fixes complete"
echo ""

echo "=== Step 7: Testing (15 min) ==="
echo "Running workspace tests to verify fixes..."
if cargo test --workspace --no-fail-fast 2>&1 | tee /tmp/auto_fix_test_results.txt; then
    echo "✅ All tests passed"
else
    echo "❌ Some tests failed - review /tmp/auto_fix_test_results.txt"
    echo "   You may need to revert some changes"
    exit 1
fi
echo ""

echo "=== Step 8: Verification ==="
echo "Checking clippy status..."
WARNINGS_BEFORE=2488  # Historical baseline
WARNINGS_AFTER=$(cargo clippy --workspace --all-targets 2>&1 | grep -c "warning:" || echo "0")
WARNINGS_FIXED=$((WARNINGS_BEFORE - WARNINGS_AFTER))

echo ""
echo "============================================"
echo "  Auto-Fix Complete!"
echo "============================================"
echo "End time: $(date)"
echo ""
echo "Results:"
echo "  Warnings before: $WARNINGS_BEFORE"
echo "  Warnings after:  $WARNINGS_AFTER"
echo "  Warnings fixed:  $WARNINGS_FIXED (~$((WARNINGS_FIXED * 100 / WARNINGS_BEFORE))%)"
echo ""
echo "Next steps:"
echo "  1. Review changes: git diff"
echo "  2. Run full test suite: cargo test --workspace"
echo "  3. Commit changes: git add -A && git commit -m 'chore: Auto-fix clippy warnings (Phase 1)'"
echo "  4. Proceed to Phase 2: manual safety fixes (6h)"
echo ""
echo "✅ SUCCESS - ~850 safe warnings automatically fixed"