foxhunt/CLIPPY_EXAMPLES.md

Detailed Clippy Examples from Foxhunt Codebase

Critical Examples Requiring Immediate Attention

1. Default Numeric Fallback (risk-data crate)

File: /home/jgrusewski/Work/foxhunt/risk-data/src/compliance.rs

// Lines 405-408: ComplianceSeverity score calculation
match severity {
    ComplianceSeverity::Info => Decimal::from(10),      // ❌ Should be: Decimal::from(10_i32)
    ComplianceSeverity::Warning => Decimal::from(30),   // ❌ Should be: Decimal::from(30_i32)
    ComplianceSeverity::Critical => Decimal::from(70),  // ❌ Should be: Decimal::from(70_i32)
    ComplianceSeverity::Breach => Decimal::from(100),   // ❌ Should be: Decimal::from(100_i32)
}

// Lines 414-418: Event type scoring
match event_type {
    ComplianceEventType::LimitBreach => Decimal::from(30),              // ❌
    ComplianceEventType::EmergencyAction => Decimal::from(25),          // ❌
    ComplianceEventType::ConfigurationChange => Decimal::from(20),      // ❌
    ComplianceEventType::BestExecutionCheck => Decimal::from(15),       // ❌
    // ... more cases
}

// Lines 527-537: Query parameter binding
let mut bind_count = 2;  // ❌ Should be: 2_i32
if let Some(_) = severity {
    bind_count += 1;     // ❌ Should be: 1_i32
}
if let Some(_) = framework {
    bind_count += 1;     // ❌ Should be: 1_i32
}

Impact: 23 occurrences in this file alone Risk: Type inference ambiguity, potential for using wrong numeric type

---

2. Approximate Constants (common crate - TEST BLOCKER)

File: /home/jgrusewski/Work/foxhunt/common/tests/helper_functions_comprehensive_tests.rs:640

// ❌ BLOCKS COMPILATION
assert!((as_f64 - 1.41421356).abs() < 1e-6);

// ✅ FIX
assert!((as_f64 - std::f64::consts::SQRT_2).abs() < 1e-6);

Impact: This single error prevents test compilation Risk: Using hardcoded approximation instead of precise constant

---

3. Useless vec! (integration_load_tests)

File: /home/jgrusewski/Work/foxhunt/tests/load_tests/src/lib.rs:135

// ❌ Unnecessary heap allocation
let symbols = vec!["BTC/USD", "ETH/USD", "SOL/USD", "AVAX/USD", "MATIC/USD"];

// ✅ Use static array (stack-allocated)
let symbols = ["BTC/USD", "ETH/USD", "SOL/USD", "AVAX/USD", "MATIC/USD"];

Impact: 2 occurrences (lib.rs + tests/) Risk: Unnecessary heap allocation in performance-critical load test

---

4. Unneeded Unit Return Type (config crate)

File: /home/jgrusewski/Work/foxhunt/config/tests/runtime_tests.rs:27,37

// ❌ Redundant return type annotation
fn run_isolated<F>(f: F)
where
    F: FnOnce() -> (),  // ❌ Remove `-> ()`
{
    // ...
}

// ✅ Simplified
fn run_isolated<F>(f: F)
where
    F: FnOnce(),  // ✅ Implicit unit return
{
    // ...
}

Impact: 2 occurrences Risk: Code verbosity, idiomatic Rust issue

---

5. Assertions on Constants (config + common)

File: /home/jgrusewski/Work/foxhunt/config/tests/hot_reload_integration_tests.rs:77

// ❌ This will be optimized out by compiler
assert!(true, "Vault client created successfully");

// ✅ Remove entirely or use actual condition
// Just remove it - it provides no value

File: /home/jgrusewski/Work/foxhunt/common/src/thresholds.rs:465-475

// ❌ All compile-time constants - compiler optimizes these out
assert!(risk::BREACH_WARNING_PCT < risk::BREACH_SOFT_PCT);
assert!(risk::BREACH_SOFT_PCT < risk::BREACH_HARD_PCT);
assert!(risk::BREACH_HARD_PCT < risk::BREACH_CRITICAL_PCT);

assert!(var::Z_SCORE_P90 < var::Z_SCORE_P95);
assert!(var::Z_SCORE_P95 < var::Z_SCORE_P97_5);
assert!(var::Z_SCORE_P97_5 < var::Z_SCORE_P99);
assert!(var::Z_SCORE_P99 < var::Z_SCORE_P99_9);

Impact: 44 occurrences across workspace Risk: Dead code, false sense of validation

---

6. Single Component Path Imports (common tests)

File: /home/jgrusewski/Work/foxhunt/common/tests/types_comprehensive_tests.rs:17

// ❌ Redundant import
use serde_json;

// ✅ Remove - it's imported but never used
// OR use specific items: use serde_json::Value;

---

7. Clone on Copy (common tests)

File: /home/jgrusewski/Work/foxhunt/common/tests/error_tests.rs:576

// ❌ Unnecessary clone - ErrorCategory implements Copy
let cloned = category.clone();

// ✅ Just copy
let cloned = category;

Impact: 32 occurrences, mostly in tests Risk: Performance overhead (negligible in tests, but still unidiomatic)

---

8. Unreadable Literals (trading-data)

File: /home/jgrusewski/Work/foxhunt/trading-data/src/models.rs:98

// ❌ Hard to read large number
assert_eq!(order.quantity.to_f64(), 100000.0);

// ✅ Use underscores for readability
assert_eq!(order.quantity.to_f64(), 100_000.0);

Impact: 23 occurrences Risk: Readability, potential typos in large numbers

---

Workspace-Wide Patterns

Pattern A: Repeated Assertions on Constants

common/tests/helper_functions_comprehensive_tests.rs:649-721

All assertions comparing threshold constants can be removed:

• Risk thresholds (7 assertions)
• VAR confidence levels (7 assertions)
• Limit validations (7 assertions)
• Performance constants (3 assertions)

Total Dead Code: 44 assertions that provide no runtime value

---

Pattern B: Default Numeric Fallback in Decimal Operations

Affects three main files:

1. risk-data/src/compliance.rs - 23 occurrences
2. risk-data/src/limits.rs - 2 occurrences
3. risk-data/src/models.rs - 7 occurrences

Fix Pattern:

// Before
let value = Decimal::from(100);

// After  
let value = Decimal::from(100_i32);

Total Impact: 32 fixes needed in risk-data crate alone

---

Auto-Fix Commands

Quick Wins (Auto-fixable)

# Fix useless vec! (2 occurrences)
cargo clippy --fix --allow-dirty --allow-staged \
  -p integration_load_tests -- -A clippy::all -W clippy::useless_vec

# Fix unreadable literals (23 occurrences)
cargo clippy --fix --allow-dirty --allow-staged \
  --workspace -- -A clippy::all -W clippy::unreadable_literal

# Fix clone on copy (32 occurrences)
cargo clippy --fix --allow-dirty --allow-staged \
  --workspace -- -A clippy::all -W clippy::clone_on_copy

# Fix redundant imports
cargo clippy --fix --allow-dirty --allow-staged \
  --workspace -- -A clippy::all -W clippy::single_component_path_imports

Manual Fixes Required

# 1. Fix SQRT_2 constant (BLOCKER)
# Edit: common/tests/helper_functions_comprehensive_tests.rs:640
# Change: 1.41421356 → std::f64::consts::SQRT_2

# 2. Add type suffixes to Decimal::from() calls
# Edit: risk-data/src/{compliance,limits,models}.rs
# Pattern: Decimal::from(N) → Decimal::from(N_i32)

# 3. Remove assertion dead code
# Edit: common/src/thresholds.rs + various test files
# Remove all assert!(const < const) patterns

# 4. Remove assert!(true)
# Edit: config/tests/hot_reload_integration_tests.rs:77

---

Verification After Fixes

# Check if compilation now succeeds
cargo clippy --workspace --all-targets -- -D warnings

# Expected after Phase 1 fixes:
# - common tests should compile
# - integration_load_tests should compile  
# - Remaining: adaptive-strategy errors (13 errors - requires separate analysis)

---

Critical Files Status

File	Errors	Warnings	Status	Priority
common/tests/helper_functions_comprehensive_tests.rs	1	30	❌ BLOCKS	P0
risk-data/src/compliance.rs	0	23	⚠️	P1
risk-data/src/limits.rs	0	2	⚠️	P1
risk-data/src/models.rs	0	7	⚠️	P1
tests/load_tests/src/lib.rs	0	1	⚠️	P2
config/tests/runtime_tests.rs	0	3	⚠️	P3
adaptive-strategy/src/regime/mod.rs	13	200+	❌ BLOCKS	P0

P0 = Blocks compilation, P1 = Production risk, P2 = Performance, P3 = Code quality