jgrusewski
f3cb0c78c2
docs(sp15): amend spec — 14 fixes from critical review
Critical review (combined fresh-eyes subagent + self-critique) flagged
14 issues. All addressed in this amendment.
CRITICAL (blocks implementation):
- §4.3 NEW: ISV slot allocation map [397..441) per phase, prevents
parallel-dispatch ISV-table conflict (was: undefined, would break
Approach B)
- §4.4 NEW: Phase 2A ↔ Phase 1.2 ABI contract (LobBar struct as
canonical contract, Phase 2A defines first; Phase 1.2 conforms).
Restores parallelism dependency
- §9.2 (3.5.4): plasticity injection now MANDATES cooldown engagement
via PLASTICITY_WARM_BARS_REMAINING slot 438. NEW anchor test 2.22
plasticity_cooldown_interlock prevents random-tail-output retrigger
loop
- §9.2 (3.5.5): recovery curriculum replaced episode-level metadata
(didn't exist in transition-level PER) with per-step DD_TRAJECTORY_
DECREASING signal — same goal, no PER restructure
IMPORTANT (rework prevention):
- §9.2 (3.5.3): cooldown K threshold from running mean of per-trade
PnL (NOT variance — variance is LOW during streaks, would delay
cooldown when needed)
- §8.2 (3.5): Hold floor function form specified as bounded sigmoid
with α/k/ε₀ ISV-driven; was "monotonic_inv_func" (undefined family)
- §6.2: cost kernel per-side semantics explicit. Half-spread × side_
indicator at entry AND exit; commission_per_rt on close. Resolves
round-trip vs per-side ambiguity
- §6.2: OFI impact λ initial value 2e-4 + ISV refit methodology;
was "empirical fit from MES historical" (hand-wavy)
- §6.4: 8 baselines now mandate shared trunk forward; honest 15-25%
overhead estimate (was 5-10%, optimistic)
- §12.3: Q9 burn policy explicitly honor-system, not enforcement.
Mitigations described as deterrents not enforcement
- §10.6: Phase 4.5 thresholds CLI-config-driven with rationale,
anchored empirically post-Phase-1 (was hardcoded > 1.0)
NIT:
- §9.2 (3.5.2): multiplier vs SP12 cap interaction explicit (applied
BEFORE cap)
- §8.2 (3.1): α=0.7 hardcoded → ISV-driven from grad ratio (was
feedback_isv_for_adaptive_bounds violation)
- §13: pearls reframed as candidates pending validation per discipline
rule; pre-naming pressure removed
Test count: 21 → 22 (added 2.22). Phase 2 LOC: 2000 → 2100.
ISV_TOTAL_DIM: 396 → 441 post-SP15.
All 14 issues addressed in spec text. Ready for user review.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-06 08:51:35 +02:00
..
2026-02-23 11:19:58 +01:00
2026-03-11 22:00:13 +01:00
2026-05-06 08:51:35 +02:00
2026-04-30 17:26:25 +02:00
2026-05-02 21:13:53 +02:00
2026-04-27 22:19:41 +02:00
2026-05-05 21:43:46 +02:00
2026-04-25 12:29:47 +02:00
2026-04-28 23:54:45 +02:00
2026-05-05 22:07:55 +02:00
2026-04-28 09:23:32 +02:00
2026-04-26 10:36:03 +02:00