Files
foxhunt/docs
jgrusewski ff00af68a3 refactor(dqn): delete vestigial RegimeConditionalDQN — MoE replaces it
Atomic cleanup per feedback_no_partial_refactor.md:

- Delete crates/ml-dqn/src/regime_conditional.rs and all
  RegimeConditional* exports from lib.rs. regime_classifier.rs
  (RegimeType, RegimeClassConfig) is kept — used by validation layer
  and ml-regime-detection crate.
- Rewrite DQNAgentType to wrap DQN directly (no RegimeConditionalDQN
  field, no 3-head delegation gymnastics).
- DQNAgentType::get_count_bonuses_branched no longer returns hardcoded
  None — it delegates to DQN::get_count_bonuses_branched() and UCB
  count bonuses reach the GPU action selector for the first time
  (ghost feature from Phase 0 deferral). action.rs caller simplified
  to direct destructure of fixed arrays, no Option matching.
- Drop 4 regime-threshold fields from DQNConfig (regime_adx_idx,
  regime_cusum_idx, regime_adx_threshold, regime_cusum_threshold) +
  matching Default and aggressive() builder entries.
- serialize_model rewritten to serialize single DQN branching network
  directly (no trending__/ranging__/volatile__ prefix namespace).
- curriculum.rs import fixed: crate::dqn::regime_conditional::RegimeType
  → crate::dqn::RegimeType (re-exported from regime_classifier).
- Constructor drops RegimeConditionalDQN::new_on_device, calls
  DQN::new_on_device directly.
- Stale doc comments in dqn.rs, moe.rs, regime_classifier.rs updated.
- Wire-up audit updated.

Phase 3 MoE (commit a52d99613) provides the regime-conditioned behavior
the legacy 3-head architecture pretended to do — gate sees ADX (40)
and CUSUM (41) as part of the full 128-dim state vector and learns its
own decomposition, strictly subsuming the threshold classifier.

Smoke: 3/3 folds passed (405s), gate util=0.119,0.119,0.169,... preserved,
all fold checkpoints written. Workspace: 0 errors across all crates,
tests, and examples.

Spec: docs/superpowers/specs/2026-04-27-moe-regime-redesign-design.md §7.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-27 20:21:09 +02:00
..