gitadmin/foxhunt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup(fflag): delete dead enable_network_diagnostics flag — [FFLAG-015]

Browse Source 
LoggingConfig.enable_network_diagnostics was declared and defaulted but
never read anywhere (only test round-trip assertions existed). Deleted
field + Default init + two test assertions that validated the round-trip.
Zero production callers per rg.
This commit is contained in:
jgrusewski
2026-04-20 22:16:23 +02:00
parent e508475f3c
commit 0c5186cdaa
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/ml-dqn/src/logging.rs
View File

@@ -31,8 +31,6 @@ pub struct LoggingConfig {
pub gradient_log_interval: usize,
/// Minimum duration between metric logs to prevent spam (default: 1s)
pub min_log_interval: Duration,
/// Enable network diagnostics logging (default: false)
pub enable_network_diagnostics: bool,
}
impl Default for LoggingConfig {
@@ -43,7 +41,6 @@ impl Default for LoggingConfig {
trace_forward_pass: false,
gradient_log_interval: 500,
min_log_interval: Duration::from_secs(1),
enable_network_diagnostics: false,
}
}
}
@@ -332,7 +329,6 @@ mod tests {
assert!(!config.trace_forward_pass);
assert_eq!(config.gradient_log_interval, 500);
assert_eq!(config.min_log_interval, Duration::from_secs(1));
assert!(!config.enable_network_diagnostics);
}
#[test]
@@ -343,14 +339,12 @@ mod tests {
trace_forward_pass: true,
gradient_log_interval: 100,
min_log_interval: Duration::from_millis(500),
enable_network_diagnostics: true,
};
assert_eq!(config.batch_log_interval, 50);
assert!(!config.log_epoch_summaries);
assert!(config.trace_forward_pass);
assert_eq!(config.gradient_log_interval, 100);
assert_eq!(config.min_log_interval, Duration::from_millis(500));
assert!(config.enable_network_diagnostics);
}
// ========================================================================