gitadmin/foxhunt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: update scoreboard — iter 7 (3 fixed, FFLAG-013b deferral noted + DEAD-003/004 added)

Browse Source
This commit is contained in:
jgrusewski
2026-04-20 22:49:57 +02:00
parent be4f9932b0
commit 34b764a91d
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/superpowers/cleanup/dqn-cleanup-scoreboard.md
View File

@@ -1,7 +1,7 @@
---
iteration: 7
iteration: 8
last_scan: 2026-04-20T20:05:00Z
last_scoreboard_hash: iter6resolved-fflag012-fflag018a
last_scoreboard_hash: iter7resolved-fflag013a-fflag016-fflag017
consecutive_stall_count: 0
status: active
---
@@ -24,11 +24,12 @@ Representative sampling from iteration-1 scan. Future iterations will expand thi
- [ ] [FFLAG-010] `use_cvar_action_selection`: `crates/ml-dqn/src/dqn.rs:223` — S=5 B=3 E=3 score=5.0
- [x] [FFLAG-011] `enable_causal_intervention` — RESOLVED iter 5 commit 35ccc48c9 (dead-flag chain: DqnTrainerConfig → CausalInterventionConfig.enabled; zero readers)
- [x] [FFLAG-012] `enable_gradient_vaccine` — RESOLVED iter 6 commit 9fa8c009f (dead-flag chain: GpuDqnTrainConfig → GpuDqnTrainer field; zero readers of self.enable_gradient_vaccine)
- [ ] [FFLAG-013] `use_noisy_nets`+`use_distributional`+`enable_action_masking`: `crates/ml/src/cuda_pipeline/gpu_experience_collector.rs:204,208,245` — S=5 B=5 E=5 score=5.0
- [x] [FFLAG-013a] `use_noisy_nets`+`use_distributional` in GpuExperienceCollectorConfig — RESOLVED iter 7 commit be4f9932b (both dead, comments said "always enabled")
- [?] [FFLAG-013b] `enable_action_masking` — DEFERRED: real gating chain across collector config + GpuDqnTrainer.enable_action_masking field + training_loop setter. Mixed defaults (false in collector default, true at constructor.rs:380). Needs coordinated 3-file fix.
- [ ] [FFLAG-014] `enable_backtest`: `crates/ml/src/hyperopt/adapters/dqn.rs:507` — S=5 B=3 E=3 score=5.0
- [x] [FFLAG-015] `enable_network_diagnostics` — RESOLVED iter 2 commit 0c5186cda
- [ ] [FFLAG-016] `use_flash_attention`+`use_sparse_attention`+`use_cuda_graphs`+`enable_profiling`: `crates/ml/src/transformers/mod.rs:125,126,135,136` — S=5 B=3 E=3 score=5.0
- [ ] [FFLAG-017] `use_market_microstructure`+`use_order_book_features`+`use_trade_flow_features`: `crates/ml/src/transformers/mod.rs:120,121,122` — S=5 B=3 E=3 score=5.0
- [x] [FFLAG-016] transformer 4-flag set (`use_flash_attention`, `use_sparse_attention`, `use_cuda_graphs`, `enable_profiling`) — RESOLVED iter 7 commit 3f4fa33b9 (all 4 were aspirational config with zero implementation behind them; actual flash/sparse attention lives in `crates/ml/src/flash_attention/mod.rs`)
- [x] [FFLAG-017] transformer 3-flag set (`use_market_microstructure`, `use_order_book_features`, `use_trade_flow_features`) — RESOLVED iter 7 commit 3f4fa33b9 (all 3 dead; only referenced in orphan `features.rs` file — see DEAD-003)
- [x] [FFLAG-018a] `enable_quality_filtering`+`enable_augmentation` in unified_data_loader — RESOLVED iter 6 commit 37451834a (both write-only; use_unified_extractor left — actively gates feature_extractor Option)
- [ ] [FFLAG-018b] `use_unified_extractor`: `crates/ml/src/training/unified_data_loader.rs:118` — deferred; collapsing would require removing the `Option<UnifiedFeatureExtractor>` pattern at line 263 and simplifying is_some() checks at 516, 593. Cross-cut 1-file but semantically non-trivial.
@@ -51,6 +52,8 @@ Representative sampling from iteration-1 scan. Future iterations will expand thi
### DEAD (severity 3)
- [x] [DEAD-001] `use_different_seeds` unused field — RESOLVED iter 1 commit 4bbe1e561
- [ ] [DEAD-002] `select_active_symbol` + `set_opportunity_scores` + `opportunity_scores` field all dead: `crates/ml-dqn/src/multi_asset.rs:308,317` — S=3 B=1 E=3 score=1.0
- [ ] [DEAD-003] `crates/ml/src/transformers/features.rs` is orphan (126 LOC, not declared via `mod features;` — not in build). References types that don't exist (`FeatureConfig`, `MarketTick` etc). — S=3 B=1 E=3 score=1.0
- [ ] [DEAD-004] `use_sparse_patterns` field in `crates/ml/src/flash_attention/mod.rs:186` — write-only, zero conditional readers. Real sparse-attention logic runs unconditionally via `create_sparse_mask()` at line 317. — S=3 B=3 E=1 score=9.0
### UNWRAP (severity 3 — training hot path)
- [x] [UNWRAP-001] false-positive — line 1127 is inside `mod tests` (iter 2, no commit)
@@ -79,6 +82,9 @@ Representative sampling from iteration-1 scan. Future iterations will expand thi
- [x] [FFLAG-011] `enable_causal_intervention` dead-flag chain removed — iter 5 — commit 35ccc48c9
- [x] [FFLAG-012] `enable_gradient_vaccine` dead-flag chain removed — iter 6 — commit 9fa8c009f
- [x] [FFLAG-018a] `enable_quality_filtering`+`enable_augmentation` in unified_data_loader — iter 6 — commit 37451834a
- [x] [FFLAG-016] transformer 4-flag set (aspirational config, zero impl) — iter 7 — commit 3f4fa33b9
- [x] [FFLAG-017] transformer 3-flag set (feature selectors, no impl) — iter 7 — commit 3f4fa33b9
- [x] [FFLAG-013a] `use_noisy_nets`+`use_distributional` in GpuExperienceCollectorConfig — iter 7 — commit be4f9932b
## Known external state (NOT open findings)
Prior WIP blocker (`set_meta_q_pred` missing method) was committed by