gitadmin/foxhunt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(tests): action_space fallback 5→9, gpu_smoketest adam_epsilon

Browse Source 
- metrics.rs: fallback action_space was hardcoded 5 (old non-branching).
  Changed to 9 (exposure levels). Branching is always active.
- smoke_test_real_data: assertion updated to accept >=9 action space
  (81 with factored counts, 9 for short runs with empty factored counts)
- gpu_smoketest: added missing adam_epsilon field

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2026-03-29 21:47:14 +02:00
parent 9dd48621ea
commit 45473a45f0
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/ml/src/trainers/dqn/trainer/metrics.rs
View File

@@ -111,12 +111,12 @@ impl DQNTrainer {
let top5_coverage_pct = (top5_count as f64 / total_factored as f64) * 100.0;
metrics.add_metric("top5_coverage_pct", top5_coverage_pct);
} else {
// Fallback: 5 exposure levels
// Fallback: exposure-only (9 levels)
let unique_actions = total_action_counts.iter()
.filter(|&&count| count > 0).count();
let action_diversity = (unique_actions as f64 / 5.0) * 100.0;
let action_diversity = (unique_actions as f64 / 9.0) * 100.0;
metrics.add_metric("action_diversity", action_diversity);
metrics.add_metric("action_space_size", 5.0);
metrics.add_metric("action_space_size", 9.0);
let active_threshold = (total_exposure as f64 * 0.005).max(1.0);
let active_count = total_action_counts.iter()

6
crates/ml/tests/smoke_test_real_data.rs
View File

@@ -883,9 +883,11 @@ async fn smoke_e2e_dqn_training_loop() {
.copied()
.unwrap_or(0.0);
info!(action_space, action_diversity, total_actions, "Action metrics");
// Branching DQN: action_space=81 (9×3×3) when factored counts populated,
// or 9 (exposure-only fallback) for very short runs.
assert!(
action_space > 5.0 || total_actions == 0.0,
"Branching DQN should report 81-action space, got {action_space}"
action_space >= 9.0 || total_actions == 0.0,
"Branching DQN should report >=9 action space, got {action_space}"
);
// 6. Gradient norms should be non-zero (clipping is functional)