fix: resolve rebase conflict markers and align ModelType semantics

Fix leftover conflict markers from rebase onto main. Align as_str()
with main's semantics (general-purpose model names), add separate
s3_prefix() for S3 storage paths, and fix to_db_string() to preserve
per-variant database values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2026-02-22 23:56:29 +01:00
parent 4ec8e58cf4
commit 4dd6e24a4e
3 changed files with 6 additions and 11 deletions

2
Cargo.lock generated
View File

@@ -5826,8 +5826,8 @@ dependencies = [
"anyhow",
"async-trait",
"chrono",
"common",
"lru",
"ml",
"parking_lot 0.12.5",
"semver 1.0.27",
"serde",

View File

@@ -108,13 +108,8 @@ pub fn run_campaign(config: &CampaignConfig) -> anyhow::Result<CampaignResults>
ModelType::PPO => {
anyhow::bail!("PPO campaign not yet implemented")
}
<<<<<<< HEAD
other => {
anyhow::bail!("Hyperopt campaign not supported for model type: {}", other)
=======
_ => {
anyhow::bail!("Campaign not supported for model type: {:?}", config.model_type)
>>>>>>> dd4532a3 (refactor: unify ModelType into common/model_types.rs)
}
}
}

View File

@@ -373,17 +373,17 @@ mod tests {
use super::*;
#[test]
<<<<<<< HEAD
fn test_model_type_s3_prefix() {
assert_eq!(ModelType::TLOB.s3_prefix(), "tlob_transformer");
assert_eq!(ModelType::DQN.s3_prefix(), "dqn");
assert_eq!(ModelType::MAMBA.s3_prefix(), "mamba2");
=======
}
#[test]
fn test_model_type_as_str() {
assert_eq!(ModelType::TLOB.as_str(), "tlob_transformer");
assert_eq!(ModelType::TLOB.as_str(), "tlob");
assert_eq!(ModelType::DQN.as_str(), "dqn");
assert_eq!(ModelType::MAMBA.as_str(), "mamba2");
>>>>>>> dd4532a3 (refactor: unify ModelType into common/model_types.rs)
assert_eq!(ModelType::MAMBA.as_str(), "mamba");
}
#[test]