gitadmin/foxhunt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(trading_service): update feature importance stub to unimplemented

Browse Source 
Changed from Status::unavailable to Status::unimplemented with path
forward (ml_training_service forwarding). Fixed supports_feature_importance
from true to false.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2026-03-02 14:17:54 +01:00
parent ca2468f5ae
commit 669c3b93d4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/trading_service/src/services/enhanced_ml.rs
View File

@@ -874,7 +874,7 @@ impl MlService for EnhancedMLServiceImpl {
capabilities: Some(ModelCapabilities {
supports_streaming: true,
supports_retraining: true,
supports_feature_importance: true,
supports_feature_importance: false,
supports_confidence_intervals: false,
supported_asset_classes: vec!["FX".to_string()],
}),
@@ -1167,8 +1167,8 @@ impl MlService for EnhancedMLServiceImpl {
) -> Result<Response<GetFeatureImportanceResponse>, Status> {
let req = request.into_inner();
Err(Status::unavailable(format!(
"Feature importance for '{}' requires SHAP or gradient-based computation — not yet implemented",
Err(Status::unimplemented(format!(
"Feature importance for '{}' requires forwarding to ml_training_service (integrated gradients available in ml::explainability)",
req.model_name
)))
}