fix: review fixes — IMAGE_PULL_SECRETS, SCW registry, devpod provider

- Add missing IMAGE_PULL_SECRETS=gitlab-registry to devpod-setup.sh
- CI job pushes devcontainer to SCW registry (not internal GitLab)
- Remove unused internal registry auth from build-devcontainer job
- Add customizations.devpod.provider to devcontainer.json

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2026-02-25 21:19:32 +01:00
parent fca785533b
commit b8d4138c28
3 changed files with 10 additions and 5 deletions

View File

@@ -14,5 +14,10 @@
"EDITOR": "vim"
},
"postCreateCommand": "/usr/local/bin/init-home.sh",
"postStartCommand": "claude --version && cargo --version && kubectl cluster-info 2>/dev/null || true"
"postStartCommand": "claude --version && cargo --version && kubectl cluster-info 2>/dev/null || true",
"customizations": {
"devpod": {
"provider": "kubernetes"
}
}
}

View File

@@ -78,14 +78,13 @@ build-devcontainer:
before_script:
- mkdir -p /kaniko/.docker
- |
echo "{\"auths\":{\"${INTERNAL_REGISTRY}\":{\"username\":\"${CI_REGISTRY_USER}\",\"password\":\"${CI_REGISTRY_PASSWORD}\"},\"rg.fr-par.scw.cloud\":{\"username\":\"nologin\",\"password\":\"${SCW_SECRET_KEY}\"}}}" > /kaniko/.docker/config.json
echo "{\"auths\":{\"rg.fr-par.scw.cloud\":{\"username\":\"nologin\",\"password\":\"${SCW_SECRET_KEY}\"}}}" > /kaniko/.docker/config.json
script:
- /kaniko/executor
--context "${CI_PROJECT_DIR}"
--dockerfile "${CI_PROJECT_DIR}/.devcontainer/Dockerfile"
--insecure-registry "${INTERNAL_REGISTRY}"
--destination "${REGISTRY}/devcontainer:${CI_COMMIT_SHA}"
--destination "${REGISTRY}/devcontainer:latest"
--destination "rg.fr-par.scw.cloud/foxhunt-ci/devcontainer:${CI_COMMIT_SHA}"
--destination "rg.fr-par.scw.cloud/foxhunt-ci/devcontainer:latest"
# Base template for Rust jobs — pre-baked CI builder from Scaleway CR
# Image pre-exists in SCR; rebuild via build-ci-builder when Dockerfile changes

View File

@@ -40,6 +40,7 @@ devpod provider set kubernetes \
DISK_SIZE=10Gi \
STORAGE_CLASS=scw-bssd \
INACTIVITY_TIMEOUT=30m \
IMAGE_PULL_SECRETS=gitlab-registry \
POD_MANIFEST_TEMPLATE=.devcontainer/pod-template.yaml
# Configure image pull secrets if not already present