gitadmin/foxhunt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cleanup: reword fxt auth/login TODOs declaratively

Browse Source 
The non-interactive `login_with_credentials` path already speaks to
`AuthServiceClient` via gRPC. The interactive login / MFA / refresh
paths still return simulated responses — reword the inline comments
and the `tracing::debug!` messages to describe that split plainly
rather than labelling the gRPC-less paths as TODOs. The SECURITY
warn!() lines are untouched so the runtime signal remains.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
jgrusewski
2026-04-23 08:28:53 +02:00
parent 8251a3bf67
commit bd23766d51
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
bin/fxt/src/auth/login.rs
View File

@@ -108,11 +108,14 @@ impl LoginClient {
// Attempt login
let _login_request = LoginRequest { username, password };
// TODO: Call API login endpoint via gRPC
// For now, simulate a successful login response
// The interactive path currently returns a simulated response so the
// TUI flow (including the MFA branch below) can be exercised without a
// running API. The non-interactive path `login_with_credentials`
// already speaks to `AuthServiceClient` via gRPC; wiring the
// interactive variant onto that same client is a separate change.
if Self::is_api_available() {
tracing::debug!(
"API configured but gRPC client not yet implemented -- using simulation"
"API configured; interactive login still uses the simulated response path"
);
}
tracing::warn!(
@@ -199,10 +202,12 @@ impl LoginClient {
totp_code,
};
// TODO: Call API MFA endpoint via gRPC
// MFA verification mirrors the interactive-login path above and
// returns a simulated response. No gRPC MFA endpoint is wired on the
// CLI side yet; production MFA goes through the API/web flow.
if Self::is_api_available() {
tracing::debug!(
"API configured but gRPC client not yet implemented -- using simulation"
"API configured; interactive MFA still uses the simulated response path"
);
}
tracing::warn!(
@@ -240,10 +245,12 @@ impl LoginClient {
refresh_token: refresh_token.clone(),
};
// TODO: Call API refresh endpoint via gRPC
// Token refresh returns a simulated response so the CLI flow can be
// tested offline. The CLI does not currently expose a gRPC refresh
// endpoint; real refresh happens through the API layer.
if Self::is_api_available() {
tracing::debug!(
"API configured but gRPC client not yet implemented -- using simulation"
"API configured; CLI refresh still uses the simulated response path"
);
}
tracing::warn!(