gpu_portfolio.rs: deleted CPU simulate_batch() path (GPU path exists),
get_portfolio_state() returns &CudaSlice (was: download to [f32;8])
branching.rs: GPU-native argmax per branch, GPU gather+mean for Q
aggregation, GPU affine+floor for action decomposition, GPU sub→abs→
max for weight comparison in tests
gpu_tensor.rs: added pub cuda_data() accessor
stream_ops.rs: fixed CudaView type mismatch in dtod_copy
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
apply_static_context() tried gpu_add([1,9,32], [1,1,32]) — shape
mismatch. Static context is time-invariant, must broadcast across
sequence dimension before adding to temporal features.
Both TFT adapter tests now pass. Zero ignored in ensemble adapters.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
test_model_registry_new and test_register_and_retrieve_model no longer
ignored. foxhunt-postgres docker container available locally.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
test_optimization_rosenbrock and test_optimization_deterministic were
marked #[ignore] with no valid reason. They complete in <50ms.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Removed #[ignore] from tests that have local infrastructure:
- 3 data_loader tests: auto-detect test_data/real/databento/ via workspace
- 3 memory_profiler tests: nvidia-smi at /usr/bin/nvidia-smi
- 4 benchmark tests (TFT, Mamba2, DQN, PPO): GPU + DBN data available
- 1 inference test: model loading (slow but should run)
- 3 DQN performance smoke tests: GPU available
PPO benchmark: fixed data_path to test_data/real/databento/6E.FUT
Sequential: added vars_mut() accessor
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PpoExperienceBatch: all 6 fields Vec<T>→CudaSlice<T>. Data stays on GPU
from kernel collection through training. Zero DtoH for batch data.
- collect_experiences(): returns CudaSlice via D2D copy, no memcpy_dtoh
- gpu_batch_to_trajectory_batch(): DELETED (was CPU conversion)
- PPO::update_gpu(): reads states via D2D mini-batch, forward on GPU
- compute_metrics_from_gpu(): downloads only scalars (returns/advantages/
actions), NOT the 123 MB state tensor
- download_*() methods for debug/checkpoint only
States (123 MB/epoch) never leave GPU. Only 2 scalar losses come to CPU.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deleted ExperienceBatch (CPU Vec<f32>) struct and collect_experiences()
method (120 lines of memcpy_dtoh + CPU next_state computation).
Production DQN training already uses collect_experiences_gpu() which
returns GpuExperienceBatch (CudaSlice, zero CPU download).
Tests rewritten as pure index-math validation without GPU types.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New ml-core/cuda_autograd/reductions.rs:
- fused_stats_reduce: min/max/sum/sum_sq/count in single pass with
warp-level __shfl_down_sync + atomicCAS (20 bytes DtoH)
- argmax_flat: single u32 result (4 bytes DtoH)
- argmax_rows: per-row argmax for 2D data
- sum_reduce: standard tree reduction
- col_sum_reduce: per-column sum along rows
DQN trainer integration:
- collect_qvalue_statistics: 4 DtoH → 1 (single stats() call)
- compute_q_diagnostics_fused: replaces Candle sort/narrow pipeline
with argmax_rows + stats + col_sums (3 kernels, 3 readbacks)
- ReductionKernels lazy-initialized in training loop
All kernels compiled via compile_ptx_for_device (native cubin + disk cache).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Experience collector: PinnedHostBuf<T> via cuMemHostAlloc(PORTABLE) for
6 DtoH buffers — ~25-30% faster transfers vs pageable memory.
NVRTC caching: 4 OnceLock additions in ml-ppo cuda_nn:
- softmax.rs: was re-compiling NVRTC on EVERY forward pass batch (!)
- linear.rs, lstm.rs: cached for multi-layer construction
Device attribute: OnceLock<u32> for max_threads in gpu_replay_buffer
pfx_sum — eliminates ~5µs driver query per call.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
reset_episodes() was allocating 5 CPU Vecs per epoch for HtoD zero-fill.
Replaced with:
- memset_zeros() for barrier/diversity buffers (async GPU-side, no HtoD)
- Pre-allocated host staging vectors for portfolio_init and RNG seeds
gpu_curiosity_trainer already optimized (fused kernel zeros internally).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Final cleanup:
- 61 test files + 5 example files: candle imports replaced
- 8 testing/integration files: migrated to cudarc/ml-core types
- 3 services/trading_service test files: migrated
- Root Cargo.toml: candle-core, candle-nn removed from [workspace.dependencies]
- crates/ml/Cargo.toml: candle-nn dependency removed
- testing/e2e/Cargo.toml: candle-core dependency removed
Zero active candle_core/candle_nn/candle_optimisers code references remain.
Zero candle dependency declarations in any Cargo.toml.
Remaining "candle" strings are exclusively in doc comments.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add CudaSlice<f32> accessor methods to GpuTrainResult and GradientResult
(loss_cuda_slice, grad_norm_cuda_slice) in ml-dqn, eliminating redundant
tensor_to_cuda_slice_f32 calls at every training guard check site.
- GpuTrainResult: add from_fused_scalars() constructor and CudaSlice extractors
- GradientResult: add CudaSlice extractors that delegate to GpuTrainResult
- fused_training.rs: use from_fused_scalars() instead of Tensor::new() wrapping
- train_step.rs: use result.loss_cuda_slice() instead of tensor_to_cuda_slice_f32
- training_loop.rs: same CudaSlice accessor pattern for both fused and accum paths
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- gpu_weights.rs: Remove slow-path Candle fallback (flatten/cast/contiguous)
from extract_one() and sync_one(). F32-contiguous is now a hard requirement
enforced by ensure_f32_contiguous() at network construction. Non-F32 or
non-contiguous tensors produce a clear error instead of silently falling
back to the Candle conversion pipeline.
- gpu_action_selector.rs: Remove unused ensure_contiguous_f32(). Keep
stream_from_device/cuda_u32_to_tensor/cuda_f32_to_tensor as boundary
converters (they have external callers).
- gpu_experience_collector.rs: Clean up doc comments referencing Candle
where only cudarc CudaSlice is used.
- mod.rs: Update module docs to clarify Candle Tensor/Device are only
at the upload boundary (DqnGpuData, PpoGpuData, tensor_to_cuda_slice).
- tlob/trainable_adapter.rs: Fix double candle_core:: path that broke build.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace deprecated cudarc memcpy_stod with clone_htod across all GPU
upload paths (14 call sites in trainers, cuda_pipeline, hyperopt).
Replace deprecated memcpy_dtov with clone_dtoh in ml-supervised
gpu_tensor.rs.
Bridge GpuTensor-migrated submodules (xLSTM, Liquid CfC, TFT GRN)
with Candle Tensor callers via from_candle_tensor/to_candle_tensor
conversion utilities at API boundaries. Fix CudaDevice->CudaContext
in ml-dqn distributional_dueling.rs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Eliminate candle-core/candle-nn from the KAN and Diffusion model forward
paths in ml-supervised. All dense layers now use cuBLAS sgemm via the new
gpu_tensor module. Element-wise ops (SiLU, sigmoid, tanh, exp) use host
roundtrips for now; fused CUDA kernels are a follow-up.
Changes:
- Add gpu_tensor.rs: GpuTensor (CudaSlice<f32> + shape), GpuLinear
(cuBLAS sgemm), and ~30 element-wise GPU ops
- Rewrite kan/{spline,layer,network}.rs to use GpuTensor instead of
candle_core::Tensor and candle_nn::{VarBuilder,Linear}
- Rewrite diffusion/{denoiser,noise,sampler}.rs to use GpuTensor and
GpuLinear instead of candle_nn::Linear
- Update ml crate trainable adapters (kan/trainable.rs,
diffusion/trainable.rs) to bridge Candle<->GpuTensor at the
UnifiedTrainable interface boundary
- Update ensemble inference adapters for both models
- Add cudarc 0.17 with cublas feature to ml-supervised Cargo.toml
- Candle deps retained in ml-supervised for unconverted models (TFT,
Liquid, Mamba, xLSTM) -- will be removed once all 8 models are
converted
Net: -424 lines, 509 -> ~453 Candle refs remaining (KAN: 0, Diffusion: 0)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add dqn_forward_only_kernel to dqn_training_kernel.cu — runs a single
branching forward pass (shared layers -> value head -> 3 branch heads ->
C51 distributional -> expected Q) and writes per-branch Q-values to
q_out[B, 11]. No loss computation, no activation saves, no backward.
~3x faster than forward_loss for pure inference.
Wire the kernel into GpuDqnTrainer via forward_only_q() which takes
CudaSlice<f32> states directly and returns &CudaSlice<f32> Q-values,
replacing the Candle BranchingDuelingQNetwork::forward_branches() call
chain (~160 Candle kernel dispatches -> 1 fused CUDA launch).
Mark all 6 ml-dqn Candle forward methods as #[cold] with documentation
that hot-path compute is handled by fused CUDA kernels:
- noisy_layers.rs: NoisyLinear::forward() -> dqn_experience_kernel.cu
- quantile_regression.rs: QuantileNetwork::forward() -> iqn_dual_head_kernel.cu
- distributional.rs: CategoricalDistribution::to_scalar() -> dqn_forward_only_kernel
- curiosity.rs: ForwardDynamicsModel::predict() -> curiosity_training_kernel.cu
- residual.rs: ResidualBlock::forward() -> dqn_forward_only_kernel
- rmsnorm.rs: RMSNorm::forward() / LayerNorm::forward() -> dqn_experience_kernel.cu
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update all callers to match the new pure-cudarc APIs introduced by the
hive agent CudaSlice migration. Key changes:
- GpuTrainingGuard::new() now takes Arc<CudaStream>; callers use from_device()
- check_and_accumulate/qvalue_stats/qvalue_divergence take &CudaSlice<f32>
instead of &Tensor; callers convert via tensor_to_cuda_slice_f32()
- accumulate_q_value takes f32 scalar, returns () (no Result)
- GpuReplayBuffer::insert_batch gains batch_size arg, takes CudaSlice params
- signal_adapter functions take &Arc<CudaStream> (cudarc 0.17 Arc requirement)
- Add tensor_to_cuda_slice_u32() and cuda_f32_to_tensor() utility functions
- Replace CudaView usage with owned CudaSlice via tensor_to_cuda_slice_f32()
- Fix CudaStorage.device field access (was method call in older API)
- Fix borrow-after-move in copy_actions_out via scoped DtoD copy
Zero errors, zero warnings across lib + tests + examples + full workspace.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BranchingDuelingQNetwork now converts all weight tensors to F32 contiguous
at construction via ensure_f32_contiguous(). This guarantees the invariant
that extract_one/sync_one/reverse_sync_one in gpu_weights.rs can bypass
the flatten_all().to_dtype(F32).contiguous() Candle pipeline and do a
single direct DtoD memcpy from the Var's CUDA storage.
Key changes:
- branching.rs: add ensure_f32_contiguous() + ensure_f32() for NoisyLinear
sigma/epsilon, forward_branches casts to F32 instead of BF16
- noisy_layers.rs: sample_noise/reset_noise/disable_noise use weight_mu
dtype (F32 after ensure_f32) instead of hardcoded BF16, add ensure_f32()
to convert sigma vars and epsilon buffers
- gpu_weights.rs: extract_one/sync_one fast path skips Candle ops when
tensor is already F32 contiguous, reverse_sync_one fixed to access Var's
own CUDA storage directly (was writing to a temporary F32 tensor before)
- fused_training.rs: updated doc comments for CudaSlice-as-source-of-truth
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Eliminate ALL Candle Tensor usage from gpu_experience_collector.rs to fix
cross-stream deadlocks. The old code created Candle Tensors on the forked
CudaStream, which conflicted with Candle's default stream (stream 0) used
by GpuReplayBuffer::insert_batch.
Changes to gpu_experience_collector.rs:
- GpuExperienceBatch now holds CudaSlice<f32>/CudaSlice<i32> instead of Tensor
- Remove cuda_slice_to_tensor_f32() and cuda_slice_i32_to_tensor_u32() helpers
- Add dtod_clone_f32(), dtod_clone_i32() pure-cudarc DtoD copy helpers
- Add build_next_states_dtod() for episode-aware state shift via pointer math
- Remove device: &Device parameter from collect_experiences_gpu()
- Remove candle_core::{DType, Device, Tensor} import entirely
Changes to training_loop.rs:
- Move CudaSlice->Tensor conversion to training_loop boundary (post stream-sync)
- Add cuda_slice_to_tensor_f32() and cuda_slice_i32_to_tensor_u32() at boundary
- Conversions happen AFTER stream.synchronize(), on the synced stream -- no
cross-stream hazard
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
action.rs:
- Replace Tensor-based selector calls with CudaSlice extraction via
extract_cuda_f32! macro + ensure_contiguous_f32() helper
- Constructor now passes Arc<CudaStream> via stream_from_device()
- Replace per-element narrow+squeeze+to_scalar readback with bulk
readback_actions() DtoH memcpy (single transfer vs N scalar reads)
- select_actions_branching() now takes explicit batch_size parameter
metrics.rs:
- Same CudaSlice extraction pattern for validation action selection
- Wrap CudaSlice<u32> result back to Candle Tensor via cuda_u32_to_tensor()
for downstream GPU PnL/Sharpe computation that needs Tensor ops
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Eliminate all 26 Candle Tensor references from signal_adapter.rs.
Three functions (ppo_to_exposure_scores, signal_to_action_scores,
tft_quantile_to_signal) now take CudaSlice<f32> + CudaStream and
return CudaSlice<f32>, backed by three fused CUDA kernels in
signal_adapter_kernel.cu. Dead code evaluate_supervised_gpu_backtest
removed (zero callers). Added cuda_f32_to_tensor helper to
gpu_action_selector for DtoD copy back to Candle Tensor at API
boundaries (PPO hyperopt adapter, evaluate_baseline example).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GpuReplayBuffer uses Candle Tensor ops (slice_scatter, cumsum, narrow)
which execute on Candle's default stream (stream 0). The experience
collector outputs data on a forked CudaStream. Without an explicit
synchronization barrier, the default stream may read partially-written
data from the forked stream, causing cross-stream deadlocks or data
corruption.
Add stream.synchronize() in three places:
- training_loop.rs: after experience collection, before insert_batch_tensors
- gpu_experience_collector.rs: cuda_slice_to_tensor_f32 after DtoD copy
- gpu_experience_collector.rs: cuda_slice_i32_to_tensor_u32 after DtoD copy
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
With unified forked stream, cudarc event tracking is self-referencing
(no cross-stream conflicts). disable_event_tracking caused more
problems than it solved — stale events, Drop failures, hangs.
Let cudarc manage events naturally on the single stream.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Moving disable_event_tracking() from GpuDqnTrainer::new() to the
stream fork in constructor.rs ensures ALL CudaSlice allocations
(experience collector, replay buffer, curiosity trainer) are created
with tracking already disabled. Previous placement caused hangs because
earlier allocations had stale events.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- upload_batch_gpu: BF16→F32 via CUDA kernel, no Candle to_dtype()
- IQL: reuses DQN trainer's F32 buffers via train_value_step_raw()
- Re-enable disable_event_tracking() — safe with unified stream
- Reduce smoke test epochs to 1 (debug mode is too slow for 3)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace all Candle tensor operations in the fused training loop with
pure cudarc CudaSlice operations to prevent Candle tensor Drops from
recording events on the default stream (which conflicts with our forked
training stream via cudarc event tracking).
Key changes:
- Re-enable disable_event_tracking() in GpuDqnTrainer::new() — safe now
that no Candle tensors are created during training
- Rewrite upload_batch_gpu(): BF16 states/next_states use DtoD + bf16→f32
kernel instead of Candle to_dtype(F32); F32 rewards/dones/weights use
direct DtoD copy with layout offset handling
- Load bf16_to_f32_kernel from training module (was defined in CUH but
not loaded)
- Add train_value_step_raw() to GpuIqlTrainer that takes CudaSlice<f32>
directly, bypassing Candle tensor manipulation
- IQL in fused training now reuses DQN trainer's already-converted F32
states_buf/rewards_buf instead of creating Candle temporaries
- Fix dtod_from_candle_f32/u32 to respect Candle layout start_offset
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fork a dedicated CudaStream once in DQNTrainer constructor and share it
via Arc::clone with all GPU components (experience collector, fused
trainer, portfolio sim, monitoring). This eliminates:
1. Candle's default stream (stream 0) from the training hot path
2. Dual-stream cudarc event tracking conflicts during CUDA Graph capture
3. Implicit serialization points between default and forked streams
The fused training context no longer forks its own stream — it receives
the trainer's unified stream. With all GPU work on a single stream,
cudarc event tracking is safely disabled in GpuDqnTrainer::new(),
removing the cuStreamWaitEvent/cuEventRecord overhead that broke CUDA
Graph capture.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The fused DQN trainer uses a forked stream (for CUDA Graph capture)
while the experience collector + curiosity trainer use Candle's
default stream (stream 0). cudarc's context-wide event tracking
creates conflicts between the two streams.
disable_event_tracking() is context-wide — it fixes the forked
stream but breaks the default stream (curiosity trainer hangs).
Proper fix: create ONE forked stream at DQNTrainer construction,
pass it to ALL GPU components (experience collector, curiosity
trainer, portfolio sim, fused trainer). No Candle default stream
in the hot path.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace 13 per-feature toggle tests with 1 production-config test.
There is no code path without curiosity, IQN, branching, CQL, Kelly,
action masking, circuit breaker — these are always on in production.
smoke_params() now enables everything: Rainbow DQN + branching + IQN +
curiosity + CQL + Kelly + action masking + circuit breaker.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DuelingQNetwork uses advantage_fc.* VarMap keys, but
GpuExperienceCollector expects branch_0_fc.* (branching always on).
Also remove stale use_noisy_nets/use_distributional fields.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI PVC structure is /data/test-data/ohlcv/ES.FUT, local is
test_data/ES.FUT. test_data_dir() now searches both layouts
and checks both FOXHUNT_TEST_DATA and TEST_DATA_DIR env vars.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
