jgrusewski 23b89a90e9 fix(sp21): T2.2 Phase 8.3+9 — eval pipeline GPU-only, hard-fail, delete CPU path (atomic)
Combined Phase 8.3 (visibility + hard-fail) and Phase 9 (CPU path
removal) per pearl_no_deferrals_for_complementary_fixes. Surfaced by
v6 smoke (train-x4m96) where:

  [DQN GPU] Fold 0 GPU eval failed: GpuBacktestEvaluator::evaluate failed
    for fold 0. Falling back to CPU path.
  [DQN] Fold 0 evaluation failed: Failed to create DQN state tensor for
    bar 0: Dimension mismatch: expected 54, got 45

Both fold 0 and fold 1 hit this; workflow exited 0, masking eval
failure for every smoke run since STATE_DIM grew beyond legacy 54.

Root cause (silent GPU failure):
  evaluate_dqn_fold_gpu calls evaluator.evaluate(closure, portfolio_dim: 3)
  but GpuBacktestEvaluator initialises portfolio_dim = PORTFOLIO_BASE_DIM (8)
  + MTF_DIM (16) = 24 per canonical state layout. gather_states asserts
  match → returns MLError::ConfigError. Caller wraps with .with_context()
  + warn!("... {}", e) — `{}` strips anyhow chain, hiding root cause.
  The CPU fallback runs with a separate stale 45-dim state builder
  (42 from extract_ml_features + 3 portfolio) → fails at GpuTensor::
  from_host shape validation against the model's 54-feature default.

Fixes (all atomic):

  1. portfolio_dim: 3 → 24 at all 4 call sites (DQN x2, PPO, supervised).
     The GPU evaluator's gather_kernel handles full 128-dim state
     assembly (Market 42 + OFI 32 + TLOB 16 + MTF 16 + Portfolio 8 +
     PlanISV 7 + Padding 7); caller just declares correct portfolio_dim.

  2. Surface anyhow chain: {} → {:#} in error messages.

  3. Hard-fail on GPU eval failure: anyhow::bail! (no CPU fallback).
     Per user directive: "hard fail on gpu panic, cpu path strictly
     forbidden should be removed entirely!"

  4. DELETE CPU DQN eval path entirely:
     - fn evaluate_dqn_fold
     - fn build_chunk_states (stale 45-dim state builder)
     - fn simulate_chunk_trades
     - fn compute_metrics + struct ComputedMetrics
     - struct PortfolioState

  5. DELETE coupled surrogate-noise machinery:
     - struct SurrogateSampler + impl
     - fn load_surrogate_marginals
     - fn compute_pooled_sharpe
     - Surrogate init blocks in main
     - ACTION_MARGINALS / POOLED_SHARPE emission blocks

  6. DELETE coupled CLI flags:
     - --gpu-eval / --no-gpu-eval (GPU mandatory)
     - --surrogate-mode, --surrogate-seed, --surrogate-marginals
     - --emit-action-marginals, --emit-pooled-sharpe

  7. Collapse `if args.gpu_eval { ... }` blocks to direct calls; cleaner
     control flow, no gpu_handled tracking.

Pearls honoured:
  - feedback_no_cpu_test_fallbacks: GPU oracle only
  - feedback_no_partial_refactor: stale CPU layout from pre-STATE_DIM=128 era
  - feedback_no_hiding: error chain now visible via {:#}
  - feedback_no_legacy_aliases: no deprecated --no-gpu-eval wrapper
  - pearl_no_deferrals_for_complementary_fixes: 8.3+9 combined

Files changed:
  - crates/ml/examples/evaluate_baseline.rs:
      −892 net lines (1066 del, 174 ins; 2817 → 1925)
  - docs/dqn-wire-up-audit.md: 2026-05-12 audit entry

Verification:
  - cargo check -p ml --example evaluate_baseline --features cuda  # clean
  - cargo check --workspace --features cuda                        # clean
  - cargo test -p ml --lib --features cuda financials              # 7/7

Note: OFI/TLOB/MTF feature-set fidelity is a separate concern. The GPU
gather_kernel handles state assembly; caller currently provides zeroed
OFI (LobBar.ofi = 0.0) and no MTF data. Eval will run, but on degraded
features. Faithful feature wiring deferred to a later Phase once
eval-runs-at-all is validated by v7 smoke.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 08:47:05 +02:00

Foxhunt

Production HFT trading system in Rust.

Architecture

The workspace contains 32 crates organized as follows:

Core Libraries (16)

Crate Purpose
trading_engine Order processing, FIX 4.4, IB TWS, SIMD, RDTSC timing
risk VaR, Kelly, circuit breakers, kill switches, compliance
risk-data Risk data types and shared structures
trading-data Trading data types
ml DQN Rainbow, PPO, TFT, Mamba2, ensemble inference
ml-data ML data types and feature definitions
data Market data ingestion and storage
backtesting Replay engine, strategy tester
adaptive-strategy Ensemble execution, microstructure analysis
common Shared types, resilience, error handling
storage S3 and local model storage
model_loader Model serialization and loading
market-data Market data feed handlers
database PostgreSQL access layer (SQLx)
config Configuration management
tli CLI commands and tooling

Services (8)

Service Purpose
backtesting_service gRPC backtesting service
broker_gateway_service FIX routing, broker connectivity
trading_service Core trading operations
ml_training_service Model training orchestration
data_acquisition_service Market data acquisition
trading_agent_service Autonomous trading agents
api_gateway gRPC API gateway with auth
web-gateway Axum REST + WebSocket gateway

Frontend

web-dashboard/ -- React 19 + TypeScript + Vite + TradingView charts.

Building

# Check compilation (no PostgreSQL required)
SQLX_OFFLINE=true cargo check --workspace

# Run tests for a specific crate
SQLX_OFFLINE=true cargo test -p <crate> --lib

# Clippy
SQLX_OFFLINE=true cargo clippy --workspace

ML Models

Four production model architectures on Candle v0.9.1 with CUDA:

  • DQN Rainbow -- Deep Q-Network with prioritized replay, dueling heads, noisy nets
  • PPO -- Proximal Policy Optimization with GAE and LSTM policies
  • TFT -- Temporal Fusion Transformer for multi-horizon forecasting
  • Mamba2 -- State space model for sequence prediction

Each model has a standalone trainer and a UnifiedTrainable adapter for the hyperopt pipeline.

Infrastructure

  • Git: Gitea at git.fxhnt.ai (Tailscale-only), Scaleway DEV1-S
  • Observability: OpenTelemetry OTLP (env OTEL_EXPORTER_OTLP_ENDPOINT)
  • Database: PostgreSQL with SQLx offline mode for CI

License

Proprietary. All rights reserved.

Description
No description provided
Readme 849 MiB
Languages
Rust 88.2%
Cuda 7.7%
Python 1.3%
Shell 1.1%
PLpgSQL 0.8%
Other 0.8%