foxhunt/AGENT_159_VALIDATION_CHECKLIST.md

# Agent 159: Validation Checklist for Group E

**Purpose**: Quick reference for Group E compilation agent to validate Agent 159's fixes

---

## Code Changes Verification

### ✅ Change 1: `get_top_models_24h` Query

**File**: `/home/jgrusewski/Work/foxhunt/services/trading_service/src/ensemble_audit_logger.rs`
**Lines**: 527-541

**Struct Definition** (Lines 583-590):
```rust
pub struct ModelPerformanceSummary {
    pub model_id: String,          // ✅ Column 1
    pub total_predictions: i32,     // ✅ Column 2
    pub accuracy: f64,              // ✅ Column 3
    pub sharpe_ratio: Option<f64>,  // ✅ Column 4
    pub total_pnl: i64,             // ✅ Column 5
    pub avg_weight: f64,            // ✅ Column 6
}
```

**Query Columns** (Lines 530-536):
```sql
SELECT
    model_id,           -- ✅ Matches field 1
    total_predictions,  -- ✅ Matches field 2
    accuracy,           -- ✅ Matches field 3
    sharpe_ratio,       -- ✅ Matches field 4
    total_pnl,          -- ✅ Matches field 5
    avg_weight          -- ✅ Matches field 6
FROM get_top_models_24h($1, $2)
```

**Validation**: ✅ **6/6 columns match struct fields exactly**

---

### ✅ Change 2: `get_high_disagreement_events_24h` Query

**File**: `/home/jgrusewski/Work/foxhunt/services/trading_service/src/ensemble_audit_logger.rs`
**Lines**: 555-573

**Struct Definition** (Lines 594-604):
```rust
pub struct HighDisagreementEvent {
    pub timestamp: chrono::DateTime<chrono::Utc>, // ✅ Column 1
    pub symbol: String,                           // ✅ Column 2
    pub ensemble_action: String,                  // ✅ Column 3
    pub ensemble_confidence: f64,                 // ✅ Column 4
    pub disagreement_rate: f64,                   // ✅ Column 5
    pub dqn_vote: Option<String>,                 // ✅ Column 6
    pub ppo_vote: Option<String>,                 // ✅ Column 7
    pub mamba2_vote: Option<String>,              // ✅ Column 8
    pub tft_vote: Option<String>,                 // ✅ Column 9
}
```

**Query Columns** (Lines 558-567):
```sql
SELECT
    timestamp,           -- ✅ Matches field 1
    symbol,              -- ✅ Matches field 2
    ensemble_action,     -- ✅ Matches field 3
    ensemble_confidence, -- ✅ Matches field 4
    disagreement_rate,   -- ✅ Matches field 5
    dqn_vote,            -- ✅ Matches field 6
    ppo_vote,            -- ✅ Matches field 7
    mamba2_vote,         -- ✅ Matches field 8
    tft_vote             -- ✅ Matches field 9
FROM get_high_disagreement_events_24h($1, $2, $3)
```

**Validation**: ✅ **9/9 columns match struct fields exactly**

---

## SQLx Cache Generation Required

### Prerequisites
1. ✅ Code changes applied by Agent 159
2. ⏳ PostgreSQL database running (localhost:5432)
3. ⏳ Database contains PostgreSQL functions:
   - `get_top_models_24h(symbol text, limit integer)`
   - `get_high_disagreement_events_24h(symbol text, threshold double precision, limit integer)`

### Commands for Group E

```bash
# 1. Verify database connectivity
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c "SELECT 1"

# 2. Verify PostgreSQL functions exist
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c "\df get_top_models_24h"
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c "\df get_high_disagreement_events_24h"

# 3. Generate SQLx cache (requires SQLX_OFFLINE=false)
cd /home/jgrusewski/Work/foxhunt
SQLX_OFFLINE=false cargo sqlx prepare --package trading_service

# 4. Verify cache files created
ls -la services/trading_service/.sqlx/*.json | tail -5

# 5. Build with offline mode
SQLX_OFFLINE=true cargo check -p trading_service

# 6. Verify no errors
echo $? # Should be 0 for success
```

---

## Expected Outcomes

### Before Agent 159 Fixes
```
error: `SQLX_OFFLINE=true` but there is no cached data for this query
  --> services/trading_service/src/ensemble_audit_logger.rs:530
   |
   | SELECT * FROM get_top_models_24h($1, $2)
   |

error: `SQLX_OFFLINE=true` but there is no cached data for this query
  --> services/trading_service/src/ensemble_audit_logger.rs:551
   |
   | SELECT * FROM get_high_disagreement_events_24h($1, $2, $3)
   |

Total errors: 4 (including INSERT queries)
```

### After Agent 159 Fixes + SQLx Cache
```bash
cargo check -p trading_service
```
**Expected Output**:
```
Checking trading_service v1.0.0 (/home/jgrusewski/Work/foxhunt/services/trading_service)
Finished `dev` profile [unoptimized + debuginfo] target(s) in X.XXs
```

**Exit Code**: `0` (success)

---

## Rollback Plan (If Issues Found)

### If Column Mismatch Errors
```bash
# Revert changes
git diff services/trading_service/src/ensemble_audit_logger.rs
git checkout -- services/trading_service/src/ensemble_audit_logger.rs

# Report to Agent 159 for correction
```

### If PostgreSQL Functions Missing
```bash
# Check migration status
cargo sqlx migrate run

# Or manually create functions (if not in migrations)
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt < migrations/XXX_create_analytics_functions.sql
```

### If Database Unavailable
```bash
# Start PostgreSQL container
docker-compose up -d postgres

# Wait for healthy status
docker-compose ps postgres
```

---

## Success Criteria

✅ **All criteria must pass**:

1. ✅ Code changes applied (Agent 159 complete)
2. ⏳ SQLx cache generated (`cargo sqlx prepare` succeeds)
3. ⏳ Compilation succeeds (`cargo check -p trading_service` exit 0)
4. ⏳ No type mismatch errors (struct fields match query columns)
5. ⏳ Integration tests pass (if applicable)

---

## Error Resolution Guide

### Error: "function get_top_models_24h does not exist"
**Solution**: Run database migrations
```bash
cargo sqlx migrate run
```

### Error: "column count mismatch"
**Solution**: Verify struct matches query (see validation sections above)

### Error: "type mismatch for column X"
**Solution**: Check PostgreSQL function return type vs Rust struct type
```bash
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c "\df+ get_top_models_24h"
```

---

## Files Modified by Agent 159

1. `/home/jgrusewski/Work/foxhunt/services/trading_service/src/ensemble_audit_logger.rs`
   - Lines 527-541: `get_top_models_24h` query (SELECT * → explicit columns)
   - Lines 555-573: `get_high_disagreement_events_24h` query (SELECT * → explicit columns)
   - Net change: +12 lines, -2 lines

2. `/home/jgrusewski/Work/foxhunt/AGENT_159_SUMMARY.md`
   - Full investigation report (379 lines)

3. `/home/jgrusewski/Work/foxhunt/AGENT_159_VALIDATION_CHECKLIST.md`
   - This file (quick reference for Group E)

---

## Contact

**Agent**: 159
**Date**: 2025-10-15
**Status**: ✅ Code changes applied, awaiting SQLx cache generation

**For Questions**: Refer to `/home/jgrusewski/Work/foxhunt/AGENT_159_SUMMARY.md` (full report)