foxhunt/docs/WAVE92_QUICK_WINS_PLAN.md

# 🎯 WAVE 92: QUICK WINS SPRINT - EXECUTION PLAN

**Mission**: Eliminate final 25 compilation errors
**Timeline**: 2-4 hours (single wave)
**Confidence**: HIGH (all errors are trivial fixes)

---

## 📋 AGENT ASSIGNMENTS

### Agent 1: ExecutionResult Field Rename (4 errors) ⚡ TRIVIAL
**File**: `services/trading_service/src/core/broker_routing.rs`
**Lines**: 768, 772, 800, 804
**Task**: Rename `executed_price` → `execution_price`

```rust
// BEFORE
result.executed_price

// AFTER
result.execution_price
```

**Command**:
```bash
# Automated fix
cd /home/jgrusewski/Work/foxhunt
sed -i 's/\.executed_price/.execution_price/g' services/trading_service/src/core/broker_routing.rs
cargo check --package trading_service
```

**Expected**: 4 errors eliminated, 21 remaining

---

### Agent 2: Event Type Imports (8 errors) 🔧 LOW
**File**: `tests/fixtures/mod.rs`
**Lines**: Multiple (596, 597, 602, 612, 620, 622, 624, etc.)
**Task**: Add Event/EventType/EventSeverity imports

```rust
// Add to top of file
use common::types::{Event, EventType, EventSeverity};
```

**Command**:
```bash
# Verify imports needed
grep -n "Event\|EventType\|EventSeverity" tests/fixtures/mod.rs | head -20

# Add import after other use statements
# Manual edit or automated insertion
```

**Expected**: 8 errors eliminated, 13 remaining

---

### Agent 3: TradingOrder account_id (1 error) ⚡ TRIVIAL
**File**: `tests/fixtures/test_config.rs`
**Line**: 160
**Task**: Add missing `account_id` field

```rust
// BEFORE
let order = TradingOrder {
    id: "test-001".to_string().into(),
    symbol: "BTCUSD".to_string(),
    // ... other fields
};

// AFTER
let order = TradingOrder {
    id: "test-001".to_string().into(),
    symbol: "BTCUSD".to_string(),
    account_id: None,  // <-- ADD THIS
    // ... other fields
};
```

**Command**:
```bash
# Locate exact line
grep -n "TradingOrder {" tests/fixtures/test_config.rs

# Add field manually or use pattern matching
```

**Expected**: 1 error eliminated, 12 remaining

---

### Agent 4: Missing Dependencies (2 errors) ⚡ TRIVIAL
**Files**: Test `Cargo.toml` files (likely `tests/Cargo.toml` or workspace)
**Task**: Add missing dev-dependencies

```toml
[dev-dependencies]
rust_decimal_macros = "1.33"
rand_distr = "0.4"
```

**Command**:
```bash
# Find which Cargo.toml needs updating
grep -r "rust_decimal_macros\|rand_distr" tests/

# Add to appropriate [dev-dependencies] section
# Likely tests/Cargo.toml or workspace-level
```

**Expected**: 2 errors eliminated, 10 remaining

---

### Agent 5: TLI Imports Cleanup (9 errors) 🔧 MEDIUM
**Files**: `tests/test_runner.rs`, `tests/helpers.rs`, `tests/fixtures/mod.rs`
**Task**: Remove or fix TLI crate imports

**Option A: Remove Unused Imports** (Recommended)
```rust
// Remove these lines if TLI not actually used in tests
use tli::types::TliResult;
use tli::types::Event;
use tli::error::TliError;
```

**Option B: Add TLI Dependency** (If needed)
```toml
# tests/Cargo.toml
[dependencies]
tli = { path = "../tli" }
```

**Command**:
```bash
# Check if TLI types are actually used
grep -A 5 "TliResult\|TliError" tests/test_runner.rs
grep -A 5 "TliResult\|TliError" tests/helpers.rs

# If not used, remove imports
# If used, add dependency
```

**Expected**: 9 errors eliminated, 1 remaining

---

### Agent 6: critical_tests Module (1 error) 🔧 LOW
**Location**: Unknown test file
**Task**: Resolve `critical_tests` module import

```rust
// BEFORE
use critical_tests::...;  // Error: module not found

// AFTER (Option A - Remove if unused)
// (removed)

// AFTER (Option B - Fix path)
use crate::critical_tests::...;
// or
use tests::critical_tests::...;
```

**Command**:
```bash
# Find the problematic import
grep -r "use.*critical_tests" tests/

# Check if module exists
find tests/ -name "*critical*"

# Either remove import or fix path
```

**Expected**: 1 error eliminated, 0 remaining ✅

---

## 🚀 EXECUTION SEQUENCE

### Phase 1: Trivial Fixes (Agents 1, 3, 4) - 30 minutes
```bash
# Agent 1: ExecutionResult rename
sed -i 's/\.executed_price/.execution_price/g' services/trading_service/src/core/broker_routing.rs

# Agent 3: TradingOrder account_id
# Manual edit of tests/fixtures/test_config.rs:160

# Agent 4: Add dependencies to Cargo.toml
# Manual edit of appropriate Cargo.toml
```

**Checkpoint**: `cargo check --workspace` should show 18 errors (down from 25)

### Phase 2: Import Fixes (Agents 2, 5, 6) - 1-2 hours
```bash
# Agent 2: Event imports
# Add to tests/fixtures/mod.rs

# Agent 5: TLI imports
# Remove or fix TLI imports

# Agent 6: critical_tests
# Remove or fix module import
```

**Checkpoint**: `cargo check --workspace` should show 0 errors ✅

### Phase 3: Validation - 30 minutes
```bash
# Full workspace check
cargo check --workspace --tests

# Run test suite (if time permits)
cargo test --workspace

# Verify no regressions
git diff --stat
```

---

## ✅ SUCCESS CRITERIA

- [ ] 0 compilation errors in `cargo check --workspace --tests`
- [ ] All 6 agents report completion
- [ ] No new errors introduced
- [ ] Git diff shows only targeted fixes
- [ ] Optional: Test suite passes (cargo test)

---

## 📊 EXPECTED TIMELINE

```
00:00 - Agent kickoff, assign tasks
00:30 - Phase 1 complete (7 errors fixed, 18 remaining)
01:30 - Phase 2 complete (18 errors fixed, 0 remaining)
02:00 - Validation complete, Wave 92 SUCCESS ✅
```

**Worst Case**: 4 hours if import issues more complex than expected
**Best Case**: 2 hours if all fixes straightforward

---

## 🎯 WAVE 92 FINAL OUTCOME

```
Wave 91 End:   25 errors
Wave 92 End:    0 errors ✅
Total Cleanup: 260 → 0 errors (100% resolution)
```

**Production Ready**: Full workspace compilation with no errors
**Next Wave**: Integration testing, performance validation, deployment prep

---

*Created: 2025-10-04*
*From: Wave 91 Verification Report*
*Status: Ready for immediate execution*