foxhunt/tli/tests/unit_tests.rs

//! Comprehensive unit tests for TLI system components
//!
//! This module provides extensive unit test coverage for all TLI functionality
//! targeting 95%+ code coverage with focus on critical trading paths.

use std::collections::HashMap;
use std::sync::Arc;
use std::time::{Duration, Instant, SystemTime, UNIX_EPOCH};
use tokio::sync::RwLock;
use uuid::Uuid;

use tli::client::{
    ClientStats, ConnectionConfig, ConnectionManager, MarketDataConfig, MarketDataSnapshot,
    MonitoringConfig, OrderContext, OrderValidationConfig, OrderValidationResult,
    PreTradeCheckResult, RiskManagementConfig, RiskValidationResult, TradingClient,
    TradingClientConfig,
};
use tli::prelude::*;
// Database imports removed - TLI is pure client
use tli::error::{TliError, TliResult};
use tli::types::*;

// Mock and test utilities
use fake::{Fake, Faker};
use mockall::mock;
use mockall::predicate::*;
use proptest::prelude::*;
use tempfile::TempDir;
use tracing_test::traced_test;

#[cfg(test)]
mod trading_client_tests {
    use super::*;

    /// Test trading client configuration validation
    #[test]
    fn test_trading_client_config_validation() {
        let config = TradingClientConfig {
            service_name: "test_service".to_string(),
            request_timeout: Duration::from_millis(5000),
            order_validation: OrderValidationConfig {
                enable_pre_validation: true,
                max_order_size: 100_000.0,
                min_order_size: 1.0,
                validate_symbols: true,
                validate_market_hours: false,
            },
            risk_management: RiskManagementConfig {
                enable_risk_monitoring: true,
                max_position_exposure: 50_000.0,
                var_confidence_level: 0.99,
                alert_thresholds: Default::default(),
                enable_position_limits: true,
            },
            market_data: MarketDataConfig::default(),
            monitoring: MonitoringConfig::default(),
            event_streaming: Default::default(),
        };

        assert_eq!(config.service_name, "test_service");
        assert_eq!(config.request_timeout, Duration::from_millis(5000));
        assert!(config.order_validation.enable_pre_validation);
        assert_eq!(config.order_validation.max_order_size, 100_000.0);
        assert_eq!(config.risk_management.var_confidence_level, 0.99);
    }

    /// Test order validation logic
    #[tokio::test]
    async fn test_order_validation_basic() {
        let connection_config = ConnectionConfig::default();
        let connection_manager = Arc::new(ConnectionManager::new(connection_config));
        let config = TradingClientConfig::default();
        let client = TradingClient::new(connection_manager, config.clone());

        // Test validation with valid order
        let valid_request = SubmitOrderRequest {
            symbol: "AAPL".to_string(),
            side: OrderSide::Buy as i32,
            order_type: OrderType::Market as i32,
            quantity: 100.0,
            client_order_id: Uuid::new_v4().to_string(),
            ..Default::default()
        };

        // This is a private method, so we test indirectly through submit_order
        // The validation would happen internally
        assert!(valid_request.quantity >= config.order_validation.min_order_size);
        assert!(valid_request.quantity <= config.order_validation.max_order_size);
        assert!(!valid_request.symbol.is_empty());
    }

    /// Test order context management
    #[tokio::test]
    async fn test_order_context_tracking() {
        let connection_config = ConnectionConfig::default();
        let connection_manager = Arc::new(ConnectionManager::new(connection_config));
        let config = TradingClientConfig::default();
        let client = TradingClient::new(connection_manager, config);

        let client_order_id = Uuid::new_v4().to_string();
        let context = OrderContext {
            client_order_id: client_order_id.clone(),
            server_order_id: Some("server_123".to_string()),
            created_at: Instant::now(),
            status: OrderStatus::New,
            validation_result: Some(OrderValidationResult {
                valid: true,
                messages: vec!["Order validated".to_string()],
                validated_at: Instant::now(),
            }),
            risk_validation: None,
        };

        // Test that we can retrieve order contexts
        let contexts = client.get_order_contexts().await;
        assert!(contexts.is_empty()); // Initially empty

        // In a real implementation, contexts would be added during order submission
    }

    /// Test client statistics tracking
    #[tokio::test]
    async fn test_client_statistics() {
        let connection_config = ConnectionConfig::default();
        let connection_manager = Arc::new(ConnectionManager::new(connection_config));
        let config = TradingClientConfig::default();
        let client = TradingClient::new(connection_manager, config);

        let stats = client.get_stats().await;

        // Initial state
        assert_eq!(stats.orders_submitted, 0);
        assert_eq!(stats.orders_filled, 0);
        assert_eq!(stats.orders_cancelled, 0);
        assert_eq!(stats.orders_rejected, 0);
        assert_eq!(stats.api_calls, 0);
        assert_eq!(stats.api_errors, 0);
        assert!(stats.last_connected.is_none());
    }

    /// Test connection state management
    #[tokio::test]
    async fn test_connection_management() {
        let connection_config = ConnectionConfig::default();
        let connection_manager = Arc::new(ConnectionManager::new(connection_config));
        let config = TradingClientConfig::default();
        let client = TradingClient::new(connection_manager, config);

        // Initially not connected
        assert!(!client.is_connected().await);

        // Test shutdown when not connected
        client.shutdown().await;
        assert!(!client.is_connected().await);
    }

    /// Test risk validation result processing
    #[test]
    fn test_risk_validation_result() {
        let violations = vec![RiskViolation {
            violation_type: "POSITION_LIMIT".to_string(),
            message: "Position would exceed limit".to_string(),
            severity: "HIGH".to_string(),
            current_value: 150_000.0,
            limit_value: 100_000.0,
        }];

        let result = RiskValidationResult {
            approved: false,
            violations: violations.clone(),
            projected_exposure: 150_000.0,
            margin_impact: 50_000.0,
        };

        assert!(!result.approved);
        assert_eq!(result.violations.len(), 1);
        assert_eq!(result.violations[0].violation_type, "POSITION_LIMIT");
        assert_eq!(result.projected_exposure, 150_000.0);
        assert_eq!(result.margin_impact, 50_000.0);
    }

    /// Test market data snapshot processing
    #[test]
    fn test_market_data_snapshot() {
        let snapshot = MarketDataSnapshot {
            symbol: "AAPL".to_string(),
            last_price: Some(150.25),
            bid_price: Some(150.20),
            ask_price: Some(150.30),
            bid_size: Some(100),
            ask_size: Some(200),
            volume: Some(10_000_000),
            timestamp: Instant::now(),
        };

        assert_eq!(snapshot.symbol, "AAPL");
        assert_eq!(snapshot.last_price.unwrap(), 150.25);
        assert_eq!(snapshot.bid_price.unwrap(), 150.20);
        assert_eq!(snapshot.ask_price.unwrap(), 150.30);

        // Test spread calculation
        let spread = snapshot.ask_price.unwrap() - snapshot.bid_price.unwrap();
        assert_eq!(spread, 0.10);
    }

    /// Test pre-trade check result aggregation
    #[test]
    fn test_pre_trade_check_result() {
        let validation = OrderValidationResult {
            valid: true,
            messages: vec!["Size valid".to_string(), "Symbol valid".to_string()],
            validated_at: Instant::now(),
        };

        let risk_check = RiskValidationResult {
            approved: true,
            violations: vec![],
            projected_exposure: 75_000.0,
            margin_impact: 25_000.0,
        };

        let market_data = MarketDataSnapshot {
            symbol: "AAPL".to_string(),
            last_price: Some(150.00),
            bid_price: Some(149.95),
            ask_price: Some(150.05),
            bid_size: Some(500),
            ask_size: Some(300),
            volume: Some(5_000_000),
            timestamp: Instant::now(),
        };

        let pre_check = PreTradeCheckResult {
            approved: validation.valid && risk_check.approved,
            validation,
            risk_check,
            market_data: Some(market_data),
        };

        assert!(pre_check.approved);
        assert!(pre_check.validation.valid);
        assert!(pre_check.risk_check.approved);
        assert!(pre_check.market_data.is_some());
    }
}

#[cfg(test)]
// Database tests removed - TLI is pure client
/*
mod database_tests {
    use super::*;

    /// Test SQLite configuration manager
    #[tokio::test]
    async fn test_sqlite_config_manager() {
        let temp_dir = TempDir::new().expect("Failed to create temp directory");
        let db_path = temp_dir.path().join("test_config.db");

        // Create config manager
        let config_manager = ConfigManager::new(&db_path.to_string_lossy()).await;
        assert!(config_manager.is_ok());

        let manager = config_manager.unwrap();

        // Test configuration storage and retrieval
        let test_config = HashMap::from([
            ("max_position_size".to_string(), "100000".to_string()),
            ("var_confidence".to_string(), "0.95".to_string()),
            ("enable_risk_monitoring".to_string(), "true".to_string()),
        ]);

        // Store configuration
        for (key, value) in &test_config {
            let result = manager.set_config(key.clone(), value.clone()).await;
            assert!(result.is_ok());
        }

        // Retrieve and verify configuration
        for (key, expected_value) in &test_config {
            let result = manager.get_config(key).await;
            assert!(result.is_ok());
            assert_eq!(result.unwrap().as_deref(), Some(expected_value.as_str()));
        }

        // Test non-existent key
        let result = manager.get_config("non_existent_key").await;
        assert!(result.is_ok());
        assert!(result.unwrap().is_none());
    }

    /// Test configuration hot-reload functionality
    #[tokio::test]
    async fn test_config_hot_reload() {
        let temp_dir = TempDir::new().expect("Failed to create temp directory");
        let db_path = temp_dir.path().join("test_hot_reload.db");

        let config_manager = ConfigManager::new(&db_path.to_string_lossy())
            .await
            .unwrap();

        // Set initial configuration
        config_manager
            .set_config("test_param".to_string(), "initial_value".to_string())
            .await
            .unwrap();

        // Verify initial value
        let initial = config_manager.get_config("test_param").await.unwrap();
        assert_eq!(initial.as_deref(), Some("initial_value"));

        // Update configuration (simulating hot reload)
        config_manager
            .set_config("test_param".to_string(), "updated_value".to_string())
            .await
            .unwrap();

        // Verify updated value
        let updated = config_manager.get_config("test_param").await.unwrap();
        assert_eq!(updated.as_deref(), Some("updated_value"));
    }

    /// Test configuration validation
    #[tokio::test]
    async fn test_config_validation() {
        let temp_dir = TempDir::new().expect("Failed to create temp directory");
        let db_path = temp_dir.path().join("test_validation.db");

        let config_manager = ConfigManager::new(&db_path.to_string_lossy())
            .await
            .unwrap();

        // Test valid numeric configuration
        let result = config_manager
            .set_config("max_position_size".to_string(), "100000.50".to_string())
            .await;
        assert!(result.is_ok());

        // Test valid boolean configuration
        let result = config_manager
            .set_config("enable_monitoring".to_string(), "true".to_string())
            .await;
        assert!(result.is_ok());

        // Test empty key (should be rejected)
        let result = config_manager
            .set_config("".to_string(), "value".to_string())
            .await;
        assert!(result.is_err());

        // Test extremely long key (should be rejected)
        let long_key = "a".repeat(1000);
        let result = config_manager
            .set_config(long_key, "value".to_string())
            .await;
        assert!(result.is_err());
    }
}

#[cfg(test)]
mod encryption_tests {
    use super::*;

    /// Test encryption/decryption functionality
    #[test]
    fn test_encryption_decryption() {
        let encryption_manager = EncryptionManager::new();

        let plaintext = "sensitive_trading_data_12345";
        let password = "strong_password_123";

        // Encrypt data
        let encrypted = encryption_manager.encrypt(plaintext.as_bytes(), password);
        assert!(encrypted.is_ok());
        let encrypted_data = encrypted.unwrap();

        // Verify encrypted data is different from plaintext
        assert_ne!(encrypted_data, plaintext.as_bytes());

        // Decrypt data
        let decrypted = encryption_manager.decrypt(&encrypted_data, password);
        assert!(decrypted.is_ok());
        let decrypted_data = decrypted.unwrap();

        // Verify decrypted matches original
        assert_eq!(String::from_utf8(decrypted_data).unwrap(), plaintext);
    }

    /// Test encryption with wrong password
    #[test]
    fn test_encryption_wrong_password() {
        let encryption_manager = EncryptionManager::new();

        let plaintext = "secret_data";
        let correct_password = "correct_password";
        let wrong_password = "wrong_password";

        // Encrypt with correct password
        let encrypted = encryption_manager
            .encrypt(plaintext.as_bytes(), correct_password)
            .unwrap();

        // Try to decrypt with wrong password
        let decrypted = encryption_manager.decrypt(&encrypted, wrong_password);
        assert!(decrypted.is_err());
    }

    /// Test key derivation consistency
    #[test]
    fn test_key_derivation_consistency() {
        let encryption_manager = EncryptionManager::new();

        let password = "test_password";
        let salt = b"test_salt_123456"; // 16 bytes

        // Derive key multiple times with same parameters
        let key1 = encryption_manager.derive_key(password, salt);
        let key2 = encryption_manager.derive_key(password, salt);

        assert!(key1.is_ok());
        assert!(key2.is_ok());
        assert_eq!(key1.unwrap(), key2.unwrap());
    }

    /// Test salt generation uniqueness
    #[test]
    fn test_salt_generation() {
        let encryption_manager = EncryptionManager::new();

        let salt1 = encryption_manager.generate_salt();
        let salt2 = encryption_manager.generate_salt();

        // Salts should be different
        assert_ne!(salt1, salt2);

        // Salts should be correct length (16 bytes)
        assert_eq!(salt1.len(), 16);
        assert_eq!(salt2.len(), 16);
    }
}

#[cfg(test)]
mod event_processing_tests {
    use super::*;

    /// Test event type enumeration
    #[test]
    fn test_event_types() {
        let event_types = vec![
            EventType::MarketData,
            EventType::OrderUpdate,
            EventType::RiskAlert,
            EventType::SystemStatus,
            EventType::ConfigChange,
            EventType::Metrics,
        ];

        for event_type in event_types {
            let event_name = format!("{:?}", event_type);
            assert!(!event_name.is_empty());
        }
    }

    /// Test TLI event creation and serialization
    #[test]
    fn test_tli_event_creation() {
        let event = TliEvent {
            event_id: Uuid::new_v4().to_string(),
            event_type: EventType::MarketData,
            source_service: "market_data_service".to_string(),
            timestamp: SystemTime::now()
                .duration_since(UNIX_EPOCH)
                .unwrap()
                .as_nanos() as i64,
            data: serde_json::json!({
                "symbol": "AAPL",
                "price": 150.25,
                "volume": 1000
            }),
            metadata: HashMap::from([
                ("exchange".to_string(), "NASDAQ".to_string()),
                ("data_type".to_string(), "QUOTE".to_string()),
            ]),
        };

        assert!(!event.event_id.is_empty());
        assert_eq!(event.source_service, "market_data_service");
        assert!(event.timestamp > 0);
        assert_eq!(event.data["symbol"], "AAPL");
        assert_eq!(event.metadata["exchange"], "NASDAQ");
    }

    /// Test event filtering logic
    #[test]
    fn test_event_filtering() {
        let events = vec![
            TliEvent {
                event_id: Uuid::new_v4().to_string(),
                event_type: EventType::MarketData,
                source_service: "market_data".to_string(),
                timestamp: 1000,
                data: serde_json::json!({"symbol": "AAPL"}),
                metadata: HashMap::new(),
            },
            TliEvent {
                event_id: Uuid::new_v4().to_string(),
                event_type: EventType::OrderUpdate,
                source_service: "trading_engine".to_string(),
                timestamp: 2000,
                data: serde_json::json!({"order_id": "123"}),
                metadata: HashMap::new(),
            },
            TliEvent {
                event_id: Uuid::new_v4().to_string(),
                event_type: EventType::RiskAlert,
                source_service: "risk_management".to_string(),
                timestamp: 3000,
                data: serde_json::json!({"alert": "VAR_EXCEEDED"}),
                metadata: HashMap::new(),
            },
        ];

        // Filter by event type
        let market_data_events: Vec<_> = events
            .iter()
            .filter(|e| matches!(e.event_type, EventType::MarketData))
            .collect();
        assert_eq!(market_data_events.len(), 1);

        // Filter by source service
        let trading_events: Vec<_> = events
            .iter()
            .filter(|e| e.source_service == "trading_engine")
            .collect();
        assert_eq!(trading_events.len(), 1);

        // Filter by timestamp range
        let recent_events: Vec<_> = events.iter().filter(|e| e.timestamp >= 2000).collect();
        assert_eq!(recent_events.len(), 2);
    }
}

#[cfg(test)]
mod validation_tests {
    use super::*;

    /// Test symbol validation comprehensive
    #[test]
    fn test_symbol_validation_comprehensive() {
        // Valid symbols
        let valid_symbols = vec![
            "AAPL",
            "MSFT",
            "GOOGL",
            "AMZN",
            "TSLA",
            "BTC-USD",
            "EUR_GBP",
            "SPX.INDEX",
            "VIX",
            "NVDA",
            "META",
            "NFLX",
            "AMD",
            "INTC",
        ];

        for symbol in valid_symbols {
            assert!(
                validate_symbol(symbol).is_ok(),
                "Symbol {} should be valid",
                symbol
            );
        }

        // Invalid symbols
        let invalid_symbols = vec![
            "",              // Empty
            "A",             // Too short for some exchanges
            &"A".repeat(25), // Too long
            "BTC/USD",       // Slash not allowed
            "BTC USD",       // Space not allowed
            "BTC@USD",       // Special char not allowed
            "BTC#USD",       // Hash not allowed
            "BTC%USD",       // Percent not allowed
        ];

        for symbol in invalid_symbols {
            assert!(
                validate_symbol(symbol).is_err(),
                "Symbol {} should be invalid",
                symbol
            );
        }
    }

    /// Test quantity validation edge cases
    #[test]
    fn test_quantity_validation_edge_cases() {
        // Valid quantities
        let valid_quantities = vec![
            0.000001,  // Very small
            0.1,       // Fractional
            1.0,       // Whole number
            1000.0,    // Large
            999999.99, // Very large
        ];

        for qty in valid_quantities {
            assert!(
                validate_quantity(qty).is_ok(),
                "Quantity {} should be valid",
                qty
            );
        }

        // Invalid quantities
        let invalid_quantities = vec![
            0.0,               // Zero
            -1.0,              // Negative
            -0.000001,         // Negative small
            f64::NAN,          // NaN
            f64::INFINITY,     // Positive infinity
            f64::NEG_INFINITY, // Negative infinity
        ];

        for qty in invalid_quantities {
            assert!(
                validate_quantity(qty).is_err(),
                "Quantity {} should be invalid",
                qty
            );
        }
    }

    /// Test price validation comprehensive
    #[test]
    fn test_price_validation_comprehensive() {
        // Valid prices
        let valid_prices = vec![
            0.0001,  // Very small price
            0.01,    // Penny stock
            1.0,     // Dollar
            150.25,  // Typical stock price
            50000.0, // High price (like BRK.A)
        ];

        for price in valid_prices {
            assert!(
                validate_price(price).is_ok(),
                "Price {} should be valid",
                price
            );
        }

        // Invalid prices
        let invalid_prices = vec![
            -0.01,             // Negative
            f64::NAN,          // NaN
            f64::INFINITY,     // Infinity
            f64::NEG_INFINITY, // Negative infinity
        ];

        for price in invalid_prices {
            assert!(
                validate_price(price).is_err(),
                "Price {} should be invalid",
                price
            );
        }
    }
}

#[cfg(test)]
mod type_conversion_tests {
    use super::*;

    /// Test timestamp conversions with high precision
    #[test]
    fn test_timestamp_conversions_precision() {
        let test_timestamps = vec![
            0i64,
            1_000_000_000,     // 1 second in nanos
            1_000_000_000_000, // 1000 seconds in nanos
            SystemTime::now()
                .duration_since(UNIX_EPOCH)
                .unwrap()
                .as_nanos() as i64,
        ];

        for timestamp in test_timestamps {
            let system_time = unix_nanos_to_system_time(timestamp);
            let converted = system_time_to_unix_nanos(system_time);

            // Allow for small rounding errors (< 1 microsecond)
            let diff = (converted - timestamp).abs();
            assert!(
                diff < 1000,
                "Timestamp conversion error too large: {} ns",
                diff
            );
        }
    }

    /// Test order type conversions
    #[test]
    fn test_order_type_conversions() {
        let order_types = vec![
            (OrderType::Market, "MARKET"),
            (OrderType::Limit, "LIMIT"),
            (OrderType::Stop, "STOP"),
            (OrderType::StopLimit, "STOP_LIMIT"),
        ];

        for (order_type, expected_string) in order_types {
            // Test to string conversion
            assert_eq!(order_type_to_string(order_type), expected_string);

            // Test from string conversion
            assert_eq!(string_to_order_type(expected_string).unwrap(), order_type);

            // Test case insensitive
            assert_eq!(
                string_to_order_type(&expected_string.to_lowercase()).unwrap(),
                order_type
            );
        }
    }

    /// Test order status conversions
    #[test]
    fn test_order_status_conversions() {
        let order_statuses = vec![
            (OrderStatus::New, "NEW"),
            (OrderStatus::PartiallyFilled, "PARTIALLY_FILLED"),
            (OrderStatus::Filled, "FILLED"),
            (OrderStatus::Cancelled, "CANCELLED"),
            (OrderStatus::Rejected, "REJECTED"),
            (OrderStatus::PendingCancel, "PENDING_CANCEL"),
            (OrderStatus::Expired, "EXPIRED"),
        ];

        for (status, expected_string) in order_statuses {
            assert_eq!(order_status_to_string(status), expected_string);
            assert_eq!(string_to_order_status(expected_string).unwrap(), status);
        }
    }

    /// Test metric creation with various data types
    #[test]
    fn test_metric_creation_types() {
        let labels = HashMap::from([
            ("service".to_string(), "trading".to_string()),
            ("environment".to_string(), "test".to_string()),
        ]);

        // Test different metric types
        let metrics = vec![
            ("latency_ms", 15.5, "milliseconds"),
            ("orders_per_second", 1000.0, "count/sec"),
            ("memory_usage_mb", 256.0, "megabytes"),
            ("cpu_utilization", 0.75, "percentage"),
        ];

        for (name, value, unit) in metrics {
            let metric = create_metric(name.to_string(), value, unit.to_string(), labels.clone());

            assert_eq!(metric.name, name);
            assert_eq!(metric.value, value);
            assert_eq!(metric.unit, unit);
            assert_eq!(metric.labels, labels);
            assert!(metric.timestamp_unix_nanos > 0);
        }
    }
}

// Property-based tests for comprehensive validation
proptest! {
    /// Property test for timestamp conversion round-trip
    #[test]
    fn prop_timestamp_roundtrip(timestamp in 0i64..i64::MAX/2) {
        let system_time = unix_nanos_to_system_time(timestamp);
        let converted = system_time_to_unix_nanos(system_time);

        // Allow for small rounding errors
        prop_assert!((converted - timestamp).abs() < 1000);
    }

    /// Property test for symbol validation with valid characters
    #[test]
    fn prop_symbol_validation(symbol in "[A-Z0-9._-]{1,20}") {
        prop_assert!(validate_symbol(&symbol).is_ok());
    }

    /// Property test for quantity validation with positive values
    #[test]
    fn prop_quantity_validation(quantity in 0.000001f64..1000000.0) {
        prop_assert!(validate_quantity(quantity).is_ok());
    }

    /// Property test for price validation with positive values
    #[test]
    fn prop_price_validation(price in 0.0001f64..100000.0) {
        prop_assert!(validate_price(price).is_ok());
    }

    /// Property test for position calculation consistency
    #[test]
    fn prop_position_calculation(
        quantity in -10000.0f64..10000.0,
        market_price in 0.01f64..1000.0,
        average_cost in 0.01f64..1000.0
    ) {
        let position = create_proto_position(
            "TEST".to_string(),
            quantity,
            market_price,
            average_cost,
        );

        prop_assert_eq!(position.quantity, quantity);
        prop_assert_eq!(position.market_price, market_price);
        prop_assert_eq!(position.average_cost, average_cost);
        prop_assert_eq!(position.market_value, quantity * market_price);
        prop_assert_eq!(position.unrealized_pnl, (market_price - average_cost) * quantity);
    }
}

#[cfg(test)]
mod error_handling_tests {
    use super::*;

    /// Test error type conversions and display
    #[test]
    fn test_error_types_comprehensive() {
        let errors = vec![
            TliError::Connection("Connection timeout".to_string()),
            TliError::InvalidRequest("Malformed request".to_string()),
            TliError::InvalidSymbol("Unknown symbol".to_string()),
            TliError::NotConnected("Service disconnected".to_string()),
            TliError::OrderValidation("Size too large".to_string()),
            TliError::RiskViolation("VaR limit exceeded".to_string()),
            TliError::GrpcError("gRPC call failed".to_string()),
            // Database errors removed - TLI is pure client
            TliError::EncryptionError("Decryption failed".to_string()),
            TliError::ConfigurationError("Invalid config".to_string()),
        ];

        for error in errors {
            // Test that display works
            let display_str = error.to_string();
            assert!(!display_str.is_empty());

            // Test that debug works
            let debug_str = format!("{:?}", error);
            assert!(!debug_str.is_empty());

            // Test error source if applicable
            assert!(error.source().is_none() || error.source().is_some());
        }
    }

    /// Test error propagation through Result chains
    #[test]
    fn test_error_propagation() {
        fn operation_that_fails() -> TliResult<String> {
            Err(TliError::Connection("Network unreachable".to_string()))
        }

        fn higher_level_operation() -> TliResult<String> {
            let result = operation_that_fails()?;
            Ok(format!("Success: {}", result))
        }

        let result = higher_level_operation();
        assert!(result.is_err());

        match result.unwrap_err() {
            TliError::Connection(msg) => assert_eq!(msg, "Network unreachable"),
            _ => panic!("Wrong error type"),
        }
    }
}

// Integration test setup helpers
#[cfg(test)]
mod test_helpers {
    use super::*;
    use std::sync::Once;

    static INIT: Once = Once::new();

    /// Setup test environment once
    pub fn setup_test_environment() {
        INIT.call_once(|| {
            // Initialize logging
            let _ = env_logger::builder()
                .filter_level(log::LevelFilter::Debug)
                .is_test(true)
                .try_init();

            // Set test environment variables
            std::env::set_var("TLI_TEST_MODE", "1");
            std::env::set_var("TLI_LOG_LEVEL", "debug");
        });
    }

    /// Create test configuration
    pub fn create_test_config() -> TradingClientConfig {
        TradingClientConfig {
            service_name: "test_trading_service".to_string(),
            request_timeout: Duration::from_millis(1000),
            order_validation: OrderValidationConfig {
                enable_pre_validation: true,
                max_order_size: 10_000.0,
                min_order_size: 1.0,
                validate_symbols: true,
                validate_market_hours: false,
            },
            risk_management: RiskManagementConfig {
                enable_risk_monitoring: true,
                max_position_exposure: 50_000.0,
                var_confidence_level: 0.95,
                alert_thresholds: Default::default(),
                enable_position_limits: true,
            },
            market_data: MarketDataConfig::default(),
            monitoring: MonitoringConfig::default(),
            event_streaming: Default::default(),
        }
    }

    /// Generate test order request
    pub fn create_test_order_request() -> SubmitOrderRequest {
        SubmitOrderRequest {
            symbol: "TEST".to_string(),
            side: OrderSide::Buy as i32,
            order_type: OrderType::Market as i32,
            quantity: 100.0,
            client_order_id: Uuid::new_v4().to_string(),
            price: Some(150.0),
            time_in_force: TimeInForce::Day as i32,
            ..Default::default()
        }
    }

    /// Generate test market data
    pub fn create_test_market_data() -> MarketDataSnapshot {
        MarketDataSnapshot {
            symbol: "TEST".to_string(),
            last_price: Some(150.0),
            bid_price: Some(149.95),
            ask_price: Some(150.05),
            bid_size: Some(1000),
            ask_size: Some(500),
            volume: Some(1_000_000),
            timestamp: Instant::now(),
        }
    }
}