foxhunt/AGENT_169_COMPILATION_ERRORS.md

# Agent 169: Paper Trading Compilation Errors Report

**Status**: ❌ **COMPILATION FAILED** - 4 critical SQL errors
**Date**: 2025-10-15 00:32 UTC
**Mission**: Validate trading_service compilation with paper trading fixes

---

## Executive Summary

**Outcome**: `cargo sqlx prepare` executed successfully but **compilation failed** with 4 database schema errors:

1. ❌ Missing `account_id` column in `ensemble_predictions` table
2. ❌ Missing `get_top_models_24h()` PostgreSQL function
3. ❌ Missing `get_high_disagreement_events_24h()` PostgreSQL function
4. ❌ `order_side` enum type mapping issue (SQLx type override required)

**Code Quality**: ✅ Agent 157-159 fixes are correct (enum case, SELECT * removal)

**Root Cause**: **Database schema drift** - Application code expects schema features not present in database

---

## Compilation Error Details

### Error 1: Missing account_id Column ❌

**Location**: `services/trading_service/src/ensemble_audit_logger.rs:376`

**Error Message**:
```
error: error returned from database: column "account_id" of relation "ensemble_predictions" does not exist
   --> services/trading_service/src/ensemble_audit_logger.rs:376:13
    |
376 | /             sqlx::query!(
377 | |                 r#"
378 | |                 INSERT INTO ensemble_predictions (
379 | |                     id, symbol, account_id, strategy_id,
```

**Query**:
```sql
INSERT INTO ensemble_predictions (
    id, symbol, account_id, strategy_id,  -- account_id NOT IN TABLE
    ...
)
```

**Database Schema** (Expected):
- Table: `ensemble_predictions`
- Missing column: `account_id` (VARCHAR/TEXT)

**Fix Required**:
1. Database migration to add `account_id` column
2. Or remove `account_id` from INSERT query if not needed

---

### Error 2: Missing get_top_models_24h() Function ❌

**Location**: `services/trading_service/src/ensemble_audit_logger.rs:527`

**Error Message**:
```
error: error returned from database: function get_top_models_24h(unknown, unknown) does not exist
   --> services/trading_service/src/ensemble_audit_logger.rs:527:23
    |
527 |           let results = sqlx::query_as!(
528 | |             ModelPerformanceSummary,
529 | |             r#"
530 | |             SELECT
...   |
540 | |             limit,
541 | |         )
```

**Query**:
```sql
SELECT * FROM get_top_models_24h($1, $2)
```

**Database Schema** (Expected):
- Function: `get_top_models_24h(metric_type, limit) RETURNS TABLE(...)`
- Missing from PostgreSQL database

**Fix Required**:
1. Database migration to create `get_top_models_24h()` function
2. Or replace function call with equivalent SQL query

---

### Error 3: Missing get_high_disagreement_events_24h() Function ❌

**Location**: `services/trading_service/src/ensemble_audit_logger.rs:555`

**Error Message**:
```
error: error returned from database: function get_high_disagreement_events_24h(unknown, unknown, unknown) does not exist
   --> services/trading_service/src/ensemble_audit_logger.rs:555:23
    |
555 |           let results = sqlx::query_as!(
556 | |             HighDisagreementEvent,
557 | |             r#"
558 | |             SELECT
...   |
572 | |             limit,
573 | |         )
```

**Query**:
```sql
SELECT * FROM get_high_disagreement_events_24h($1, $2, $3)
```

**Database Schema** (Expected):
- Function: `get_high_disagreement_events_24h(threshold, time_window, limit) RETURNS TABLE(...)`
- Missing from PostgreSQL database

**Fix Required**:
1. Database migration to create `get_high_disagreement_events_24h()` function
2. Or replace function call with equivalent SQL query

---

### Error 4: order_side Enum Type Override Required ❌

**Location**: `services/trading_service/src/paper_trading_executor.rs:352`

**Error Message**:
```
error: no built in mapping found for type order_side for param #3; a type override may be required, see documentation for details
   --> services/trading_service/src/paper_trading_executor.rs:352:9
    |
352 | /         sqlx::query!(
353 | |             r#"
354 | |             INSERT INTO orders (
355 | |                 id, symbol, side, order_type, quantity, limit_price,
...   |
368 | |             self.config.account_id,
369 | |         )
```

**Query**:
```rust
let side = prediction.ensemble_action.to_lowercase();  // 'buy' or 'sell'

sqlx::query!(
    r#"
    INSERT INTO orders (
        id, symbol, side, order_type, quantity, limit_price,
        ...
    ) VALUES (
        $1, $2, $3::order_side, 'market'::order_type, $4, $5,
        ...
    )
    "#,
    order_id,
    prediction.symbol,
    side,  // ERROR: SQLx doesn't know how to map String to order_side enum
    ...
)
```

**Root Cause**: SQLx macro cannot infer type mapping from `String` to PostgreSQL `order_side` enum

**Fix Required**: Type override annotation
```rust
sqlx::query!(
    r#"
    INSERT INTO orders (
        id, symbol, side, order_type, quantity, limit_price,
        ...
    ) VALUES (
        $1, $2, $3 AS order_side, 'market'::order_type, $4, $5,
        ...
    )
    "#,
    order_id,
    prediction.symbol,
    side as _,  // Type override: let SQLx infer as TEXT, PostgreSQL casts to order_side
    ...
)
```

**Alternative Fix**: Use `query_as!` with explicit type annotation
```rust
#[derive(sqlx::Type)]
#[sqlx(type_name = "order_side")]
enum OrderSide {
    #[sqlx(rename = "buy")]
    Buy,
    #[sqlx(rename = "sell")]
    Sell,
}

let side = match prediction.ensemble_action.to_lowercase().as_str() {
    "buy" => OrderSide::Buy,
    "sell" => OrderSide::Sell,
    _ => return Err(...),
};

sqlx::query!(
    "INSERT INTO orders (...) VALUES (..., $3, ...)",
    ...,
    side,  // Now SQLx knows it's order_side enum
)
```

---

## Code Changes From Agents 157-159 Status

### Agent 157: SQL Enum Case Fix ✅

**File**: `services/trading_service/src/paper_trading_executor.rs`

**Status**: ✅ **CORRECT** - Code change is valid

**Change**:
```rust
let side = prediction.ensemble_action.to_lowercase();  // 'buy' or 'sell'
```

**Validation**: Lowercase conversion is correct for PostgreSQL enum compatibility

**Issue**: SQLx type mapping error is **separate problem** (not Agent 157's fault)

---

### Agent 159: SELECT * Removal ✅

**File**: `services/trading_service/src/ensemble_audit_logger.rs`

**Status**: ✅ **CORRECT** - Code changes are valid

**Changes**:
1. Replaced `SELECT *` with explicit column lists
2. Added column names to `query_as!` macros

**Validation**: Explicit columns are correct for SQLx offline mode

**Issue**: Missing database schema features (account_id, functions) are **separate problems**

---

## Database Schema Drift Analysis

### Expected Schema (Application Code)

1. **ensemble_predictions** table:
   - Columns: `id`, `symbol`, `account_id`, `strategy_id`, ...
   - `account_id` column present

2. **get_top_models_24h()** function:
   - Parameters: `metric_type`, `limit`
   - Returns: Table with model performance metrics

3. **get_high_disagreement_events_24h()** function:
   - Parameters: `threshold`, `time_window`, `limit`
   - Returns: Table with high disagreement events

4. **orders** table:
   - `side` column: `order_side` enum ('buy', 'sell')
   - Accepts String values with type casting

---

### Actual Schema (PostgreSQL Database)

1. **ensemble_predictions** table:
   - ❌ Missing `account_id` column

2. **get_top_models_24h()** function:
   - ❌ Function does not exist

3. **get_high_disagreement_events_24h()** function:
   - ❌ Function does not exist

4. **orders** table:
   - ✅ `side` column exists as `order_side` enum
   - ⚠️ SQLx type mapping requires explicit override

---

### Root Cause: Incomplete Database Migrations

**Theory**: Recent code changes added new schema features without corresponding migrations:

1. `account_id` column added to ensemble predictions tracking
2. `get_top_models_24h()` function for performance analytics
3. `get_high_disagreement_events_24h()` function for ensemble monitoring

**Evidence**:
- Application code expects features
- Database schema lacks features
- No migration files found for these features

**Fix Required**: Create database migrations for all missing schema features

---

## Migration Files Needed

### Migration 1: Add account_id to ensemble_predictions

**File**: `migrations/XXXX_add_account_id_to_ensemble_predictions.sql`

```sql
-- Add account_id column to ensemble_predictions table
ALTER TABLE ensemble_predictions
ADD COLUMN account_id VARCHAR(255);

-- Optional: Add index for account_id queries
CREATE INDEX idx_ensemble_predictions_account_id
ON ensemble_predictions(account_id);

-- Optional: Add foreign key constraint (if accounts table exists)
-- ALTER TABLE ensemble_predictions
-- ADD CONSTRAINT fk_ensemble_predictions_account_id
-- FOREIGN KEY (account_id) REFERENCES accounts(id);
```

---

### Migration 2: Create get_top_models_24h() Function

**File**: `migrations/XXXX_create_get_top_models_24h_function.sql`

```sql
-- Create function to get top performing models in last 24 hours
CREATE OR REPLACE FUNCTION get_top_models_24h(
    p_metric_type TEXT,
    p_limit INT
) RETURNS TABLE (
    model_name TEXT,
    total_predictions BIGINT,
    correct_predictions BIGINT,
    accuracy DOUBLE PRECISION,
    avg_confidence DOUBLE PRECISION,
    sharpe_ratio DOUBLE PRECISION
) AS $$
BEGIN
    RETURN QUERY
    SELECT
        ep.model_name::TEXT,
        COUNT(*)::BIGINT as total_predictions,
        SUM(CASE WHEN ep.actual_outcome = ep.predicted_outcome THEN 1 ELSE 0 END)::BIGINT as correct_predictions,
        (SUM(CASE WHEN ep.actual_outcome = ep.predicted_outcome THEN 1 ELSE 0 END)::DOUBLE PRECISION / COUNT(*)) as accuracy,
        AVG(ep.confidence)::DOUBLE PRECISION as avg_confidence,
        0.0::DOUBLE PRECISION as sharpe_ratio  -- TODO: Calculate from actual PnL
    FROM ensemble_predictions ep
    WHERE ep.timestamp >= NOW() - INTERVAL '24 hours'
    GROUP BY ep.model_name
    ORDER BY
        CASE
            WHEN p_metric_type = 'accuracy' THEN (SUM(CASE WHEN ep.actual_outcome = ep.predicted_outcome THEN 1 ELSE 0 END)::DOUBLE PRECISION / COUNT(*))
            WHEN p_metric_type = 'volume' THEN COUNT(*)::DOUBLE PRECISION
            ELSE AVG(ep.confidence)::DOUBLE PRECISION
        END DESC
    LIMIT p_limit;
END;
$$ LANGUAGE plpgsql;
```

---

### Migration 3: Create get_high_disagreement_events_24h() Function

**File**: `migrations/XXXX_create_get_high_disagreement_events_24h_function.sql`

```sql
-- Create function to get high model disagreement events
CREATE OR REPLACE FUNCTION get_high_disagreement_events_24h(
    p_threshold DOUBLE PRECISION,
    p_time_window INTERVAL,
    p_limit INT
) RETURNS TABLE (
    prediction_id UUID,
    timestamp TIMESTAMP,
    symbol TEXT,
    disagreement_score DOUBLE PRECISION,
    model_votes_buy INT,
    model_votes_sell INT,
    model_votes_hold INT,
    ensemble_action TEXT
) AS $$
BEGIN
    RETURN QUERY
    SELECT
        ep.id as prediction_id,
        ep.timestamp,
        ep.symbol::TEXT,
        ep.disagreement_score::DOUBLE PRECISION,
        ep.votes_buy::INT as model_votes_buy,
        ep.votes_sell::INT as model_votes_sell,
        ep.votes_hold::INT as model_votes_hold,
        ep.ensemble_action::TEXT
    FROM ensemble_predictions ep
    WHERE ep.timestamp >= NOW() - p_time_window
      AND ep.disagreement_score >= p_threshold
    ORDER BY ep.disagreement_score DESC
    LIMIT p_limit;
END;
$$ LANGUAGE plpgsql;
```

**Note**: Assumes `ensemble_predictions` table has columns: `disagreement_score`, `votes_buy`, `votes_sell`, `votes_hold`. If not, these need to be added first.

---

### Migration 4: Add Enum Vote Columns (If Missing)

**File**: `migrations/XXXX_add_vote_columns_to_ensemble_predictions.sql`

```sql
-- Add vote tracking columns to ensemble_predictions
ALTER TABLE ensemble_predictions
ADD COLUMN IF NOT EXISTS votes_buy INT DEFAULT 0,
ADD COLUMN IF NOT EXISTS votes_sell INT DEFAULT 0,
ADD COLUMN IF NOT EXISTS votes_hold INT DEFAULT 0,
ADD COLUMN IF NOT EXISTS disagreement_score DOUBLE PRECISION DEFAULT 0.0;

-- Add index for disagreement queries
CREATE INDEX IF NOT EXISTS idx_ensemble_predictions_disagreement
ON ensemble_predictions(disagreement_score DESC)
WHERE disagreement_score > 0.5;
```

---

## SQLx Type Mapping Fix for order_side

### Option 1: Type Override in Query (Simplest)

**File**: `services/trading_service/src/paper_trading_executor.rs:352`

**Change**:
```rust
// Current (fails)
sqlx::query!(
    r#"
    INSERT INTO orders (
        id, symbol, side, order_type, quantity, limit_price,
        status, account_id, created_at, updated_at, venue, time_in_force
    ) VALUES (
        $1, $2, $3::order_side, 'market'::order_type, $4, $5,
        'filled'::order_status, $6, EXTRACT(EPOCH FROM NOW())::bigint * 1000000000,
        EXTRACT(EPOCH FROM NOW())::bigint * 1000000000, 'PAPER_TRADING', 'day'::time_in_force
    )
    "#,
    order_id,
    prediction.symbol,
    side,  // ERROR: no type mapping
    ...
)

// Fixed (type override)
sqlx::query!(
    r#"
    INSERT INTO orders (
        id, symbol, side, order_type, quantity, limit_price,
        status, account_id, created_at, updated_at, venue, time_in_force
    ) VALUES (
        $1, $2, $3::order_side, 'market'::order_type, $4, $5,
        'filled'::order_status, $6, EXTRACT(EPOCH FROM NOW())::bigint * 1000000000,
        EXTRACT(EPOCH FROM NOW())::bigint * 1000000000, 'PAPER_TRADING', 'day'::time_in_force
    )
    "#,
    order_id,
    prediction.symbol,
    side as _, // Type override: let PostgreSQL cast TEXT to order_side
    ...
)
```

**Pros**: Minimal code change, leverages PostgreSQL type casting
**Cons**: Less type safety at compile time

---

### Option 2: Rust Enum Type (Best Practice)

**File**: `services/trading_service/src/types.rs` (or inline)

**Add**:
```rust
#[derive(Debug, Clone, Copy, sqlx::Type)]
#[sqlx(type_name = "order_side")]
#[sqlx(rename_all = "lowercase")]
pub enum OrderSide {
    Buy,
    Sell,
}

impl OrderSide {
    pub fn from_string(s: &str) -> Result<Self, String> {
        match s.to_lowercase().as_str() {
            "buy" => Ok(OrderSide::Buy),
            "sell" => Ok(OrderSide::Sell),
            _ => Err(format!("Invalid order side: {}", s)),
        }
    }
}
```

**File**: `services/trading_service/src/paper_trading_executor.rs:352`

**Change**:
```rust
use crate::types::OrderSide;

// Convert String to OrderSide enum
let side = OrderSide::from_string(&prediction.ensemble_action)?;

sqlx::query!(
    r#"
    INSERT INTO orders (
        id, symbol, side, order_type, quantity, limit_price,
        status, account_id, created_at, updated_at, venue, time_in_force
    ) VALUES (
        $1, $2, $3, 'market'::order_type, $4, $5,
        'filled'::order_status, $6, EXTRACT(EPOCH FROM NOW())::bigint * 1000000000,
        EXTRACT(EPOCH FROM NOW())::bigint * 1000000000, 'PAPER_TRADING', 'day'::time_in_force
    )
    "#,
    order_id,
    prediction.symbol,
    side,  // Now SQLx knows it's order_side enum
    ...
)
```

**Pros**: Full compile-time type safety, cleaner code
**Cons**: More code changes required

---

## Warnings Summary

**ML Module Warnings** (11 warnings):
- Unused imports: `Device`, `ModelVote`, `TradingAction`
- Unused variables: `alpha`, `power`, `checkpoint_path`, `params`
- Unsafe blocks in PPO checkpoint loading (lines 750, 774)
- Missing Debug implementations (5 types)

**Trading Service Warnings** (8 warnings):
- Unused imports: `TradingAction`, `ComprehensiveVaRResult`, `Postgres`, `Transaction`, `error`, `warn`, `SystemTime`, `Price`, `Symbol`, `MLError`, `ModelHealth`
- Unused variable: `symbol` in `extract_features_for_symbol`

**Impact**: Warnings do not block compilation but should be cleaned up for production

---

## Next Steps for Agent 170

### 1. Create Database Migrations (CRITICAL)

**Priority**: HIGH - Blocks all compilation

**Tasks**:
1. Create `migrations/XXXX_add_account_id_to_ensemble_predictions.sql`
2. Create `migrations/XXXX_create_get_top_models_24h_function.sql`
3. Create `migrations/XXXX_create_get_high_disagreement_events_24h_function.sql`
4. Create `migrations/XXXX_add_vote_columns_to_ensemble_predictions.sql` (if columns missing)

**Validation**:
```bash
cargo sqlx migrate run
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c '\df get_top_models_24h'
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt -c '\d ensemble_predictions'
```

---

### 2. Fix order_side Type Mapping (CRITICAL)

**Priority**: HIGH - Blocks compilation

**Recommended Approach**: Option 2 (Rust enum type) for type safety

**File Changes**:
1. Add `OrderSide` enum to `services/trading_service/src/types.rs`
2. Update `paper_trading_executor.rs` to use enum
3. Update any other code using `order_side` strings

**Validation**:
```bash
cargo check -p trading_service
```

---

### 3. Run cargo sqlx prepare Again

**Command**:
```bash
cd /home/jgrusewski/Work/foxhunt/services/trading_service
cargo sqlx prepare 2>&1
```

**Expected**: ✅ All queries validated, cache files generated

---

### 4. Validate Offline Compilation

**Command**:
```bash
SQLX_OFFLINE=true cargo check -p trading_service
```

**Expected**: ✅ Compilation success

---

### 5. Clean Up Warnings (Optional)

**Priority**: LOW - Does not block compilation

**Tasks**:
- Remove unused imports
- Prefix unused variables with `_`
- Add `#[allow(unsafe_code)]` annotations (with justification)
- Add `#[derive(Debug)]` to types

---

## Production Impact

### Before Database Migrations

❌ **COMPILATION FAILURE**:
- Missing `account_id` column
- Missing PostgreSQL functions
- `order_side` type mapping issue
- **Impact**: Cannot deploy trading_service

---

### After Database Migrations + Type Fix

✅ **COMPILATION SUCCESS** (Expected):
- All schema features present
- Type safety enforced
- SQLx offline mode validated
- **Impact**: Trading service ready for deployment

---

## Key Insights

### 1. Database Schema Drift is Real

**Evidence**: Application code expects features not in database

**Root Cause**: Migrations not created for new features

**Lesson**: Always create migrations before using new schema features in code

---

### 2. Agent 157-159 Fixes Were Correct

**Validation**: Enum case conversion and SELECT * removal are valid changes

**Issue**: Separate database schema problems exposed during compilation

**Lesson**: Code changes can be correct but fail due to environment mismatches

---

### 3. SQLx Type Mapping Requires Explicit Annotations

**Problem**: String → PostgreSQL enum cast requires type override

**Solution**: Use `as _` override or Rust enum with `#[sqlx(Type)]`

**Lesson**: PostgreSQL custom types need explicit SQLx type mappings

---

### 4. Compilation Errors Provide Actionable Diagnostics

**Quality**: SQLx errors clearly identify:
- Missing columns
- Missing functions
- Type mapping issues
- Line numbers and file paths

**Lesson**: SQLx's compile-time validation is excellent for catching schema drift

---

## Files Modified Summary

| File | Status | Issue |
|------|--------|-------|
| `paper_trading_executor.rs` | ⚠️ Needs type fix | `order_side` enum mapping |
| `ensemble_audit_logger.rs` | ⚠️ Needs migrations | Missing DB schema features |
| `.sqlx/query-*.json` | ❌ Not generated | Compilation failed before cache creation |

---

## Migration Execution Plan

### Phase 1: Schema Additions (5 min)

```bash
cd /home/jgrusewski/Work/foxhunt

# Create migration files (Agent 170)
# Then run:
cargo sqlx migrate run

# Verify:
psql postgresql://foxhunt:foxhunt_dev_password@localhost:5432/foxhunt << EOF
\d ensemble_predictions
\df get_top_models_24h
\df get_high_disagreement_events_24h
EOF
```

---

### Phase 2: Code Fixes (10 min)

```bash
# Fix order_side type mapping (Agent 170)
# Add OrderSide enum to types.rs
# Update paper_trading_executor.rs

# Verify:
cargo check -p trading_service
```

---

### Phase 3: Cache Generation (2 min)

```bash
cd services/trading_service
cargo sqlx prepare 2>&1
ls -lh .sqlx/  # Verify cache files created
```

---

### Phase 4: Validation (5 min)

```bash
SQLX_OFFLINE=true cargo check -p trading_service
cargo test -p trading_service --lib
cargo test -p trading_service --test paper_trading_executor_tests
```

---

**Total Estimated Time**: 22 minutes

---

## Compliance Verification

### Anti-Workaround Protocol ✅

- ✅ **No Placeholders**: Actual database migrations required
- ✅ **Root Cause Identified**: Schema drift from missing migrations
- ✅ **Proper Tooling**: Using SQLx compile-time validation
- ✅ **No Shortcuts**: Must create real migrations and run them
- ✅ **Complete Fixes**: Type safety enforced via Rust enums

---

### Code Quality ✅

- ✅ **Compile-Time Validation**: SQLx catches schema mismatches
- ✅ **Type Safety**: Rust enum for order_side (recommended)
- ✅ **Explicit Schemas**: SELECT * already removed (Agent 159)
- ✅ **Production Ready**: After migrations, code will be deployment-ready

---

## Summary

**Outcome**: ❌ **COMPILATION FAILED** - 4 database schema errors

**Root Cause**: **Database schema drift** - Missing columns and functions

**Agent 157-159 Status**: ✅ **CORRECT** - Code changes are valid

**Next Steps**: Create 4 database migrations + fix `order_side` type mapping

**Estimated Fix Time**: 22 minutes (migrations + code changes + validation)

**Production Impact**: **HIGH** - Deployment blocked until schema synchronized

**Anti-Workaround**: ✅ **FULL COMPLIANCE** - No shortcuts, proper migrations required

---

**Documentation Generated**: 2025-10-15 00:32 UTC
**Agent**: Claude Code Agent 169
**Mission Status**: ❌ FAILED (schema drift) → ⏩ FORWARD TO AGENT 170 (create migrations)